]> source.dussan.org Git - sonarqube.git/commitdiff
Tests should not catch the exception
authorDavid Gageot <david@gageot.net>
Wed, 13 May 2015 09:47:38 +0000 (11:47 +0200)
committerDavid Gageot <david@gageot.net>
Wed, 13 May 2015 13:13:54 +0000 (15:13 +0200)
sonar-core/src/test/java/org/sonar/jpa/session/DatabaseSessionTest.java

index b3d0c14da46a9999eadabe9d3a53b60647df88c9..ff941b979c951236069018727600790c8e830d13 100644 (file)
@@ -73,14 +73,9 @@ public class DatabaseSessionTest extends AbstractDbUnitTestCase {
     assertNull(getSession().getSingleResult(ResourceModel.class, "name", "test"));
   }
 
-  @Test
+  @Test(expected = IllegalStateException.class)
   public void testGetSingleResultWithNoCriterias() {
-    try {
-      assertNull(getSession().getSingleResult(ResourceModel.class, (Object[]) null));
-      fail("No IllegalStateException raised");
-    } catch (IllegalStateException ex) {
-      // error raised correctly
-    }
+    assertNull(getSession().getSingleResult(ResourceModel.class, (Object[]) null));
   }
 
   @Test
@@ -91,15 +86,10 @@ public class DatabaseSessionTest extends AbstractDbUnitTestCase {
     assertEquals(project1, hit);
   }
 
-  @Test
+  @Test(expected = NonUniqueResultException.class)
   public void testGetSingleResultWithTwoResults() {
     getSession().save(project1, project2);
-    try {
-      getSession().getSingleResult(ResourceModel.class, "qualifier", "JAV");
-      fail("No NonUniqueResultException raised");
-    } catch (NonUniqueResultException ex) {
-      // error raised correctly
-    }
+    getSession().getSingleResult(ResourceModel.class, "qualifier", "JAV");
   }
 
   @Test