Find directly the label instead of falling back to it

The input element is always hidden, so the check always ended falling
back to the label. Moreover, the label is the element that the user
interacts with, so it must be the one used.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

diff --git a/tests/acceptance/features/bootstrap/AppSettingsContext.php b/tests/acceptance/features/bootstrap/AppSettingsContext.php
index eda9fe200d0e3d6359272dbcf01b04fd98591da3..c9ff57f376c45e5e5242d59efd44c7a0a3e90424 100644 (file)
--- a/tests/acceptance/features/bootstrap/AppSettingsContext.php
+++ b/tests/acceptance/features/bootstrap/AppSettingsContext.php
@@ -81,14 +81,7 @@ class AppSettingsContext implements Context, ActorAwareInterface {
         * @Given I toggle the :id checkbox in the settings
         */
        public function iToggleTheCheckboxInTheSettingsTo($id) {
-               $locator = self::CheckboxInTheSettings($id);
-
-               // If locator is not visible, fallback to label
-               if (!$this->actor->find(self::CheckboxInTheSettings($id), 10)->isVisible()) {
-                       $locator = self::checkboxLabelInTheSettings($id);
-               }
-
-               $this->actor->find($locator, 10)->click();
+               $this->actor->find(self::checkboxLabelInTheSettings($id), 10)->click();
        }
 
        /**