SONAR-3665 Boolean widget properties are not saved when editing a widget

diff --git a/sonar-server/src/main/webapp/WEB-INF/app/helpers/properties_helper.rb b/sonar-server/src/main/webapp/WEB-INF/app/helpers/properties_helper.rb
index 65fb7cc3ebd0f518b851d7ecf661c43ee5dea5c7..9e4eb3e29aeb15f82944b95d6ce92a4e1fab7ad2 100644 (file)
--- a/sonar-server/src/main/webapp/WEB-INF/app/helpers/properties_helper.rb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/helpers/properties_helper.rb
@@ -30,7 +30,7 @@ module PropertiesHelper
       password_field_tag key, value, {:size => 25}.update(options)
 
     elsif type==PropertyType::TYPE_BOOLEAN
-      check_box_tag key, "true", value=='true', options
+      (hidden_field_tag key, 'false', options) + (check_box_tag key, 'true', value=='true', options)
 
     elsif type==PropertyType::TYPE_INTEGER
       text_field_tag key, value, {:size => 10}.update(options)

diff --git a/sonar-server/src/main/webapp/WEB-INF/app/helpers/widget_properties_helper.rb b/sonar-server/src/main/webapp/WEB-INF/app/helpers/widget_properties_helper.rb
index d19fe7761143903d7f14297c1bf3d18a61a55a4a..9ac91abcbacdfe320cc9c811d08c448dcf0bf3ed 100644 (file)
--- a/sonar-server/src/main/webapp/WEB-INF/app/helpers/widget_properties_helper.rb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/helpers/widget_properties_helper.rb
@@ -21,7 +21,7 @@ module WidgetPropertiesHelper
   include PropertiesHelper
 
   def property_value_field(definition, value)
-    property_value definition.key(), definition.type.name(), value || definition.defaultValue()
+    property_value definition.key(), definition.type.name(), value.nil? ? definition.defaultValue() : value
   end
 
   def resource_value_field(value)