]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-18329 [1109516] Page <title> does not identify purpose of page
authorWouter Admiraal <wouter.admiraal@sonarsource.com>
Thu, 2 Feb 2023 08:45:59 +0000 (09:45 +0100)
committersonartech <sonartech@sonarsource.com>
Thu, 2 Feb 2023 20:03:40 +0000 (20:03 +0000)
server/sonar-web/src/main/js/apps/code/components/CodeApp.tsx

index 53bc79a18e16e7c8f8c41ff8347a894245cf5739..b7dbcdd5bc9119b5df93fad8e53b3105d4e14c46 100644 (file)
@@ -35,7 +35,7 @@ import { isPullRequest } from '../../../helpers/branch-like';
 import { translate } from '../../../helpers/l10n';
 import { CodeScope, getCodeUrl, getProjectUrl } from '../../../helpers/urls';
 import { BranchLike } from '../../../types/branch-like';
-import { ComponentQualifier, isPortfolioLike } from '../../../types/component';
+import { ComponentQualifier, isApplication, isPortfolioLike } from '../../../types/component';
 import { Breadcrumb, Component, ComponentMeasure, Dict, Issue, Metric } from '../../../types/types';
 import { addComponent, addComponentBreadcrumbs, clearBucket } from '../bucket';
 import '../code.css';
@@ -282,15 +282,12 @@ export class CodeApp extends React.Component<Props, State> {
     );
     const metrics = metricKeys.map((metric) => this.props.metrics[metric]);
 
-    const defaultTitle =
-      baseComponent &&
-      [
-        ComponentQualifier.Application,
-        ComponentQualifier.Portfolio,
-        ComponentQualifier.SubPortfolio,
-      ].includes(baseComponent.qualifier as ComponentQualifier)
-        ? translate('projects.page')
-        : translate('code.page');
+    let defaultTitle = translate('code.page');
+    if (isApplication(baseComponent?.qualifier)) {
+      defaultTitle = translate('projects.page');
+    } else if (isPortfolioLike(baseComponent?.qualifier)) {
+      defaultTitle = translate('portfolio_breakdown.page');
+    }
 
     const isPortfolio = isPortfolioLike(qualifier);