Add an trailing slash to dashboard links (#29555)

Fix #29533, and add some tests for "base/paginate.tmpl"

diff --git a/modules/translation/mock.go b/modules/translation/mock.go
index 1f0559f38d0d24136b3fca7e8e2b715924fe490e..18fbc1044add5cb602bdc6dc28b6c3df8b510023 100644 (file)
--- a/modules/translation/mock.go
+++ b/modules/translation/mock.go
@@ -9,7 +9,9 @@ import (
 )
 
 // MockLocale provides a mocked locale without any translations
-type MockLocale struct{}
+type MockLocale struct {
+       Lang, LangName string // these fields are used directly in templates: ctx.Locale.Lang
+}
 
 var _ Locale = (*MockLocale)(nil)
 

diff --git a/modules/translation/translation.go b/modules/translation/translation.go
index b7c18f610adae59318779f7cf972b628a5bdf559..36ae58a9f19ad04cbf6c0ac81f4798b1d44170aa 100644 (file)
--- a/modules/translation/translation.go
+++ b/modules/translation/translation.go
@@ -144,7 +144,7 @@ func Match(tags ...language.Tag) language.Tag {
 // locale represents the information of localization.
 type locale struct {
        i18n.Locale
-       Lang, LangName string // these fields are used directly in templates: .i18n.Lang
+       Lang, LangName string // these fields are used directly in templates: ctx.Locale.Lang
        msgPrinter     *message.Printer
 }
 

diff --git a/routers/web/user/home_test.go b/routers/web/user/home_test.go
index 3f5fd266895096f240712ae7d6f48db562235f15..1cc9886308c357660e76d54468e64401b128082f 100644 (file)
--- a/routers/web/user/home_test.go
+++ b/routers/web/user/home_test.go
@@ -11,6 +11,8 @@ import (
        repo_model "code.gitea.io/gitea/models/repo"
        "code.gitea.io/gitea/models/unittest"
        "code.gitea.io/gitea/modules/setting"
+       "code.gitea.io/gitea/modules/templates"
+       "code.gitea.io/gitea/services/context"
        "code.gitea.io/gitea/services/contexttest"
 
        "github.com/stretchr/testify/assert"
@@ -113,3 +115,18 @@ func TestMilestonesForSpecificRepo(t *testing.T) {
        assert.Len(t, ctx.Data["Milestones"], 1)
        assert.Len(t, ctx.Data["Repos"], 2) // both repo 42 and 1 have milestones and both are owned by user 2
 }
+
+func TestDashboardPagination(t *testing.T) {
+       ctx, _ := contexttest.MockContext(t, "/", contexttest.MockContextOption{Render: templates.HTMLRenderer()})
+       page := context.NewPagination(10, 3, 1, 3)
+
+       setting.AppSubURL = "/SubPath"
+       out, err := ctx.RenderToHTML("base/paginate", map[string]any{"Link": setting.AppSubURL, "Page": page})
+       assert.NoError(t, err)
+       assert.Contains(t, out, `<a class=" item navigation" href="/SubPath/?page=2">`)
+
+       setting.AppSubURL = ""
+       out, err = ctx.RenderToHTML("base/paginate", map[string]any{"Link": setting.AppSubURL, "Page": page})
+       assert.NoError(t, err)
+       assert.Contains(t, out, `<a class=" item navigation" href="/?page=2">`)
+}

diff --git a/services/contexttest/context_tests.go b/services/contexttest/context_tests.go
index 8a7dd69a0f0e5de8fc4376aa16c5f285d71c885f..431017a30dcb603a33aec0efa29c4a6b54803f6b 100644 (file)
--- a/services/contexttest/context_tests.go
+++ b/services/contexttest/context_tests.go
@@ -12,6 +12,7 @@ import (
        "net/url"
        "strings"
        "testing"
+       "time"
 
        access_model "code.gitea.io/gitea/models/perm/access"
        repo_model "code.gitea.io/gitea/models/repo"
@@ -61,7 +62,8 @@ func MockContext(t *testing.T, reqPath string, opts ...MockContextOption) (*cont
        base.Locale = &translation.MockLocale{}
 
        ctx := context.NewWebContext(base, opt.Render, nil)
-
+       ctx.PageData = map[string]any{}
+       ctx.Data["PageStartTime"] = time.Now()
        chiCtx := chi.NewRouteContext()
        ctx.Base.AppendContextValue(chi.RouteCtxKey, chiCtx)
        return ctx, resp

diff --git a/templates/base/paginate.tmpl b/templates/base/paginate.tmpl
index 503817c3398f643c5dc398c0b086c51ebdbc14fd..ef7d0b341bcfdfd36d53b3706521433bc3a5f297 100644 (file)
--- a/templates/base/paginate.tmpl
+++ b/templates/base/paginate.tmpl
@@ -1,13 +1,15 @@
-{{$paginationLink := .Page.GetParams}}
+{{$paginationParams := .Page.GetParams}}
+{{$paginationLink := $.Link}}
+{{if eq $paginationLink AppSubUrl}}{{$paginationLink = print $paginationLink "/"}}{{end}}
 {{with .Page.Paginater}}
        {{if gt .TotalPages 1}}
                <div class="center page buttons">
                        <div class="ui borderless pagination menu">
-                               <a class="{{if .IsFirst}}disabled{{end}} item navigation" {{if not .IsFirst}}href="{{$.Link}}{{if $paginationLink}}?{{$paginationLink}}{{end}}"{{end}}>
+                               <a class="{{if .IsFirst}}disabled{{end}} item navigation" {{if not .IsFirst}}href="{{$paginationLink}}{{if $paginationParams}}?{{$paginationParams}}{{end}}"{{end}}>
                                        {{svg "gitea-double-chevron-left" 16 "gt-mr-2"}}
                                        <span class="navigation_label">{{ctx.Locale.Tr "admin.first_page"}}</span>
                                </a>
-                               <a class="{{if not .HasPrevious}}disabled{{end}} item navigation" {{if .HasPrevious}}href="{{$.Link}}?page={{.Previous}}{{if $paginationLink}}&{{$paginationLink}}{{end}}"{{end}}>
+                               <a class="{{if not .HasPrevious}}disabled{{end}} item navigation" {{if .HasPrevious}}href="{{$paginationLink}}?page={{.Previous}}{{if $paginationParams}}&{{$paginationParams}}{{end}}"{{end}}>
                                        {{svg "octicon-chevron-left" 16 "gt-mr-2"}}
                                        <span class="navigation_label">{{ctx.Locale.Tr "repo.issues.previous"}}</span>
                                </a>
@@ -15,14 +17,14 @@
                                        {{if eq .Num -1}}
                                                <a class="disabled item">...</a>
                                        {{else}}
-                                               <a class="{{if .IsCurrent}}active {{end}}item gt-content-center" {{if not .IsCurrent}}href="{{$.Link}}?page={{.Num}}{{if $paginationLink}}&{{$paginationLink}}{{end}}"{{end}}>{{.Num}}</a>
+                                               <a class="{{if .IsCurrent}}active {{end}}item gt-content-center" {{if not .IsCurrent}}href="{{$paginationLink}}?page={{.Num}}{{if $paginationParams}}&{{$paginationParams}}{{end}}"{{end}}>{{.Num}}</a>
                                        {{end}}
                                {{end}}
-                               <a class="{{if not .HasNext}}disabled{{end}} item navigation" {{if .HasNext}}href="{{$.Link}}?page={{.Next}}{{if $paginationLink}}&{{$paginationLink}}{{end}}"{{end}}>
+                               <a class="{{if not .HasNext}}disabled{{end}} item navigation" {{if .HasNext}}href="{{$paginationLink}}?page={{.Next}}{{if $paginationParams}}&{{$paginationParams}}{{end}}"{{end}}>
                                        <span class="navigation_label">{{ctx.Locale.Tr "repo.issues.next"}}</span>
                                        {{svg "octicon-chevron-right" 16 "gt-ml-2"}}
                                </a>
-                               <a class="{{if .IsLast}}disabled{{end}} item navigation" {{if not .IsLast}}href="{{$.Link}}?page={{.TotalPages}}{{if $paginationLink}}&{{$paginationLink}}{{end}}"{{end}}>
+                               <a class="{{if .IsLast}}disabled{{end}} item navigation" {{if not .IsLast}}href="{{$paginationLink}}?page={{.TotalPages}}{{if $paginationParams}}&{{$paginationParams}}{{end}}"{{end}}>
                                        <span class="navigation_label">{{ctx.Locale.Tr "admin.last_page"}}</span>
                                        {{svg "gitea-double-chevron-right" 16 "gt-ml-2"}}
                                </a>