Remove unused properties in ShareesAPIController

Signed-off-by: Julius Härtl <jus@bitgrid.net>

diff --git a/apps/files_sharing/lib/Controller/ShareesAPIController.php b/apps/files_sharing/lib/Controller/ShareesAPIController.php
index 61678e67c174c7bd633b54d93b99e2ba61f382d0..14ed90411498d8dba6d745ba626ddd4655816e3b 100644 (file)
--- a/apps/files_sharing/lib/Controller/ShareesAPIController.php
+++ b/apps/files_sharing/lib/Controller/ShareesAPIController.php
@@ -66,12 +66,6 @@ class ShareesAPIController extends OCSController {
        /** @var IManager */
        protected $shareManager;
 
-       /** @var bool */
-       protected $shareWithGroupOnly = false;
-
-       /** @var bool */
-       protected $shareeEnumeration = true;
-
        /** @var int */
        protected $offset = 0;
 
@@ -205,8 +199,6 @@ class ShareesAPIController extends OCSController {
                }
                sort($shareTypes);
 
-               $this->shareWithGroupOnly = $this->config->getAppValue('core', 'shareapi_only_share_with_group_members', 'no') === 'yes';
-               $this->shareeEnumeration = $this->config->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'yes') === 'yes';
                $this->limit = (int) $perPage;
                $this->offset = $perPage * ($page - 1);
 

diff --git a/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php b/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php
index 1fb14ad9b8f1b2075b569fbea788d09d599c900d..68c827dd922e3d8d36b0d89579116e7802bb2ca2 100644 (file)
--- a/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php
+++ b/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php
@@ -237,12 +237,10 @@ class ShareesAPIControllerTest extends TestCase {
 
                /** @var IConfig|\PHPUnit_Framework_MockObject_MockObject $config */
                $config = $this->createMock(IConfig::class);
-               $config->expects($this->exactly(3))
+               $config->expects($this->exactly(1))
                        ->method('getAppValue')
                        ->with($this->anything(), $this->anything(), $this->anything())
                        ->willReturnMap([
-                               ['core', 'shareapi_only_share_with_group_members', 'no', $apiSetting],
-                               ['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', $enumSetting],
                                ['files_sharing', 'lookupServerEnabled', 'yes', 'yes'],
                        ]);
 
@@ -302,9 +300,6 @@ class ShareesAPIControllerTest extends TestCase {
                        }));
 
                $this->assertInstanceOf(Http\DataResponse::class, $sharees->search($search, $itemType, $page, $perPage, $shareType));
-
-               $this->assertSame($shareWithGroupOnly, $this->invokePrivate($sharees, 'shareWithGroupOnly'));
-               $this->assertSame($shareeEnumeration, $this->invokePrivate($sharees, 'shareeEnumeration'));
        }
 
        public function dataSearchInvalid() {