]> source.dussan.org Git - jgit.git/commitdiff
FileResolverTest#testNotAGitRepository: Fail when exception is not thrown 80/130180/2
authorDavid Pursehouse <david.pursehouse@gmail.com>
Sat, 29 Sep 2018 03:45:20 +0000 (12:45 +0900)
committerDavid Pursehouse <david.pursehouse@gmail.com>
Sat, 29 Sep 2018 03:47:01 +0000 (12:47 +0900)
Error Prone reports:

  Not calling fail() when expecting an exception masks bugs

See https://errorprone.info/bugpattern/MissingFail

Change-Id: I9ac844aa6c5a620d9b5d21d2e242347b3788b96a
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/FileResolverTest.java

index 82e79b8e50848e43930a3869e8f56e28622105dc..553c340a7373614dd0b6b07900b5ad1976297674 100644 (file)
@@ -147,6 +147,7 @@ public class FileResolverTest extends LocalDiskRepositoryTestCase {
 
                try {
                        resolver.open(null, name);
+                       fail("opened non-git repository");
                } catch (RepositoryNotFoundException e) {
                        assertEquals("repository not found: " + name, e.getMessage());