Fix repository browser does not show \"+\" (plus sign) in filename (#37718).

Patch by Go MAEDA.

git-svn-id: https://svn.redmine.org/redmine/trunk@21880 e93f8b46-1217-0410-a6f0-8f06a7374b81

diff --git a/lib/redmine/scm/adapters/subversion_adapter.rb b/lib/redmine/scm/adapters/subversion_adapter.rb
index c3748cadf48081a66811a98de769098968c2dfc8..4f213ccdb47528cbf86357ba4674ba2074998284 100644 (file)
--- a/lib/redmine/scm/adapters/subversion_adapter.rb
+++ b/lib/redmine/scm/adapters/subversion_adapter.rb
@@ -115,7 +115,7 @@ module Redmine
                 entries <<
                   Entry.new(
                     {
-                      :name => CGI.unescape(name),
+                      :name => Addressable::URI.unescape(name),
                       :path => ((path.empty? ? "" : "#{path}/") + name),
                       :kind => entry['kind'],
                       :size => ((s = entry['size']) ? s['__content__'].to_i : nil),

diff --git a/test/fixtures/repositories/subversion_repository.dump.gz b/test/fixtures/repositories/subversion_repository.dump.gz
index 0151f83e1163002566430ea73a0b7867bb86ee7b..f0a1e1d2a2aa81dcbad03b45a1ec6209a4d525e3 100644 (file)
Binary files a/test/fixtures/repositories/subversion_repository.dump.gz and b/test/fixtures/repositories/subversion_repository.dump.gz differ

diff --git a/test/functional/repositories_subversion_controller_test.rb b/test/functional/repositories_subversion_controller_test.rb
index ca2a224a872b8f717594f534e5a38156b8cdfddd..807c8d03f1aa909c0f5afe8042ce1d1a5a443a82 100644 (file)
--- a/test/functional/repositories_subversion_controller_test.rb
+++ b/test/functional/repositories_subversion_controller_test.rb
@@ -27,7 +27,7 @@ class RepositoriesSubversionControllerTest < Redmine::RepositoryControllerTest
            :issue_categories, :enumerations, :custom_fields, :custom_values, :trackers
 
   PRJ_ID = 3
-  NUM_REV = 13
+  NUM_REV = 14
 
   def setup
     super
@@ -121,9 +121,10 @@ class RepositoriesSubversionControllerTest < Redmine::RepositoryControllerTest
       assert_response :success
 
       assert_select 'table.entries tbody' do
-        assert_select 'tr', 5
+        assert_select 'tr', 6
         assert_select 'tr.dir td.filename a', :text => '[folder_with_brackets]'
         assert_select 'tr.dir td.filename a', :text => 'folder'
+        assert_select 'tr.file td.filename a', :text => '+.md'
         assert_select 'tr.file td.filename a', :text => '.project'
         assert_select 'tr.file td.filename a', :text => 'helloworld.c'
         assert_select 'tr.file td.filename a', :text => 'textfile.txt'

diff --git a/test/unit/repository_subversion_test.rb b/test/unit/repository_subversion_test.rb
index 4ee5383bd44ac8d8d9ecd0ed5cfee3f42df2a38d..90ce785a240cc15edaf81752ca4f814d29ffd916 100644 (file)
--- a/test/unit/repository_subversion_test.rb
+++ b/test/unit/repository_subversion_test.rb
@@ -24,7 +24,7 @@ class RepositorySubversionTest < ActiveSupport::TestCase
 
   include Redmine::I18n
 
-  NUM_REV = 13
+  NUM_REV = 14
 
   def setup
     User.current = nil
@@ -100,7 +100,7 @@ class RepositorySubversionTest < ActiveSupport::TestCase
       @project.reload
 
       assert_equal NUM_REV, @repository.changesets.count
-      assert_equal 23, @repository.filechanges.count
+      assert_equal 24, @repository.filechanges.count
       assert_equal 'Initial import.', @repository.changesets.find_by_revision('1').comments
     end