Do not validate blank default custom field value.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8722 e93f8b46-1217-0410-a6f0-8f06a7374b81

diff --git a/app/models/custom_field.rb b/app/models/custom_field.rb
index f56eb3623338c4a23e7b711a67a2ccd022c220aa..b8005fea1278958c7a94bba5021947b224378fdf 100644 (file)
--- a/app/models/custom_field.rb
+++ b/app/models/custom_field.rb
@@ -57,7 +57,7 @@ class CustomField < ActiveRecord::Base
       end
     end
 
-    unless valid_field_value?(default_value)
+    if default_value.present? && !valid_field_value?(default_value)
       errors.add(:default_value, :invalid)
     end
   end

diff --git a/test/unit/custom_field_test.rb b/test/unit/custom_field_test.rb
index 6cef44ea999cea6d88eaae90a7647140f760a200..db7a637fde047a10bd8f31e601f7d79089ed7f51 100644 (file)
--- a/test/unit/custom_field_test.rb
+++ b/test/unit/custom_field_test.rb
@@ -52,6 +52,11 @@ class CustomFieldTest < ActiveSupport::TestCase
     assert field.valid?
   end
 
+  def test_default_value_should_not_be_validated_when_blank
+    field = CustomField.new(:name => 'Test', :field_format => 'list', :possible_values => ['a', 'b'], :is_required => true, :default_value => '')
+    assert field.valid?
+  end
+
   def test_possible_values_should_accept_an_array
     field = CustomField.new
     field.possible_values = ["One value", ""]