Wrap metadata generation in try/catch

Signed-off-by: Louis Chemineau <louis@chmn.me>

diff --git a/core/BackgroundJobs/GenerateMetadataJob.php b/core/BackgroundJobs/GenerateMetadataJob.php
index f0dfdb8de2210895c9103744638ea51a3eb31770..393545b097d0acf547c7324a3d44600e36bd190f 100644 (file)
--- a/core/BackgroundJobs/GenerateMetadataJob.php
+++ b/core/BackgroundJobs/GenerateMetadataJob.php
@@ -33,6 +33,7 @@ use OCP\Files\IRootFolder;
 use OCP\FilesMetadata\IFilesMetadataManager;
 use OCP\IConfig;
 use OCP\IUserManager;
+use Psr\Log\LoggerInterface;
 
 class GenerateMetadataJob extends TimedJob {
        public function __construct(
@@ -42,6 +43,7 @@ class GenerateMetadataJob extends TimedJob {
                private IUserManager $userManager,
                private IFilesMetadataManager $filesMetadataManager,
                private IJobList $jobList,
+               private LoggerInterface $logger,
        ) {
                parent::__construct($time);
 
@@ -102,10 +104,14 @@ class GenerateMetadataJob extends TimedJob {
                                continue;
                        }
 
-                       $this->filesMetadataManager->refreshMetadata(
-                               $node,
-                               IFilesMetadataManager::PROCESS_LIVE | IFilesMetadataManager::PROCESS_BACKGROUND
-                       );
+                       try {
+                               $this->filesMetadataManager->refreshMetadata(
+                                       $node,
+                                       IFilesMetadataManager::PROCESS_LIVE | IFilesMetadataManager::PROCESS_BACKGROUND
+                               );
+                       } catch (\Throwable $ex) {
+                               $this->logger->warning("Error while generating metadata for fileid ".$node->getId(), ['exception' => $ex]);
+                       }
                }
        }
 }