add missing places and address review.

Signed-off-by: Simon L <szaimen@e.mail.de>

diff --git a/apps/theming/css/default.css b/apps/theming/css/default.css
index e4f0652472da293bf4a110fabd2eb964f061a61e..edcc8f93de2387639b8f0291c6244e45099ab883 100644 (file)
--- a/apps/theming/css/default.css
+++ b/apps/theming/css/default.css
@@ -40,7 +40,7 @@
   --color-border: #ededed;
   --color-border-dark: #dbdbdb;
   --color-border-maxcontrast: #949494;
-  --font-face: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen-Sans, Cantarell, Ubuntu, 'Helvetica Neue', Arial, sans-serif, 'Noto Color Emoji', 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol';
+  --font-face:  system-ui, -apple-system, "Segoe UI", Roboto, Oxygen-Sans, Cantarell, Ubuntu, "Helvetica Neue", "Noto Sans", "Liberation Sans", Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";
   --default-font-size: 15px;
   --animation-quick: 100ms;
   --animation-slow: 300ms;

diff --git a/apps/theming/lib/Themes/DefaultTheme.php b/apps/theming/lib/Themes/DefaultTheme.php
index bae914c3c9ca2ee5da510af2f855dc4488846fbc..6c3e6d5fbb962a12450c553f2e48216e49b1dec9 100644 (file)
--- a/apps/theming/lib/Themes/DefaultTheme.php
+++ b/apps/theming/lib/Themes/DefaultTheme.php
@@ -171,7 +171,7 @@ class DefaultTheme implements ITheme {
                        '--color-border-dark' => $this->util->darken($colorMainBackground, 14),
                        '--color-border-maxcontrast' => $this->util->darken($colorMainBackground, 42),
 
-                       '--font-face' => "system-ui, -apple-system, 'Segoe UI', Roboto, 'Helvetica Neue', 'Noto Sans', 'Liberation Sans', Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji';",
+                       '--font-face' => "system-ui, -apple-system, 'Segoe UI', Roboto, Oxygen-Sans, Cantarell, Ubuntu, 'Helvetica Neue', 'Noto Sans', 'Liberation Sans', Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji';",
                        '--default-font-size' => '15px',
 
                        // TODO: support "(prefers-reduced-motion)"

diff --git a/core/css/guest.scss b/core/css/guest.scss
index e845e448a4fa19ce42acd9c0df092d56ed38873e..50a3960ead9bb77247cb0892cde4f259f3e0678b 100644 (file)
--- a/core/css/guest.scss
+++ b/core/css/guest.scss
@@ -24,7 +24,7 @@ body {
        /* bring the default font size up to 14px */
        font-size: .875em;
        line-height: 1.6em;
-       font-family: system-ui, -apple-system, "Segoe UI", Roboto, "Helvetica Neue", "Noto Sans", "Liberation Sans", Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";
+       font-family: system-ui, -apple-system, "Segoe UI", Roboto, Oxygen-Sans, Cantarell, Ubuntu, "Helvetica Neue", "Noto Sans", "Liberation Sans", Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";
        color: var(--color-text);
        text-align: center;
        /* As guest, there is no color-background-plain */
@@ -214,7 +214,7 @@ form #datadirField legend {
 
 
 input, textarea, select, button, div[contenteditable=true] {
-       font-family: system-ui, -apple-system, "Segoe UI", Roboto, "Helvetica Neue", "Noto Sans", "Liberation Sans", Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";
+       font-family: system-ui, -apple-system, "Segoe UI", Roboto, Oxygen-Sans, Cantarell, Ubuntu, "Helvetica Neue", "Noto Sans", "Liberation Sans", Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";
 }
 input,
 input:not([type='range']),

diff --git a/core/css/variables.scss b/core/css/variables.scss
index 164a69a685744ba1d0e229c4384cb937bc9a9eb8..625ba011322bfe8cc802ae614ba9e18e606f91ce 100644 (file)
--- a/core/css/variables.scss
+++ b/core/css/variables.scss
@@ -95,7 +95,7 @@ $border-radius-large: 10px !default;
 // Pill-style button, value is large so big buttons also have correct roundness
 $border-radius-pill: 100px !default;
 
-$font-face: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen-Sans, Cantarell, Ubuntu, 'Helvetica Neue', Arial, sans-serif, 'Noto Color Emoji', 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol' !default;
+$font-face: system-ui, -apple-system, "Segoe UI", Roboto, Oxygen-Sans, Cantarell, Ubuntu, "Helvetica Neue", "Noto Sans", "Liberation Sans", Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji" !default;
 $default-font-size: 15px;
 
 $default-line-height: 24px;