Fix issues list page multiple selection update milestones (#24660) (#24663)

Backport #24660 by @lunny

Fix #24651

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

diff --git a/templates/repo/issue/list.tmpl b/templates/repo/issue/list.tmpl
index a59480109330b842c0eb5d8c1c3dc9292ef9ffb2..c07333f1479d0b0041e566d539ef602117dcc3db 100644 (file)
--- a/templates/repo/issue/list.tmpl
+++ b/templates/repo/issue/list.tmpl
@@ -257,7 +257,7 @@
                                        </div>
 
                                        <!-- Milestone -->
-                                       <div class="ui {{if not .Milestones}}disabled{{end}} dropdown jump item">
+                                       <div class="ui {{if not (or .OpenMilestones .ClosedMilestones)}}disabled{{end}} dropdown jump item">
                                                <span class="text">
                                                        {{.locale.Tr "repo.issues.action_milestone"}}
                                                        {{svg "octicon-triangle-down" 14 "dropdown icon"}}
@@ -266,10 +266,23 @@
                                                        <div class="item issue-action" data-element-id="0" data-url="{{$.Link}}/milestone">
                                                        {{.locale.Tr "repo.issues.action_milestone_no_select"}}
                                                        </div>
-                                                       {{range .Milestones}}
-                                                               <div class="item issue-action" data-element-id="{{.ID}}" data-url="{{$.RepoLink}}/issues/milestone">
-                                                                       {{.Name}}
-                                                               </div>
+                                                       {{if .OpenMilestones}}
+                                                               <div class="divider"></div>
+                                                               <div class="header">{{.locale.Tr "repo.issues.filter_milestone_open"}}</div>
+                                                               {{range .OpenMilestones}}
+                                                                       <div class="item issue-action" data-element-id="{{.ID}}" data-url="{{$.RepoLink}}/issues/milestone">
+                                                                               {{.Name}}
+                                                                       </div>
+                                                               {{end}}
+                                                       {{end}}
+                                                       {{if .ClosedMilestones}}
+                                                               <div class="divider"></div>
+                                                               <div class="header">{{.locale.Tr "repo.issues.filter_milestone_open"}}</div>
+                                                               {{range .ClosedMilestones}}
+                                                                       <div class="item issue-action" data-element-id="{{.ID}}" data-url="{{$.RepoLink}}/issues/milestone">
+                                                                               {{.Name}}
+                                                                       </div>
+                                                               {{end}}
                                                        {{end}}
                                                </div>
                                        </div>