TableSortIndicatorTest fix (#12469) (#12472)

Stabilize the tests by ensuring that the loading indicator is no longer
present when the screenshot comparison is done.

diff --git a/uitest/reference-screenshots/chrome/TableSortIndicatorTest-ascendingIndicatorIsShown_ANY_Chrome__ascending.png b/uitest/reference-screenshots/chrome/TableSortIndicatorTest-ascendingIndicatorIsShown_ANY_Chrome__ascending.png
index 58669454a1a174b38063d45262852e8c8420aa7b..dda7458004e5e9c771787c40c2c64a50ab4ff18d 100755 (executable)
Binary files a/uitest/reference-screenshots/chrome/TableSortIndicatorTest-ascendingIndicatorIsShown_ANY_Chrome__ascending.png and b/uitest/reference-screenshots/chrome/TableSortIndicatorTest-ascendingIndicatorIsShown_ANY_Chrome__ascending.png differ

diff --git a/uitest/reference-screenshots/chrome/TableSortIndicatorTest-descendingIndicatorIsShown_ANY_Chrome__descending.png b/uitest/reference-screenshots/chrome/TableSortIndicatorTest-descendingIndicatorIsShown_ANY_Chrome__descending.png
index 0b6205d44923be54eb89e138eaff75cc78150399..c07c3ea7d5590bfcf31a41a45a30a4b380b26997 100755 (executable)
Binary files a/uitest/reference-screenshots/chrome/TableSortIndicatorTest-descendingIndicatorIsShown_ANY_Chrome__descending.png and b/uitest/reference-screenshots/chrome/TableSortIndicatorTest-descendingIndicatorIsShown_ANY_Chrome__descending.png differ

diff --git a/uitest/src/test/java/com/vaadin/tests/themes/valo/TableSortIndicatorTest.java b/uitest/src/test/java/com/vaadin/tests/themes/valo/TableSortIndicatorTest.java
index 9fe927e84c7b349ecf1f9145778a99af401d1ef0..e05a69fb0b59ebf49ca4bffc5a41878d3501211a 100644 (file)
--- a/uitest/src/test/java/com/vaadin/tests/themes/valo/TableSortIndicatorTest.java
+++ b/uitest/src/test/java/com/vaadin/tests/themes/valo/TableSortIndicatorTest.java
@@ -21,6 +21,7 @@ public class TableSortIndicatorTest extends MultiBrowserTest {
 
         clickOnCellHeader();
 
+        waitUntilLoadingIndicatorNotVisible();
         compareScreen("ascending");
     }
 
@@ -32,6 +33,7 @@ public class TableSortIndicatorTest extends MultiBrowserTest {
         clickOnCellHeader();
         clickOnSortIndicator();
 
+        waitUntilLoadingIndicatorNotVisible();
         compareScreen("descending");
     }