]> source.dussan.org Git - gitea.git/commitdiff
LFS: Fix SSH authentication for trailing arguments (#1328)
authorFabian Zaremba <fabian@youremail.eu>
Wed, 22 Mar 2017 10:43:28 +0000 (11:43 +0100)
committerLunny Xiao <xiaolunwen@gmail.com>
Wed, 22 Mar 2017 10:43:28 +0000 (18:43 +0800)
Fixes #1296

cmd/serv.go

index d9d32217c82d715167dcc1adfebc030188592dea..dc8952abe90a412878560085f6607737bdbf761f 100644 (file)
@@ -123,8 +123,8 @@ func runServ(c *cli.Context) error {
                        fail("Unknown git command", "LFS authentication request over SSH denied, LFS support is disabled")
                }
 
-               if strings.Contains(args, " ") {
-                       argsSplit := strings.SplitN(args, " ", 2)
+               argsSplit := strings.Split(args, " ")
+               if len(argsSplit) >= 2 {
                        args = strings.TrimSpace(argsSplit[0])
                        lfsVerb = strings.TrimSpace(argsSplit[1])
                }
@@ -179,8 +179,10 @@ func runServ(c *cli.Context) error {
        if verb == lfsAuthenticateVerb {
                if lfsVerb == "upload" {
                        requestedMode = models.AccessModeWrite
-               } else {
+               } else if lfsVerb == "download" {
                        requestedMode = models.AccessModeRead
+               } else {
+                       fail("Unknown LFS verb", "Unkown lfs verb %s", lfsVerb)
                }
        }