fix apps/bookmarks if oc_bookmarks_tags is empty

If you have bookmarks, but there are no tags in oc_bookmarks_tags, the
query doesn't return any results. Using a left join fixes this.

Reference:
http://stackoverflow.com/questions/3171276/select-multiple-tables-when-one-table-is-empty-in-mysql

Signed-off-by: Florian Pritz <bluewind@xinu.at>

diff --git a/apps/bookmarks/ajax/updateList.php b/apps/bookmarks/ajax/updateList.php
index 67acb2190ca96bbdefa1baebfdd7606063dfdfd0..e9051a8dbfa32ffd5ee5dac725afdb47954207b5 100644 (file)
--- a/apps/bookmarks/ajax/updateList.php
+++ b/apps/bookmarks/ajax/updateList.php
@@ -70,7 +70,8 @@ $query = OC_DB::prepare('
                        ELSE \' \'
                END
                AS tags
-       FROM *PREFIX*bookmarks, *PREFIX*bookmarks_tags 
+       FROM *PREFIX*bookmarks
+       LEFT JOIN *PREFIX*bookmarks_tags ON 1=1
        WHERE (*PREFIX*bookmarks.id = *PREFIX*bookmarks_tags.bookmark_id 
                        OR *PREFIX*bookmarks.id NOT IN (
                                SELECT *PREFIX*bookmarks_tags.bookmark_id FROM *PREFIX*bookmarks_tags