]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-10656 Fix {instance} messages in onboarding page
authorGrégoire Aubert <gregoire.aubert@sonarsource.com>
Thu, 7 Jun 2018 09:21:31 +0000 (11:21 +0200)
committerSonarTech <sonartech@sonarsource.com>
Fri, 8 Jun 2018 18:20:51 +0000 (20:20 +0200)
server/sonar-web/src/main/js/apps/tutorials/onboarding/commands/ClangGCC.js
server/sonar-web/src/main/js/apps/tutorials/onboarding/commands/DotNet.js
server/sonar-web/src/main/js/apps/tutorials/onboarding/commands/Msvc.js
server/sonar-web/src/main/js/apps/tutorials/onboarding/commands/Other.js
server/sonar-web/src/main/js/apps/tutorials/onboarding/commands/__tests__/__snapshots__/ClangGCC-test.js.snap
server/sonar-web/src/main/js/apps/tutorials/onboarding/commands/__tests__/__snapshots__/DotNet-test.js.snap
server/sonar-web/src/main/js/apps/tutorials/onboarding/commands/__tests__/__snapshots__/Msvc-test.js.snap
server/sonar-web/src/main/js/apps/tutorials/onboarding/commands/__tests__/__snapshots__/Other-test.js.snap

index 26d3596d2e967bfff6b825a051e0729eff7fd70d..0c1fdab16cfe0ad3f058fba058dc2f6b5c8f46e3 100644 (file)
@@ -22,6 +22,7 @@ import React from 'react';
 import SQScanner from './SQScanner';
 import BuildWrapper from './BuildWrapper';
 import CodeSnippet from '../../../../components/common/CodeSnippet';
+import InstanceMessage from '../../../../components/common/InstanceMessage';
 import { translate } from '../../../../helpers/l10n';
 
 /*::
@@ -61,12 +62,14 @@ export default function ClangGCC(props /*: Props */) {
       <h4 className="huge-spacer-top spacer-bottom">
         {translate('onboarding.analysis.sq_scanner.execute')}
       </h4>
-      <p
-        className="spacer-bottom markdown"
-        dangerouslySetInnerHTML={{
-          __html: translate('onboarding.analysis.sq_scanner.execute.text')
-        }}
-      />
+      <InstanceMessage message={translate('onboarding.analysis.sq_scanner.execute.text')}>
+        {transformedMessage => (
+          <p
+            className="spacer-bottom markdown"
+            dangerouslySetInnerHTML={{ __html: transformedMessage }}
+          />
+        )}
+      </InstanceMessage>
       <CodeSnippet isOneLine={true} snippet={command1} />
       <CodeSnippet isOneLine={props.os === 'win'} snippet={command2} />
       <p
index 7e5fd4f24e0d77bc18ab9696022577014b6d32fd..a5bd3fd428568548be8baf32a08d22fe95d626da 100644 (file)
@@ -21,6 +21,7 @@
 import React from 'react';
 import MSBuildScanner from './MSBuildScanner';
 import CodeSnippet from '../../../../components/common/CodeSnippet';
+import InstanceMessage from '../../../../components/common/InstanceMessage';
 import { translate } from '../../../../helpers/l10n';
 
 /*::
@@ -52,12 +53,14 @@ export default function DotNet(props /*: Props */) {
       <h4 className="huge-spacer-top spacer-bottom">
         {translate('onboarding.analysis.msbuild.execute')}
       </h4>
-      <p
-        className="spacer-bottom markdown"
-        dangerouslySetInnerHTML={{
-          __html: translate('onboarding.analysis.msbuild.execute.text')
-        }}
-      />
+      <InstanceMessage message={translate('onboarding.analysis.msbuild.execute.text')}>
+        {transformedMessage => (
+          <p
+            className="spacer-bottom markdown"
+            dangerouslySetInnerHTML={{ __html: transformedMessage }}
+          />
+        )}
+      </InstanceMessage>
       <CodeSnippet isOneLine={true} snippet={command1} />
       <CodeSnippet isOneLine={true} snippet={command2} />
       <CodeSnippet isOneLine={true} snippet={command3} />
index 756c2daea3131c5496240372e6b3be842adebdb2..03f5fe3eb6377a4a9088f254f841d7a96eb819bb 100644 (file)
@@ -22,6 +22,7 @@ import React from 'react';
 import MSBuildScanner from './MSBuildScanner';
 import BuildWrapper from './BuildWrapper';
 import CodeSnippet from '../../../../components/common/CodeSnippet';
+import InstanceMessage from '../../../../components/common/InstanceMessage';
 import { translate } from '../../../../helpers/l10n';
 
 /*::
@@ -55,12 +56,14 @@ export default function Msvc(props /*: Props */) {
       <h4 className="huge-spacer-top spacer-bottom">
         {translate('onboarding.analysis.msbuild.execute')}
       </h4>
-      <p
-        className="spacer-bottom markdown"
-        dangerouslySetInnerHTML={{
-          __html: translate('onboarding.analysis.msbuild.execute.text')
-        }}
-      />
+      <InstanceMessage message={translate('onboarding.analysis.msbuild.execute.text')}>
+        {transformedMessage => (
+          <p
+            className="spacer-bottom markdown"
+            dangerouslySetInnerHTML={{ __html: transformedMessage }}
+          />
+        )}
+      </InstanceMessage>
       <CodeSnippet isOneLine={true} snippet={command1} />
       <CodeSnippet isOneLine={true} snippet={command2} />
       <CodeSnippet isOneLine={true} snippet={command3} />
index 47be65b1952418748671b94a389251150c92cc76..5bb0d0dd6496c4f9af5e33e7dce92bc2baa9c7ba 100644 (file)
@@ -21,6 +21,7 @@
 import React from 'react';
 import SQScanner from './SQScanner';
 import CodeSnippet from '../../../../components/common/CodeSnippet';
+import InstanceMessage from '../../../../components/common/InstanceMessage';
 import { translate } from '../../../../helpers/l10n';
 
 /*::
@@ -50,12 +51,14 @@ export default function Other(props /*: Props */) {
       <h4 className="huge-spacer-top spacer-bottom">
         {translate('onboarding.analysis.sq_scanner.execute')}
       </h4>
-      <p
-        className="spacer-bottom markdown"
-        dangerouslySetInnerHTML={{
-          __html: translate('onboarding.analysis.sq_scanner.execute.text')
-        }}
-      />
+      <InstanceMessage message={translate('onboarding.analysis.sq_scanner.execute.text')}>
+        {transformedMessage => (
+          <p
+            className="spacer-bottom markdown"
+            dangerouslySetInnerHTML={{ __html: transformedMessage }}
+          />
+        )}
+      </InstanceMessage>
       <CodeSnippet isOneLine={props.os === 'win'} snippet={command} />
       <p
         className="big-spacer-top markdown"
index 4375df814f3b89e254f45caf32cb1753d8e50a81..cdffd4c2061ce95be6225eaa48830a7586f922e0 100644 (file)
@@ -14,13 +14,8 @@ exports[`renders correctly 1`] = `
   >
     onboarding.analysis.sq_scanner.execute
   </h4>
-  <p
-    className="spacer-bottom markdown"
-    dangerouslySetInnerHTML={
-      Object {
-        "__html": "onboarding.analysis.sq_scanner.execute.text",
-      }
-    }
+  <InstanceMessage
+    message="onboarding.analysis.sq_scanner.execute.text"
   />
   <CodeSnippet
     isOneLine={true}
@@ -65,13 +60,8 @@ exports[`renders correctly 2`] = `
   >
     onboarding.analysis.sq_scanner.execute
   </h4>
-  <p
-    className="spacer-bottom markdown"
-    dangerouslySetInnerHTML={
-      Object {
-        "__html": "onboarding.analysis.sq_scanner.execute.text",
-      }
-    }
+  <InstanceMessage
+    message="onboarding.analysis.sq_scanner.execute.text"
   />
   <CodeSnippet
     isOneLine={true}
@@ -116,13 +106,8 @@ exports[`renders correctly 3`] = `
   >
     onboarding.analysis.sq_scanner.execute
   </h4>
-  <p
-    className="spacer-bottom markdown"
-    dangerouslySetInnerHTML={
-      Object {
-        "__html": "onboarding.analysis.sq_scanner.execute.text",
-      }
-    }
+  <InstanceMessage
+    message="onboarding.analysis.sq_scanner.execute.text"
   />
   <CodeSnippet
     isOneLine={true}
index e21df31e564e0129d9eafead4afd96f56433f8ba..89b57fa28b4c1c7fc951be70a4a0ce708cfd32fc 100644 (file)
@@ -8,13 +8,8 @@ exports[`renders correctly 1`] = `
   >
     onboarding.analysis.msbuild.execute
   </h4>
-  <p
-    className="spacer-bottom markdown"
-    dangerouslySetInnerHTML={
-      Object {
-        "__html": "onboarding.analysis.msbuild.execute.text",
-      }
-    }
+  <InstanceMessage
+    message="onboarding.analysis.msbuild.execute.text"
   />
   <CodeSnippet
     isOneLine={true}
@@ -60,13 +55,8 @@ exports[`renders correctly 2`] = `
   >
     onboarding.analysis.msbuild.execute
   </h4>
-  <p
-    className="spacer-bottom markdown"
-    dangerouslySetInnerHTML={
-      Object {
-        "__html": "onboarding.analysis.msbuild.execute.text",
-      }
-    }
+  <InstanceMessage
+    message="onboarding.analysis.msbuild.execute.text"
   />
   <CodeSnippet
     isOneLine={true}
index a5e4f91b4e306aae5dd961636f023484c50c973e..2240a13995c175934118070808f59ba2098f17cc 100644 (file)
@@ -12,13 +12,8 @@ exports[`renders correctly 1`] = `
   >
     onboarding.analysis.msbuild.execute
   </h4>
-  <p
-    className="spacer-bottom markdown"
-    dangerouslySetInnerHTML={
-      Object {
-        "__html": "onboarding.analysis.msbuild.execute.text",
-      }
-    }
+  <InstanceMessage
+    message="onboarding.analysis.msbuild.execute.text"
   />
   <CodeSnippet
     isOneLine={true}
@@ -69,13 +64,8 @@ exports[`renders correctly 2`] = `
   >
     onboarding.analysis.msbuild.execute
   </h4>
-  <p
-    className="spacer-bottom markdown"
-    dangerouslySetInnerHTML={
-      Object {
-        "__html": "onboarding.analysis.msbuild.execute.text",
-      }
-    }
+  <InstanceMessage
+    message="onboarding.analysis.msbuild.execute.text"
   />
   <CodeSnippet
     isOneLine={true}
index 7c7ae719489ff1b000bb81e1d7bc37155816cbfe..73aba357dcaeca097e046691ec35eb954263e90a 100644 (file)
@@ -10,13 +10,8 @@ exports[`renders correctly 1`] = `
   >
     onboarding.analysis.sq_scanner.execute
   </h4>
-  <p
-    className="spacer-bottom markdown"
-    dangerouslySetInnerHTML={
-      Object {
-        "__html": "onboarding.analysis.sq_scanner.execute.text",
-      }
-    }
+  <InstanceMessage
+    message="onboarding.analysis.sq_scanner.execute.text"
   />
   <CodeSnippet
     isOneLine={true}
@@ -52,13 +47,8 @@ exports[`renders correctly 2`] = `
   >
     onboarding.analysis.sq_scanner.execute
   </h4>
-  <p
-    className="spacer-bottom markdown"
-    dangerouslySetInnerHTML={
-      Object {
-        "__html": "onboarding.analysis.sq_scanner.execute.text",
-      }
-    }
+  <InstanceMessage
+    message="onboarding.analysis.sq_scanner.execute.text"
   />
   <CodeSnippet
     isOneLine={false}
@@ -94,13 +84,8 @@ exports[`renders correctly 3`] = `
   >
     onboarding.analysis.sq_scanner.execute
   </h4>
-  <p
-    className="spacer-bottom markdown"
-    dangerouslySetInnerHTML={
-      Object {
-        "__html": "onboarding.analysis.sq_scanner.execute.text",
-      }
-    }
+  <InstanceMessage
+    message="onboarding.analysis.sq_scanner.execute.text"
   />
   <CodeSnippet
     isOneLine={false}