]> source.dussan.org Git - nextcloud-server.git/commitdiff
adjust unit test assert values
authorThomas Müller <thomas.mueller@tmit.eu>
Thu, 5 Jun 2014 18:33:52 +0000 (20:33 +0200)
committerRobin Appelman <icewind@owncloud.com>
Mon, 9 Jun 2014 10:44:40 +0000 (12:44 +0200)
apps/files_sharing/tests/permissions.php

index bff7109518581fdd38969679a7b96e09af0ca507..2cbc412d261ef36e7030cc7d68d83865bf59095f 100644 (file)
@@ -141,16 +141,14 @@ class Test_Files_Sharing_Permissions extends Test_Files_Sharing_Base {
                $this->assertEquals('subdir', $contents[0]['name']);
                $this->assertEquals(31, $contents[0]['permissions']);
                $this->assertEquals('textfile.txt', $contents[1]['name']);
-               $this->assertEquals(31, $contents[1]['permissions']);
+               // 27 is correct because create is reserved to folders only - requires more unit tests overall to ensure this
+               $this->assertEquals(27, $contents[1]['permissions']);
                $contents = $this->secondView->getDirectoryContent('files/shareddirrestricted');
                $this->assertEquals('subdir', $contents[0]['name']);
-               $this->assertEquals(7, $contents[0]['permissions']);
+               $this->assertEquals(7 | \OCP\PERMISSION_DELETE, $contents[0]['permissions']);
                $this->assertEquals('textfile1.txt', $contents[1]['name']);
-               $this->assertEquals(7, $contents[1]['permissions']);
-
-               // the share mount point should always have delete permissions to allow the user
-               // to unmount it
-               $restrictedShare = $this->secondView->getFileInfo('files/shareddirrestricted');
-               $this->assertEquals(7 | \OCP\PERMISSION_DELETE, $restrictedShare['permissions']);
+               // 3 is correct because create is reserved to folders only
+               // delete permissions are added since mount points can always be deleted
+               $this->assertEquals(3 | \OCP\PERMISSION_DELETE, $contents[1]['permissions']);
        }
 }