Fixed .val(String) for select elements (#1760) [Thanks Sam]

diff --git a/src/core.js b/src/core.js
index 9fd0168e62732522ace73ac5d0e276ad68cab031..b3b0a9d27ad64d0fe85992d05366607b081d3fcf 100644 (file)
--- a/src/core.js
+++ b/src/core.js
@@ -407,7 +407,7 @@ jQuery.fn = jQuery.prototype = {
                                                        jQuery.inArray( this.text, values ) >= 0);\r
                                        });\r
 \r
-                                       if ( !tmp.length )\r
+                                       if ( !values.length )\r
                                                this.selectedIndex = -1;\r
 \r
                                } else\r

diff --git a/test/unit/core.js b/test/unit/core.js
index 32ff83e8613a32c2dfba93fedff7d3481aa2dfd0..eee1740d6361d99c959eccbe1d3db98169772cb1 100644 (file)
--- a/test/unit/core.js
+++ b/test/unit/core.js
@@ -824,11 +824,14 @@ test("val()", function() {
 });
 
 test("val(String)", function() {
-       expect(2);
+       expect(3);
        document.getElementById('text1').value = "bla";
        ok( $("#text1").val() == "bla", "Check for modified value of input element" );
        $("#text1").val('test');
        ok ( document.getElementById('text1').value == "test", "Check for modified (via val(String)) value of input element" );
+       
+       $("#select1").val("3");
+       ok( $("#select1").val() == "3", "Check for modified (via val(String)) value of select element" );
 });
 
 test("html(String)", function() {