]> source.dussan.org Git - jquery-ui.git/commitdiff
Selectmenu: Copy title attributes
authorFelix Nagel <info@felixnagel.com>
Thu, 31 Jul 2014 10:35:42 +0000 (12:35 +0200)
committerScott González <scott.gonzalez@gmail.com>
Tue, 4 Nov 2014 13:40:15 +0000 (08:40 -0500)
Fixes #10435
Closes gh-1298

tests/unit/selectmenu/selectmenu_core.js
ui/selectmenu.js

index 2ee963043b829f11ebc17cdc5d04b6f18d784a13..b4efb80f2fbd95d63530e0154dd15e049988c951 100644 (file)
@@ -3,15 +3,21 @@
 module( "selectmenu: core" );
 
 asyncTest( "accessibility", function() {
-       var wrappers,
-               element = $( "#speed" ).selectmenu(),
-               button = element.selectmenu( "widget" ),
-               menu = element.selectmenu( "menuWidget" );
+       var wrappers, button, menu,
+               element = $( "#speed" ).attr( "title", "A demo title" );
+
+       element.find( "option" ).each(function( index ) {
+               $( this ).attr( "title", "A demo title #" + index );
+       });
+
+       element.selectmenu();
+       button = element.selectmenu( "widget" );
+       menu = element.selectmenu( "menuWidget" );
 
        button.simulate( "focus" );
        wrappers = menu.find( "li.ui-menu-item .ui-menu-item-wrapper" );
 
-       expect( 12 + wrappers.length * 2 );
+       expect( 13 + wrappers.length * 3 );
 
        setTimeout(function() {
                equal( button.attr( "role" ), "combobox", "button role" );
@@ -25,6 +31,7 @@ asyncTest( "accessibility", function() {
                        "button link aria-labelledby"
                );
                equal( button.attr( "tabindex" ), 0, "button link tabindex" );
+               equal( button.attr( "title" ), "A demo title", "button title" );
 
                equal( menu.attr( "role" ), "listbox", "menu role" );
                equal( menu.attr( "aria-labelledby" ), button.attr( "id" ), "menu aria-labelledby" );
@@ -36,9 +43,10 @@ asyncTest( "accessibility", function() {
                        "menu aria-activedescendant"
                );
                $.each( wrappers, function( index ) {
-                       var link = $( this );
-                       equal( link.attr( "role" ), "option", "menu link #" + index +" role" );
-                       equal( link.attr( "tabindex" ), -1, "menu link #" + index +" tabindex" );
+                       var item = $( this );
+                       equal( item.attr( "role" ), "option", "menu item #" + index +" role" );
+                       equal( item.attr( "tabindex" ), -1, "menu item #" + index +" tabindex" );
+                       equal( item.attr( "title" ), "A demo title #" + index, "menu item #" + index + " title" );
                });
                start();
        });
index a2409bde26e83dd1dffd1ce1b86813be690e0bd0..0859a2c2c1cec6518ffe1836bd8f159fb14303be 100644 (file)
@@ -94,7 +94,8 @@ return $.widget( "ui.selectmenu", {
                        "aria-expanded": "false",
                        "aria-autocomplete": "list",
                        "aria-owns": this.ids.menu,
-                       "aria-haspopup": "true"
+                       "aria-haspopup": "true",
+                       title: this.element.attr( "title" )
                })
                        .insertAfter( this.element );
 
@@ -317,7 +318,9 @@ return $.widget( "ui.selectmenu", {
 
        _renderItem: function( ul, item ) {
                var li = $( "<li>" ),
-                       wrapper = $( "<div>" );
+                       wrapper = $( "<div>", {
+                               title: item.element.attr( "title" )
+                       });
 
                if ( item.disabled ) {
                        li.addClass( "ui-state-disabled" );