]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-16817 Group of radio buttons is missing <fieldset>
authorMathieu Suen <mathieu.suen@sonarsource.com>
Thu, 25 Aug 2022 09:30:39 +0000 (11:30 +0200)
committersonartech <sonartech@sonarsource.com>
Fri, 26 Aug 2022 20:03:25 +0000 (20:03 +0000)
server/sonar-web/src/main/js/apps/issues/components/BulkChangeModal.tsx
server/sonar-web/src/main/js/components/controls/Modal.css

index 0e43ecbde506ae797c5280767d89a0aa2ad2c4d7..b40ad4a4043fe3e99c4a572be8bad286eb4e2d30 100644 (file)
@@ -419,20 +419,22 @@ export default class BulkChangeModal extends React.PureComponent<Props, State> {
 
     return (
       <div className="modal-field">
-        <label>{translate('issue.transition')}</label>
-        {transitions.map(transition => (
-          <span
-            className="bulk-change-radio-button display-flex-center display-flex-space-between"
-            key={transition.transition}>
-            <Radio
-              checked={this.state.transition === transition.transition}
-              onCheck={this.handleRadioTransitionChange}
-              value={transition.transition}>
-              {translate('issue.transition', transition.transition)}
-            </Radio>
-            {this.renderAffected(transition.count)}
-          </span>
-        ))}
+        <fieldset>
+          <legend>{translate('issue.transition')}</legend>
+          {transitions.map(transition => (
+            <span
+              className="bulk-change-radio-button display-flex-center display-flex-space-between"
+              key={transition.transition}>
+              <Radio
+                checked={this.state.transition === transition.transition}
+                onCheck={this.handleRadioTransitionChange}
+                value={transition.transition}>
+                {translate('issue.transition', transition.transition)}
+              </Radio>
+              {this.renderAffected(transition.count)}
+            </span>
+          ))}
+        </fieldset>
       </div>
     );
   };
index ed40cf964109b17d9bbe1a42303dea05e55f99d0..7280e57da18833390120c8f89b9db711f53b9a43 100644 (file)
 }
 
 .modal-field label,
-.modal-validation-field label {
+.modal-validation-field label,
+.modal-field legend {
   display: block;
   font-weight: bold;
   padding-bottom: calc(var(--gridSize) / 2);