]> source.dussan.org Git - vaadin-framework.git/commitdiff
Fix some modern browsers tests failures.
authorDenis Anisimov <denis@vaadin.com>
Wed, 9 Nov 2016 15:25:41 +0000 (17:25 +0200)
committerDenis Anisimov <denis@vaadin.com>
Thu, 10 Nov 2016 07:43:35 +0000 (07:43 +0000)
Change-Id: I2a89d3493e2f98ab1b9a0666d9dc075a2457e432

uitest/src/test/java/com/vaadin/tests/components/abstractembedded/EmbeddedWithNullSourceTest.java
uitest/src/test/java/com/vaadin/tests/components/flash/FlashIsVisibleTest.java
uitest/src/test/java/com/vaadin/tests/components/uitest/ThemeTest.java

index c97c9972315ebfc0fd9ccdef0a12388f0f7b2c8f..2cd31573fbd784808b976c07c378ea7665c7e8a0 100644 (file)
@@ -31,8 +31,9 @@ public class EmbeddedWithNullSourceTest extends MultiBrowserTest {
     public List<DesiredCapabilities> getBrowsersToTest() {
         // No Flash on PhantomJS, IE 11 has a timeout issue, looks like a
         // IEDriver problem, not reproduced running locally.
+        // Flash is disabled in Chrome.
         return getBrowserCapabilities(Browser.IE8, Browser.IE9, Browser.IE10,
-                Browser.CHROME, Browser.FIREFOX);
+                Browser.FIREFOX);
     }
 
     @Test
index 4f8d6602fecae95c115e80dc1bce2fcef676a197..defd6367cb3a5264df4e89eb5a12b4777d7fd6fb 100644 (file)
@@ -15,7 +15,7 @@ public class FlashIsVisibleTest extends MultiBrowserTest {
         // FF and PhantomJS fail at Flash and ShiftClick
         List<DesiredCapabilities> capabilities = getBrowsersSupportingShiftClick();
         // Flash support in Chrome is disabled
-        capabilities.remove(Browser.CHROME);
+        capabilities.removeAll(getBrowserCapabilities(Browser.CHROME));
         return capabilities;
     }
 
index ad6bc240d4a6e058821b8b1ae005fd6677f79b73..b29933232464f747b3d4dd45c63d2679a8f5e6d8 100644 (file)
@@ -9,11 +9,11 @@ import org.openqa.selenium.interactions.Actions;
 
 import com.vaadin.testbench.By;
 import com.vaadin.testbench.elements.ButtonElement;
+import com.vaadin.testbench.elements.ComboBoxElement;
 import com.vaadin.testbench.elements.TableElement;
 import com.vaadin.testbench.elementsbase.ServerClass;
 import com.vaadin.testbench.parallel.BrowserUtil;
 import com.vaadin.tests.tb3.MultiBrowserTest;
-import com.vaadin.tests.tb3.newelements.ComboBoxElement;
 import com.vaadin.tests.tb3.newelements.FixedNotificationElement;
 import com.vaadin.tests.tb3.newelements.WindowElement;