use Collections.singletonList and Collections.emptyList where appropriate

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777056 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/src/scratchpad/src/org/apache/poi/hwpf/usermodel/Picture.java b/src/scratchpad/src/org/apache/poi/hwpf/usermodel/Picture.java
index 108544efe7fe9ba169ac2625e519db1f5bbe5605..ab230580a1d3b7252065f583c36c01d348ce7d01 100644 (file)
--- a/src/scratchpad/src/org/apache/poi/hwpf/usermodel/Picture.java
+++ b/src/scratchpad/src/org/apache/poi/hwpf/usermodel/Picture.java
@@ -21,7 +21,7 @@ import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
 import java.io.OutputStream;
-import java.util.Arrays;
+import java.util.Collections;
 import java.util.List;
 import java.util.zip.InflaterInputStream;
 
@@ -85,7 +85,7 @@ public final class Picture
 
     private PICF _picf;
     private PICFAndOfficeArtData _picfAndOfficeArtData;
-    private List<? extends EscherRecord> _blipRecords;
+    private final List<? extends EscherRecord> _blipRecords;
 
     private byte[] content;
     private int dataBlockStartOfsset;
@@ -100,7 +100,7 @@ public final class Picture
      */
     public Picture( EscherBlipRecord blipRecord )
     {
-       this._blipRecords = Arrays.asList(new EscherBlipRecord[] {blipRecord});
+       this._blipRecords = Collections.singletonList(blipRecord);
     }
 
     /**
@@ -115,7 +115,9 @@ public final class Picture
         this.dataBlockStartOfsset = dataBlockStartOfsset;
 
         if ( _picfAndOfficeArtData != null && _picfAndOfficeArtData.getBlipRecords() != null) {
-           _blipRecords = _picfAndOfficeArtData.getBlipRecords();
+            _blipRecords = _picfAndOfficeArtData.getBlipRecords();
+        } else {
+            _blipRecords = Collections.emptyList();
         }
         
         if ( fillBytes ) {