]> source.dussan.org Git - jquery-ui.git/commitdiff
projects / jquery-ui.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 272391b)
dialog: changed shadow default to false. Not quite ready to be on by default. Maybe...
authorRichard Worth <rdworth@gmail.com>
Sat, 31 Jan 2009 05:47:58 +0000 (05:47 +0000)
committerRichard Worth <rdworth@gmail.com>
Sat, 31 Jan 2009 05:47:58 +0000 (05:47 +0000)
tests/unit/dialog/dialog.js patch | blob | history
tests/visual/dialog/dialog_option_modal_false.html patch | blob | history
tests/visual/dialog/dialog_option_modal_true.html patch | blob | history
tests/visual/dialog/dialog_option_shadow_false.html [new file with mode: 0644] patch | blob
tests/visual/dialog/dialog_option_shadow_true.html [new file with mode: 0644] patch | blob
ui/ui.dialog.js patch | blob | history

diff --git a/tests/unit/dialog/dialog.js b/tests/unit/dialog/dialog.js
index 626d5e92afe9f737b1dc91f1449678c3e81da936..f71ad2ab66d757cefcaa9cab005ad67df88745d8 100644 (file)
--- a/tests/unit/dialog/dialog.js
+++ b/tests/unit/dialog/dialog.js
@@ -22,6 +22,7 @@ var defaults = {
        modal: false,
        position: 'center',
        resizable: true,
+       shadow: false,
        stack: true,
        title: '',
        width: 300
diff --git a/tests/visual/dialog/dialog_option_modal_false.html b/tests/visual/dialog/dialog_option_modal_false.html
index 647d9288a2d226a2e87b0240ef745e275023d569..325c5d61cff3d523fde58da3dcade81682dbf286 100644 (file)
--- a/tests/visual/dialog/dialog_option_modal_false.html
+++ b/tests/visual/dialog/dialog_option_modal_false.html
@@ -1,27 +1,27 @@
-<!doctype html>\r
-<html lang="en">\r
-<head>\r
-       <title>Dialog Visual Test : Dialog option modal false</title>\r
-       <link rel="stylesheet" href="../visual.css" type="text/css" />\r
-       <link rel="stylesheet" href="../../../themes/base/ui.all.css" type="text/css">\r
-       <script type="text/javascript" src="../../../jquery-1.3.1.js"></script>\r
-       <script type="text/javascript" src="../../../ui/ui.core.js"></script>\r
-       <script type="text/javascript" src="../../../ui/ui.dialog.js"></script>\r
-       <script type="text/javascript" src="../../../ui/ui.draggable.js"></script>\r
-       <script type="text/javascript" src="../../../ui/ui.resizable.js"></script>\r
-       <script type="text/javascript">\r
-       $(function() {\r
-               $("#dialog").dialog({\r
-                       modal: false\r
-               });\r
-       });\r
-       </script>\r
-</head>\r
-<body>\r
-\r
-<div id="dialog" title="Dialog Title">\r
-       <p> Dialog Content </p>\r
-</div>\r
-\r
-</body>\r
-</html>\r
+<!doctype html>
+<html lang="en">
+<head>
+       <title>Dialog Visual Test : Dialog option modal false</title>
+       <link rel="stylesheet" href="../visual.css" type="text/css" />
+       <link rel="stylesheet" href="../../../themes/base/ui.all.css" type="text/css">
+       <script type="text/javascript" src="../../../jquery-1.3.1.js"></script>
+       <script type="text/javascript" src="../../../ui/ui.core.js"></script>
+       <script type="text/javascript" src="../../../ui/ui.dialog.js"></script>
+       <script type="text/javascript" src="../../../ui/ui.draggable.js"></script>
+       <script type="text/javascript" src="../../../ui/ui.resizable.js"></script>
+       <script type="text/javascript">
+       $(function() {
+               $("#dialog").dialog({
+                       modal: false
+               });
+       });
+       </script>
+</head>
+<body>
+
+<div id="dialog" title="Dialog Title">
+       <p> Dialog Content </p>
+</div>
+
+</body>
+</html>
diff --git a/tests/visual/dialog/dialog_option_modal_true.html b/tests/visual/dialog/dialog_option_modal_true.html
index 75a1a0d6ba96dda182baff880a8647f04e5e97b2..82af4cad8985d44477e02637c66de60d9e507c44 100644 (file)
--- a/tests/visual/dialog/dialog_option_modal_true.html
+++ b/tests/visual/dialog/dialog_option_modal_true.html
@@ -1,27 +1,27 @@
-<!doctype html>\r
-<html lang="en">\r
-<head>\r
-       <title>Dialog Visual Test : Dialog option modal true</title>\r
-       <link rel="stylesheet" href="../visual.css" type="text/css" />\r
-       <link rel="stylesheet" href="../../../themes/base/ui.all.css" type="text/css">\r
-       <script type="text/javascript" src="../../../jquery-1.3.1.js"></script>\r
-       <script type="text/javascript" src="../../../ui/ui.core.js"></script>\r
-       <script type="text/javascript" src="../../../ui/ui.dialog.js"></script>\r
-       <script type="text/javascript" src="../../../ui/ui.draggable.js"></script>\r
-       <script type="text/javascript" src="../../../ui/ui.resizable.js"></script>\r
-       <script type="text/javascript">\r
-       $(function() {\r
-               $("#dialog").dialog({\r
-                       modal: true\r
-               });\r
-       });\r
-       </script>\r
-</head>\r
-<body>\r
-\r
-<div id="dialog" title="Dialog Title">\r
-       <p> Dialog Content </p>\r
-</div>\r
-\r
-</body>\r
-</html>\r
+<!doctype html>
+<html lang="en">
+<head>
+       <title>Dialog Visual Test : Dialog option modal true</title>
+       <link rel="stylesheet" href="../visual.css" type="text/css" />
+       <link rel="stylesheet" href="../../../themes/base/ui.all.css" type="text/css">
+       <script type="text/javascript" src="../../../jquery-1.3.1.js"></script>
+       <script type="text/javascript" src="../../../ui/ui.core.js"></script>
+       <script type="text/javascript" src="../../../ui/ui.dialog.js"></script>
+       <script type="text/javascript" src="../../../ui/ui.draggable.js"></script>
+       <script type="text/javascript" src="../../../ui/ui.resizable.js"></script>
+       <script type="text/javascript">
+       $(function() {
+               $("#dialog").dialog({
+                       modal: true
+               });
+       });
+       </script>
+</head>
+<body>
+
+<div id="dialog" title="Dialog Title">
+       <p> Dialog Content </p>
+</div>
+
+</body>
+</html>
diff --git a/tests/visual/dialog/dialog_option_shadow_false.html b/tests/visual/dialog/dialog_option_shadow_false.html
new file mode 100644 (file)
index 0000000..7d7afef
--- /dev/null
+++ b/tests/visual/dialog/dialog_option_shadow_false.html
@@ -0,0 +1,27 @@
+<!doctype html>
+<html lang="en">
+<head>
+       <title>Dialog Visual Test : Dialog option shadow false</title>
+       <link rel="stylesheet" href="../visual.css" type="text/css" />
+       <link rel="stylesheet" href="../../../themes/base/ui.all.css" type="text/css">
+       <script type="text/javascript" src="../../../jquery-1.3.1.js"></script>
+       <script type="text/javascript" src="../../../ui/ui.core.js"></script>
+       <script type="text/javascript" src="../../../ui/ui.dialog.js"></script>
+       <script type="text/javascript" src="../../../ui/ui.draggable.js"></script>
+       <script type="text/javascript" src="../../../ui/ui.resizable.js"></script>
+       <script type="text/javascript">
+       $(function() {
+               $("#dialog").dialog({
+                       shadow: false
+               });
+       });
+       </script>
+</head>
+<body>
+
+<div id="dialog" title="Dialog Title">
+       <p> Dialog Content </p>
+</div>
+
+</body>
+</html>
diff --git a/tests/visual/dialog/dialog_option_shadow_true.html b/tests/visual/dialog/dialog_option_shadow_true.html
new file mode 100644 (file)
index 0000000..120015a
--- /dev/null
+++ b/tests/visual/dialog/dialog_option_shadow_true.html
@@ -0,0 +1,27 @@
+<!doctype html>
+<html lang="en">
+<head>
+       <title>Dialog Visual Test : Dialog option shadow true</title>
+       <link rel="stylesheet" href="../visual.css" type="text/css" />
+       <link rel="stylesheet" href="../../../themes/base/ui.all.css" type="text/css">
+       <script type="text/javascript" src="../../../jquery-1.3.1.js"></script>
+       <script type="text/javascript" src="../../../ui/ui.core.js"></script>
+       <script type="text/javascript" src="../../../ui/ui.dialog.js"></script>
+       <script type="text/javascript" src="../../../ui/ui.draggable.js"></script>
+       <script type="text/javascript" src="../../../ui/ui.resizable.js"></script>
+       <script type="text/javascript">
+       $(function() {
+               $("#dialog").dialog({
+                       shadow: true
+               });
+       });
+       </script>
+</head>
+<body>
+
+<div id="dialog" title="Dialog Title">
+       <p> Dialog Content </p>
+</div>
+
+</body>
+</html>
diff --git a/ui/ui.dialog.js b/ui/ui.dialog.js
index 58f8457b8887d24e7d72e9fddef106f5afb82f6e..ac43fcdc346f015c4b77e6cfd4b996686eb818d8 100644 (file)
--- a/ui/ui.dialog.js
+++ b/ui/ui.dialog.js
@@ -522,7 +522,7 @@ $.extend($.ui.dialog, {
                modal: false,
                position: 'center',
                resizable: true,
-               shadow: true,
+               shadow: false,
                stack: true,
                title: '',
                width: 300,
The official jQuery user interface library: https://github.com/jquery/jquery-ui