Remove final modifier on args4j option or argument fields

Remove final field modifier since args4j does no longer allow use of
final fields [1].

[1] https://github.com/kohsuke/args4j/commit/6e11f89d40dcc518c0e5eb9eef5d74f05d58e6af

Change-Id: Ib3dee10828d87d6b558c2e90387eadd9aa2ce260
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

diff --git a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Daemon.java b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Daemon.java
index 314b85f40b871bff49b1f41fc97436afc87b26c6..51bb9792d700b43b063e5d79d428f80e2fab9124 100644 (file)
--- a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Daemon.java
+++ b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Daemon.java
@@ -87,16 +87,16 @@ class Daemon extends TextBuiltin {
        int timeout = -1;
 
        @Option(name = "--enable", metaVar = "metaVar_service", usage = "usage_enableTheServiceInAllRepositories")
-       final List<String> enable = new ArrayList<>();
+       List<String> enable = new ArrayList<>();
 
        @Option(name = "--disable", metaVar = "metaVar_service", usage = "usage_disableTheServiceInAllRepositories")
-       final List<String> disable = new ArrayList<>();
+       List<String> disable = new ArrayList<>();
 
        @Option(name = "--allow-override", metaVar = "metaVar_service", usage = "usage_configureTheServiceInDaemonServicename")
-       final List<String> canOverride = new ArrayList<>();
+       List<String> canOverride = new ArrayList<>();
 
        @Option(name = "--forbid-override", metaVar = "metaVar_service", usage = "usage_configureTheServiceInDaemonServicename")
-       final List<String> forbidOverride = new ArrayList<>();
+       List<String> forbidOverride = new ArrayList<>();
 
        @Option(name = "--export-all", usage = "usage_exportWithoutGitDaemonExportOk")
        boolean exportAll;
@@ -109,7 +109,7 @@ class Daemon extends TextBuiltin {
        }
 
        @Argument(required = true, metaVar = "metaVar_directory", usage = "usage_directoriesToExport")
-       final List<File> directory = new ArrayList<>();
+       List<File> directory = new ArrayList<>();
 
        @Override
        protected boolean requiresRepository() {

diff --git a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/DiffTree.java b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/DiffTree.java
index 34fbe3746af34ceb5982846757aae334a0924b9c..44324059943ce292cce0912b105c48c6808b8cc8 100644 (file)
--- a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/DiffTree.java
+++ b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/DiffTree.java
@@ -67,7 +67,7 @@ class DiffTree extends TextBuiltin {
        }
 
        @Argument(index = 1, metaVar = "metaVar_treeish", required = true)
-       private final List<AbstractTreeIterator> trees = new ArrayList<>();
+       private List<AbstractTreeIterator> trees = new ArrayList<>();
 
        @Option(name = "--", metaVar = "metaVar_path", handler = PathTreeFilterHandler.class)
        private TreeFilter pathFilter = TreeFilter.ALL;

diff --git a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/MergeBase.java b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/MergeBase.java
index f8bae1d8beb989fe033c83c1708053de14960168..975d5deeee8b08cdd2815d1bf82ddffbcb8ee472 100644 (file)
--- a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/MergeBase.java
+++ b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/MergeBase.java
@@ -63,7 +63,7 @@ class MergeBase extends TextBuiltin {
        }
 
        @Argument(index = 1, metaVar = "metaVar_commitish", required = true)
-       private final List<RevCommit> commits = new ArrayList<>();
+       private List<RevCommit> commits = new ArrayList<>();
 
        @Override
        protected void run() throws Exception {

diff --git a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Push.java b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Push.java
index 1b805d16fc5dac7a6414b468558454d4d8451187..389708e6e129e7a739b2d645470da0f93543830e 100644 (file)
--- a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Push.java
+++ b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Push.java
@@ -77,7 +77,7 @@ class Push extends TextBuiltin {
        private String remote = Constants.DEFAULT_REMOTE_NAME;
 
        @Argument(index = 1, metaVar = "metaVar_refspec")
-       private final List<RefSpec> refSpecs = new ArrayList<>();
+       private List<RefSpec> refSpecs = new ArrayList<>();
 
        @Option(name = "--all")
        private boolean all;