[NO JIRA] Remove code smells

diff --git a/server/sonar-web/src/main/js/app/components/metrics/MetricsContextProvider.tsx b/server/sonar-web/src/main/js/app/components/metrics/MetricsContextProvider.tsx
index 0567e7da9f9ad2b6512628177955dc968af9e949..c1a0d81711c47631a236daa03a209719b4870710 100644 (file)
--- a/server/sonar-web/src/main/js/app/components/metrics/MetricsContextProvider.tsx
+++ b/server/sonar-web/src/main/js/app/components/metrics/MetricsContextProvider.tsx
@@ -36,7 +36,6 @@ export default class MetricsContextProvider extends React.PureComponent<{}, Stat
 
   componentDidMount() {
     this.mounted = true;
-
     this.fetchMetrics();
   }
 
@@ -46,7 +45,9 @@ export default class MetricsContextProvider extends React.PureComponent<{}, Stat
 
   fetchMetrics = async () => {
     const metricList = await getAllMetrics();
-    this.setState({ metrics: keyBy(metricList, 'key') });
+    if (this.mounted) {
+      this.setState({ metrics: keyBy(metricList, 'key') });
+    }
   };
 
   render() {