#6572 added comments

svn changeset:18453/svn branch:6.6

diff --git a/src/com/vaadin/data/util/AbstractBeanContainer.java b/src/com/vaadin/data/util/AbstractBeanContainer.java
index 7ed8e731b948a4f10105b23ff88db7b9c4798388..f19833ccfa2019b7fead98e22946f8ad2534fff8 100644 (file)
--- a/src/com/vaadin/data/util/AbstractBeanContainer.java
+++ b/src/com/vaadin/data/util/AbstractBeanContainer.java
@@ -214,6 +214,8 @@ public abstract class AbstractBeanContainer<IDTYPE, BEANTYPE> extends
         }
         itemIdToItem.clear();
 
+        // fire event only if the visible view changed, regardless of whether
+        // filtered out items were removed or not
         if (origSize != 0) {
             fireItemSetChange();
         }
@@ -281,6 +283,8 @@ public abstract class AbstractBeanContainer<IDTYPE, BEANTYPE> extends
             // remove item
             itemIdToItem.remove(itemId);
 
+            // fire event only if the visible view changed, regardless of
+            // whether filtered out items were removed or not
             if (size() != origSize) {
                 fireItemRemoved(position, itemId);
             }

diff --git a/src/com/vaadin/data/util/IndexedContainer.java b/src/com/vaadin/data/util/IndexedContainer.java
index 11ab3c2728af3b4cdb68c0902a5974448a312285..6c8e5f0f2e42cf7ff56e26ecad98ff09daea81dd 100644 (file)
--- a/src/com/vaadin/data/util/IndexedContainer.java
+++ b/src/com/vaadin/data/util/IndexedContainer.java
@@ -212,6 +212,8 @@ public class IndexedContainer extends
 
         items.clear();
 
+        // fire event only if the visible view changed, regardless of whether
+        // filtered out items were removed or not
         if (origSize != 0) {
             // Sends a change event
             fireItemSetChange();
@@ -275,6 +277,8 @@ public class IndexedContainer extends
         int origSize = size();
         int position = indexOfId(itemId);
         if (internalRemoveItem(itemId)) {
+            // fire event only if the visible view changed, regardless of
+            // whether filtered out items were removed or not
             if (size() != origSize) {
                 fireItemRemoved(position, itemId);
             }