]> source.dussan.org Git - sonarqube.git/commitdiff
Decrease visibility of some methods of org.sonar.persistence.review.ReviewQuery
authorSimon Brandhof <simon.brandhof@gmail.com>
Wed, 14 Dec 2011 16:41:48 +0000 (17:41 +0100)
committerSimon Brandhof <simon.brandhof@gmail.com>
Wed, 14 Dec 2011 16:41:48 +0000 (17:41 +0100)
sonar-core/src/main/java/org/sonar/persistence/review/ReviewQuery.java
sonar-core/src/test/java/org/sonar/persistence/review/ReviewDaoTest.java

index 8f3cdda15bbae7e6d307166ed0c6ec8d15e76afe..ed649d628401afd65f61329c9113366fc0bf67f7 100644 (file)
@@ -128,11 +128,11 @@ public final class ReviewQuery {
     return this;
   }
 
-  protected boolean needToPartitionQuery() {
+  boolean needToPartitionQuery() {
     return violationPermanentIds != null && violationPermanentIds.size() > DatabaseUtils.MAX_IN_ELEMENTS;
   }
 
-  public ReviewQuery[] partition() {
+  ReviewQuery[] partition() {
     List<List<Integer>> partitions = Lists.partition(violationPermanentIds, DatabaseUtils.MAX_IN_ELEMENTS);
     ReviewQuery[] result = new ReviewQuery[partitions.size()];
     for (int index = 0; index < partitions.size(); index++) {
index 4e776f276a65b982a66a2f1405ffa1480bd4f53d..18c9beb948d83ed71f311333e322a7abb76882bf 100644 (file)
@@ -25,9 +25,6 @@ import org.hamcrest.Description;
 import org.junit.Before;
 import org.junit.Test;
 import org.sonar.persistence.DaoTestCase;
-import org.sonar.persistence.review.ReviewDao;
-import org.sonar.persistence.review.ReviewDto;
-import org.sonar.persistence.review.ReviewQuery;
 
 import java.util.List;
 
@@ -131,8 +128,6 @@ public class ReviewDaoTest extends DaoTestCase {
 
     public boolean matches(Object o) {
       ReviewDto reviewDto = (ReviewDto) o;
-      System.out.println(reviewDto.getViolationPermanentId());
-
       return expectedId.equals(reviewDto.getViolationPermanentId());
     }