]> source.dussan.org Git - jquery.git/commitdiff
Tests: Skip a "width/height on a table row with phantom borders" test in Firefox
authorMichał Gołębiowski-Owczarek <m.goleb@gmail.com>
Mon, 28 Oct 2019 19:38:33 +0000 (20:38 +0100)
committerMichał Gołębiowski-Owczarek <m.goleb@gmail.com>
Mon, 28 Oct 2019 19:43:39 +0000 (20:43 +0100)
Firefox 70 & newer fail this test but the issue there is more profound - Firefox
doesn't subtract borders from table row computed widths.

Closes gh-4537
Ref jquery/jquery#4529
Ref https://bugzilla.mozilla.org/show_bug.cgi?id=1590837
Ref w3c/csswg-drafts#4444

(cherry picked from commit c79e1d5fefc50b1df0a1c2ca3f06b567e79c0f9b)

test/unit/dimensions.js

index d20a56c3bf9183a60511a207ec50cf327f81c93c..35fd1315182bcc1b94ee4e85a921bdf1fd6f00a3 100644 (file)
@@ -627,7 +627,14 @@ QUnit.test( "width/height on an inline element with percentage dimensions (gh-36
        }
 );
 
-QUnit.test( "width/height on a table row with phantom borders (gh-3698)", function( assert ) {
+// Support: Firefox 70+
+// Firefox 70 & newer fail this test but the issue there is more profound - Firefox doesn't
+// subtract borders from table row computed widths.
+// See https://github.com/jquery/jquery/issues/4529
+// See https://bugzilla.mozilla.org/show_bug.cgi?id=1590837
+// See https://github.com/w3c/csswg-drafts/issues/4444
+QUnit[ /firefox/i.test( navigator.userAgent ) ? "skip" : "test" ](
+       "width/height on a table row with phantom borders (gh-3698)", function( assert ) {
        assert.expect( 4 );
 
        jQuery( "<table id='gh3698' style='border-collapse: separate; border-spacing: 0;'><tbody>" +