Fix quality flaws and add some sonar version in class comments

diff --git a/sonar-server/src/main/java/org/sonar/server/issue/ActionService.java b/sonar-server/src/main/java/org/sonar/server/issue/ActionService.java
index cc94316bb116493a724d5d94ed9ba1224df4d1b3..a79aead0e47fdff11f9f8a23b64b9154b3b9a778 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/issue/ActionService.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/ActionService.java
@@ -50,6 +50,9 @@ import java.util.List;
 
 import static com.google.common.collect.Lists.newArrayList;
 
+/**
+ * @since 3.6
+ */
 public class ActionService implements ServerComponent {
 
   private final DefaultIssueFinder finder;

diff --git a/sonar-server/src/main/java/org/sonar/server/issue/InternalRubyIssueService.java b/sonar-server/src/main/java/org/sonar/server/issue/InternalRubyIssueService.java
index 24b091e3ab2233662c7f61badd7b0fd3a4ce90f3..3da16a249bb48b92d0a16305d4987c9f7c8b955d 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/issue/InternalRubyIssueService.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/InternalRubyIssueService.java
@@ -55,6 +55,8 @@ import java.util.Map;
 
 /**
  * All the issue features that are not published to public API.
+ *
+ * @since 3.6
  */
 public class InternalRubyIssueService implements ServerComponent {
 

diff --git a/sonar-server/src/main/java/org/sonar/server/issue/IssueChangelogService.java b/sonar-server/src/main/java/org/sonar/server/issue/IssueChangelogService.java
index 3f9101e226c12c8ee61e0cc5956603b24120cf40..809538a6f57c09bffde6d6fee986796bad51b6f1 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/issue/IssueChangelogService.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/IssueChangelogService.java
@@ -30,6 +30,9 @@ import org.sonar.server.user.UserSession;
 import java.util.Collection;
 import java.util.List;
 
+/**
+ * @since 3.6
+ */
 public class IssueChangelogService implements ServerComponent {
 
   private final IssueChangeDao changeDao;

diff --git a/sonar-server/src/main/java/org/sonar/server/issue/IssueCommentService.java b/sonar-server/src/main/java/org/sonar/server/issue/IssueCommentService.java
index ba8962c757fe4a1a2da9b18ee27fc86d78e765c0..10528901b289a74f72f3ebc358dde3dbd47e4d45 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/issue/IssueCommentService.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/IssueCommentService.java
@@ -39,6 +39,9 @@ import org.sonar.server.user.UserSession;
 import java.util.Arrays;
 import java.util.Date;
 
+/**
+ * @since 3.6
+ */
 public class IssueCommentService implements ServerComponent {
 
   private final IssueUpdater updater;

diff --git a/sonar-server/src/main/java/org/sonar/server/issue/IssueFilterResult.java b/sonar-server/src/main/java/org/sonar/server/issue/IssueFilterResult.java
index 6f317e86c6904d88fb409d8d5165cfe21d1caa06..d1769f80350ad2da0b981cf9907ec82ca3439333 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/issue/IssueFilterResult.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/IssueFilterResult.java
@@ -23,6 +23,9 @@ package org.sonar.server.issue;
 import org.sonar.api.issue.IssueQuery;
 import org.sonar.api.issue.IssueQueryResult;
 
+/**
+ * @since 3.7
+ */
 public class IssueFilterResult {
 
   private IssueQueryResult issueQueryResult;

diff --git a/sonar-server/src/main/java/org/sonar/server/issue/IssueFilterService.java b/sonar-server/src/main/java/org/sonar/server/issue/IssueFilterService.java
index 94458ab3589f5f4d6b9099f4a28703776b0a1a36..9c22a237e2459630a788be3239b52a6d1fea7704 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/issue/IssueFilterService.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/IssueFilterService.java
@@ -44,6 +44,9 @@ import java.util.Map;
 
 import static com.google.common.collect.Lists.newArrayList;
 
+/**
+ * @since 3.7
+ */
 public class IssueFilterService implements ServerComponent {
 
   private final IssueFilterDao issueFilterDao;
@@ -72,7 +75,10 @@ public class IssueFilterService implements ServerComponent {
   @CheckForNull
   public DefaultIssueFilter findById(Long id) {
     IssueFilterDto issueFilterDto = issueFilterDao.selectById(id);
-    return issueFilterDto.toIssueFilter();
+    if (issueFilterDto != null) {
+      return issueFilterDto.toIssueFilter();
+    }
+    return null;
   }
 
   public List<DefaultIssueFilter> findByUser(UserSession userSession) {

diff --git a/sonar-server/src/main/java/org/sonar/server/issue/IssueStatsFinder.java b/sonar-server/src/main/java/org/sonar/server/issue/IssueStatsFinder.java
index 561272244d444f7144e7d97d051cbb496b01e248..e0cbf41b4c51c31e9715cd0ff43c9124835dc630 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/issue/IssueStatsFinder.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/IssueStatsFinder.java
@@ -38,6 +38,9 @@ import java.util.List;
 import java.util.Map;
 import java.util.Set;
 
+/**
+ * @since 3.6
+ */
 public class IssueStatsFinder implements ServerComponent {
 
   private final IssueStatsDao issuestatsDao;

diff --git a/sonar-server/src/main/java/org/sonar/server/issue/IssuesFinderSort.java b/sonar-server/src/main/java/org/sonar/server/issue/IssuesFinderSort.java
index 9862a23d8ef68848127cafde4f668e20c4e0837f..786b5f25b68706abb60269822404165dfa29a823 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/issue/IssuesFinderSort.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/IssuesFinderSort.java
@@ -29,6 +29,9 @@ import java.util.Collection;
 import java.util.Date;
 import java.util.List;
 
+/**
+ * @since 3.6
+ */
 class IssuesFinderSort {
 
   private List<IssueDto> issues;

diff --git a/sonar-server/src/main/java/org/sonar/server/issue/ServerIssueStorage.java b/sonar-server/src/main/java/org/sonar/server/issue/ServerIssueStorage.java
index ad1fce39df3abbc841e459fa1ef81c344b12f46c..6c84ad9c2f06455ddc70f64ad9a38a0c3ade718f 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/issue/ServerIssueStorage.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/ServerIssueStorage.java
@@ -28,6 +28,9 @@ import org.sonar.core.resource.ResourceDao;
 import org.sonar.core.resource.ResourceDto;
 import org.sonar.core.resource.ResourceQuery;
 
+/**
+ * @since 3.6
+ */
 public class ServerIssueStorage extends IssueStorage implements ServerComponent {
 
   private final ResourceDao resourceDao;