[bug-65700] do not warn if transformer factory does not support accessExternalDTD...

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895276 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/poi/src/main/java/org/apache/poi/util/XMLHelper.java b/poi/src/main/java/org/apache/poi/util/XMLHelper.java
index 8e7bae28989b4564ea3113c5bbe787e05929d0b9..58917e25d4a5101fa8ec92d693769c788630f8d9 100644 (file)
--- a/poi/src/main/java/org/apache/poi/util/XMLHelper.java
+++ b/poi/src/main/java/org/apache/poi/util/XMLHelper.java
@@ -221,7 +221,7 @@ public final class XMLHelper {
     public static TransformerFactory getTransformerFactory() {
         TransformerFactory factory = TransformerFactory.newInstance();
         trySet(factory::setFeature, FEATURE_SECURE_PROCESSING, true);
-        trySet(factory::setAttribute, ACCESS_EXTERNAL_DTD, "");
+        quietSet(factory::setAttribute, ACCESS_EXTERNAL_DTD, "");
         trySet(factory::setAttribute, ACCESS_EXTERNAL_STYLESHEET, "");
         quietSet(factory::setAttribute, ACCESS_EXTERNAL_SCHEMA, "");
         return factory;

diff --git a/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java b/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java
index a4e8732b8d1004b3b3b673cfe78f6472c4eb0f4c..52041ffdba4f66db00ed5adb03fa0a4a82dcc3f4 100644 (file)
--- a/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java
+++ b/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java
@@ -158,4 +158,12 @@ class TestXMLHelper {
     void testNewXMLEventFactory() {
         assertNotNull(XMLHelper.newXMLEventFactory());
     }
+
+    /**
+     * test that newTransformer returns a transformer
+     */
+    @Test
+    void testNewTransformer() throws Exception {
+        assertNotNull(XMLHelper.newTransformer());
+    }
 }