]> source.dussan.org Git - vaadin-framework.git/commitdiff
Remove unneeded .toString() (#10141)
authorAhmed Ashour <asashour@yahoo.com>
Tue, 10 Oct 2017 10:06:27 +0000 (12:06 +0200)
committerHenri Sara <henri.sara@gmail.com>
Tue, 10 Oct 2017 10:06:27 +0000 (13:06 +0300)
75 files changed:
client-compiler/src/main/java/com/vaadin/tools/ReportUsage.java
client/src/main/java/com/vaadin/client/MeasuredSize.java
client/src/main/java/com/vaadin/client/communication/ServerRpcQueue.java
client/src/main/java/com/vaadin/client/metadata/Type.java
client/src/main/java/com/vaadin/client/ui/VAccordion.java
client/src/main/java/com/vaadin/client/ui/VTabsheet.java
client/src/main/java/com/vaadin/client/ui/menubar/MenuBarConnector.java
client/src/main/java/com/vaadin/client/widgets/Grid.java
compatibility-client/src/main/java/com/vaadin/v7/client/connectors/GridConnector.java
compatibility-client/src/main/java/com/vaadin/v7/client/widgets/Grid.java
compatibility-server-gae/src/main/java/com/vaadin/server/GAEVaadinServlet.java
compatibility-server/src/main/java/com/vaadin/v7/data/util/PropertyFormatter.java
compatibility-server/src/main/java/com/vaadin/v7/data/util/TextFileProperty.java
compatibility-server/src/main/java/com/vaadin/v7/data/util/sqlcontainer/RowItem.java
compatibility-server/src/main/java/com/vaadin/v7/data/util/sqlcontainer/query/generator/MSSQLGenerator.java
compatibility-server/src/main/java/com/vaadin/v7/ui/AbstractTextField.java
compatibility-server/src/main/java/com/vaadin/v7/ui/Form.java
compatibility-server/src/main/java/com/vaadin/v7/ui/Grid.java
compatibility-server/src/main/java/com/vaadin/v7/ui/renderers/DateRenderer.java
compatibility-server/src/main/java/com/vaadin/v7/ui/renderers/NumberRenderer.java
compatibility-server/src/test/java/com/vaadin/v7/data/util/sqlcontainer/FreeformQueryUtil.java
compatibility-server/src/test/java/com/vaadin/v7/tests/server/component/grid/declarative/GridDeclarativeTestBase.java
server/src/main/java/com/vaadin/server/communication/AtmospherePushConnection.java
server/src/main/java/com/vaadin/ui/AbstractSingleComponentContainer.java
server/src/main/java/com/vaadin/ui/ComboBox.java
server/src/main/java/com/vaadin/ui/Grid.java
server/src/main/java/com/vaadin/ui/UI.java
server/src/main/java/com/vaadin/ui/declarative/DesignContext.java
server/src/main/java/com/vaadin/ui/declarative/converters/DesignResourceConverter.java
server/src/main/java/com/vaadin/ui/renderers/DateRenderer.java
server/src/main/java/com/vaadin/ui/renderers/NumberRenderer.java
server/src/test/java/com/vaadin/data/provider/BackendDataProviderTest.java
server/src/test/java/com/vaadin/data/provider/hierarchical/Node.java
uitest/src/main/java/com/vaadin/launcher/ApplicationRunnerServlet.java
uitest/src/main/java/com/vaadin/launcher/DevelopmentServerLauncher.java
uitest/src/main/java/com/vaadin/tests/CustomLayoutDemo.java
uitest/src/main/java/com/vaadin/tests/Parameters.java
uitest/src/main/java/com/vaadin/tests/StressComponentsInTable.java
uitest/src/main/java/com/vaadin/tests/TestBench.java
uitest/src/main/java/com/vaadin/tests/TestCaptionWrapper.java
uitest/src/main/java/com/vaadin/tests/TreeFilesystem.java
uitest/src/main/java/com/vaadin/tests/UsingCustomNewItemHandlerInSelect.java
uitest/src/main/java/com/vaadin/tests/VaadinClasses.java
uitest/src/main/java/com/vaadin/tests/components/abstractfield/AbstractFieldTest.java
uitest/src/main/java/com/vaadin/tests/components/abstractfield/LegacyAbstractFieldTest.java
uitest/src/main/java/com/vaadin/tests/components/abstractfield/Vaadin6ImplicitDoubleConverter.java
uitest/src/main/java/com/vaadin/tests/components/abstractlisting/AbstractMultiSelectTestUI.java
uitest/src/main/java/com/vaadin/tests/components/button/ButtonMouseDetails.java
uitest/src/main/java/com/vaadin/tests/components/checkbox/CheckBoxGroupTestUI.java
uitest/src/main/java/com/vaadin/tests/components/combobox/ComboBoxBackEndRequests.java
uitest/src/main/java/com/vaadin/tests/components/combobox/ComboFocusBlurEvents.java
uitest/src/main/java/com/vaadin/tests/components/combobox/ComboPushTiming.java
uitest/src/main/java/com/vaadin/tests/components/datefield/DateFields.java
uitest/src/main/java/com/vaadin/tests/components/datefield/InlineDateFields.java
uitest/src/main/java/com/vaadin/tests/components/grid/basics/GridBasics.java
uitest/src/main/java/com/vaadin/tests/components/optiongroup/OptionGroups.java
uitest/src/main/java/com/vaadin/tests/components/radiobutton/RadioButtonGroupTestUI.java
uitest/src/main/java/com/vaadin/tests/components/richtextarea/RichTextAreaWithKeyboardShortcuts.java
uitest/src/main/java/com/vaadin/tests/components/table/ColumnReorderEvent.java
uitest/src/main/java/com/vaadin/tests/components/table/KeyControl.java
uitest/src/main/java/com/vaadin/tests/components/textarea/ScrollCursor.java
uitest/src/main/java/com/vaadin/tests/components/textfield/TextFieldFocusAndBlurListeners.java
uitest/src/main/java/com/vaadin/tests/components/ui/PushStateAndReplaceState.java
uitest/src/main/java/com/vaadin/tests/components/ui/RpcInvocationHandlerToString.java
uitest/src/main/java/com/vaadin/tests/components/window/ShortcutInWindow.java
uitest/src/main/java/com/vaadin/tests/containers/BeanItemContainerFilteringTest.java
uitest/src/main/java/com/vaadin/tests/containers/IndexedContainerFilteringTest.java
uitest/src/main/java/com/vaadin/tests/dnd/DragImage.java
uitest/src/main/java/com/vaadin/tests/layouts/OrderedLayoutBasics.java
uitest/src/main/java/com/vaadin/tests/minitutorials/v71beta/CSSInjectWithColorpicker.java
uitest/src/main/java/com/vaadin/tests/serialization/SerializerTest.java
uitest/src/main/java/com/vaadin/tests/themes/CSSInjectTest.java
uitest/src/test/java/com/vaadin/tests/components/datefield/DateFieldElementTest.java
uitest/src/test/java/com/vaadin/tests/components/datefield/DateTimeFieldElementTest.java
uitest/src/test/java/com/vaadin/tests/tb3/TB3TestLocator.java

index 4057c531d67d30aa27f563d10fe7849d5585a903..96020e5cb9951ed2a7ff39098836690ccb750f36 100644 (file)
@@ -144,10 +144,10 @@ public class ReportUsage {
         appendUserAgentProperty(extra, "os.version");
 
         if (extra.length() != 0) {
-            userAgent += " (" + extra.toString() + ")";
+            userAgent += " (" + extra + ")";
         }
 
-        return userAgent.toString();
+        return userAgent;
     }
 
     private static void appendUserAgentProperty(StringBuilder sb,
index 2029fd9e4d31f11fd69e84ccdfed4b3f4e5208db..1fcdb9d17afad884e54988c060701d80f0760374 100644 (file)
@@ -280,7 +280,7 @@ public class MeasuredSize {
             String changedFrom, String changedTo) {
         if (debugSizeChanges) {
             getLogger().info(sizeChangeType + " has changed from " + changedFrom
-                    + " to " + changedTo + " for " + element.toString());
+                    + " to " + changedTo + " for " + element);
         }
     }
 
index 23b34902318f970b49fdefaa68e5df6502a075d2..1460b978aca681f43086b6e994ac1683c75f81e3 100644 (file)
@@ -251,7 +251,7 @@ public class ServerRpcQueue {
             String connectorId = invocation.getConnectorId();
             if (!connectorExists(connectorId)) {
                 getLogger().info("Ignoring RPC for removed connector: "
-                        + connectorId + ": " + invocation.toString());
+                        + connectorId + ": " + invocation);
                 continue;
             }
 
@@ -269,8 +269,8 @@ public class ServerRpcQueue {
                     Method method = type.getMethod(invocation.getMethodName());
                     parameterTypes = method.getParameterTypes();
                 } catch (NoDataException e) {
-                    throw new RuntimeException(
-                            "No type data for " + invocation.toString(), e);
+                    throw new RuntimeException("No type data for " + invocation,
+                            e);
                 }
             }
 
index 587731aac604a1d8d01d5de52a05dce242ab64af..408d085d3d1db83213fa8c4b26c18dfc546b26bc 100644 (file)
@@ -89,7 +89,7 @@ public class Type {
                 if (i != 0) {
                     string += ',';
                 }
-                string += parameterTypes[i].toString();
+                string += parameterTypes[i];
             }
             string += '>';
         }
index 6bba4f22eb0cbf7650926eeda0b4af285ac982ad..9ad4ef4e96d50bb5eadb40fd3d2e1025e1b3b154 100644 (file)
@@ -152,7 +152,7 @@ public class VAccordion extends VTabsheetBase {
             addStyleDependentName("loading");
 
             connector.getRpcProxy(TabsheetServerRpc.class)
-                    .setSelected(tabKeys.get(index).toString());
+                    .setSelected(tabKeys.get(index));
         }
     }
 
index 35c8c1c6fb4d572e73cd379dbbcf6cda0d6ccc31..f5e137f6e46eded187d27e26f2f453aa6c4f5eee 100644 (file)
@@ -828,7 +828,7 @@ public class VTabsheet extends VTabsheetBase
             getCurrentlyDisplayedWidget().getElement().getParentElement()
                     .getStyle().setVisibility(Visibility.HIDDEN);
 
-            getRpcProxy().setSelected(tabKeys.get(tabIndex).toString());
+            getRpcProxy().setSelected(tabKeys.get(tabIndex));
 
             waitingForResponse = true;
 
index 69fe36876810798916b4a484dcce5a6d697fd348..47d2eb0f35069244ee97178aa7f11deca1fe55da 100644 (file)
@@ -131,7 +131,7 @@ public class MenuBarConnector extends AbstractComponentConnector
                 }
             }
 
-            currentItem = currentMenu.addItem(itemHTML.toString(), cmd);
+            currentItem = currentMenu.addItem(itemHTML, cmd);
             currentItem.updateFromUIDL(item, client);
 
             if (item.getChildCount() > 0) {
index 2b623804cf43e4a1f085ba9fd7cb7bc33dd6da04..80c7e354c7c81de3147c0ea0403400df7e9956be 100755 (executable)
@@ -3164,8 +3164,7 @@ public class Grid<T> extends ResizeComposite implements HasSelectionHandlers<T>,
 
             if (!columns.contains(column)) {
                 throw new IllegalArgumentException(
-                        "Given column is not a column in this grid. "
-                                + column.toString());
+                        "Given column is not a column in this grid. " + column);
             }
 
             if (!column.isSortable()) {
@@ -4724,8 +4723,8 @@ public class Grid<T> extends ResizeComposite implements HasSelectionHandlers<T>,
             @Override
             public void render(RendererCellReference cell, Object data) {
                 if (!warned && !(data instanceof String)) {
-                    getLogger().warning(Column.this.toString() + ": "
-                            + DEFAULT_RENDERER_WARNING);
+                    getLogger().warning(
+                            Column.this + ": " + DEFAULT_RENDERER_WARNING);
                     warned = true;
                 }
 
@@ -5599,7 +5598,8 @@ public class Grid<T> extends ResizeComposite implements HasSelectionHandlers<T>,
 
             boolean isSelected = hasData && isSelected(rowData);
             if (Grid.this.selectionModel.isSelectionAllowed()) {
-                rowElement.setAttribute("aria-selected", String.valueOf(isSelected));
+                rowElement.setAttribute("aria-selected",
+                        String.valueOf(isSelected));
             } else {
                 rowElement.removeAttribute("aria-selected");
             }
@@ -6318,10 +6318,11 @@ public class Grid<T> extends ResizeComposite implements HasSelectionHandlers<T>,
      * Adds the given role as 'role="$param"' to the {@code <table />} element
      * of the grid.
      *
-     * @param role the role param
+     * @param role
+     *            the role param
      * @since 8.2
      */
-    protected void setAriaRole(String role){
+    protected void setAriaRole(String role) {
         escalator.getTable().setAttribute("role", role);
     }
 
index 771f06881a3e8370721f98dc6341006e9a9c5b52..57179b678cb388d9500e6d76b2725240dd92c98c 100644 (file)
@@ -471,8 +471,7 @@ public class GridConnector extends AbstractHasComponentsConnector
                 } else {
                     getLogger().warning(
                             "Visibility changed for a unknown column type in Grid: "
-                                    + column.toString() + ", type "
-                                    + column.getClass());
+                                    + column + ", type " + column.getClass());
                 }
             }
         }
index 3f5e798b7d0e21da6150868c218f61beb5f54aff..65d9adc3c14f36bcbd026c699f7602aac7fc5365 100644 (file)
@@ -3148,8 +3148,7 @@ public class Grid<T> extends ResizeComposite implements HasSelectionHandlers<T>,
 
             if (!columns.contains(column)) {
                 throw new IllegalArgumentException(
-                        "Given column is not a column in this grid. "
-                                + column.toString());
+                        "Given column is not a column in this grid. " + column);
             }
 
             if (!column.isSortable()) {
@@ -4714,8 +4713,8 @@ public class Grid<T> extends ResizeComposite implements HasSelectionHandlers<T>,
             @Override
             public void render(RendererCellReference cell, Object data) {
                 if (!warned && !(data instanceof String)) {
-                    getLogger().warning(Column.this.toString() + ": "
-                            + DEFAULT_RENDERER_WARNING);
+                    getLogger().warning(
+                            Column.this + ": " + DEFAULT_RENDERER_WARNING);
                     warned = true;
                 }
 
index 5b25a48ba956a4290c535a05e1f243606ff58580..3c59e52c79bdfbe485875206e881238d997877b9 100644 (file)
@@ -151,16 +151,14 @@ public class GAEVaadinServlet extends VaadinServlet {
             VaadinServletResponse response) throws IOException {
         criticalNotification(request, response, "NotSerializableException",
                 "I'm sorry, but there seems to be a serious problem, please contact the administrator. And please take note of any unsaved data...",
-                "",
-                getApplicationUrl(request).toString() + "?restartApplication");
+                "", getApplicationUrl(request) + "?restartApplication");
     }
 
     protected void sendCriticalErrorNotification(VaadinServletRequest request,
             VaadinServletResponse response) throws IOException {
         criticalNotification(request, response, "Critical error",
                 "I'm sorry, but there seems to be a serious problem, please contact the administrator. And please take note of any unsaved data...",
-                "",
-                getApplicationUrl(request).toString() + "?restartApplication");
+                "", getApplicationUrl(request) + "?restartApplication");
     }
 
     @Override
@@ -227,8 +225,8 @@ public class GAEVaadinServlet extends VaadinServlet {
                 try {
                     Thread.sleep(RETRY_AFTER_MILLISECONDS);
                 } catch (InterruptedException e) {
-                    getLogger()
-                            .finer("Thread.sleep() interrupted while waiting for lock. Trying again. "
+                    getLogger().finer(
+                            "Thread.sleep() interrupted while waiting for lock. Trying again. "
                                     + e);
                 }
             }
index 2e1ac13e9a4155f741594b5f45fd609f1a75bb49..223cf15098d6895d9cbdcd75613331d9a149ffbe 100644 (file)
@@ -31,7 +31,7 @@ import com.vaadin.v7.data.util.converter.Converter;
  * For example <code>
  * <pre>textfield.setPropertyDataSource(new PropertyFormatter(property) {
             public String format(Object value) {
-                return ((Double) value).toString() + "000000000";
+                return ((Double) value) + "000000000";
             }
 
             public Object parse(String formattedValue) throws Exception {
@@ -223,7 +223,7 @@ public abstract class PropertyFormatter<T> extends AbstractProperty<String>
             }
         } else {
             try {
-                dataSource.setValue(parse(newValue.toString()));
+                dataSource.setValue(parse(newValue));
                 if (!newValue.equals(getValue())) {
                     fireValueChange();
                 }
index 3dea636644a8aac988ba64d4e965f2be42ef20ad..52065485e50f5e8a6d566b741a6cee38beec3f2c 100644 (file)
@@ -145,7 +145,7 @@ public class TextFileProperty extends AbstractProperty<String> {
                     ? new OutputStreamWriter(fos)
                     : new OutputStreamWriter(fos, charset);
             BufferedWriter w = new BufferedWriter(osw);
-            w.append(newValue.toString());
+            w.append(newValue);
             w.flush();
             w.close();
             osw.close();
index 3cb4103521bcb2b9a889333a9aadb8dc30bc077c..78ef1f8d58c64ce6069141807742cea436d6602c 100644 (file)
@@ -127,13 +127,13 @@ public final class RowItem implements Item {
     public String toString() {
         StringBuilder s = new StringBuilder();
         s.append("ID:");
-        s.append(getId().toString());
+        s.append(getId());
         for (Object propId : getItemPropertyIds()) {
             s.append('|');
-            s.append(propId.toString());
+            s.append(propId);
             s.append(':');
             Object value = getItemProperty(propId).getValue();
-            s.append((null != value) ? value.toString() : null);
+            s.append(value);
         }
         return s.toString();
     }
index fa607aeb5acec31cb5edd76e11acbefba9efda0e..6385ad07678409bd8bb9bf5500fa6e769d401258 100644 (file)
@@ -112,7 +112,7 @@ public class MSSQLGenerator extends DefaultSQLGenerator {
             query.append(QueryBuilder.getWhereStringForFilters(filters, sh));
         }
         query.append(") AS a WHERE a.rownum BETWEEN ").append(offset)
-                .append(" AND ").append(Integer.toString(offset + pagelength));
+                .append(" AND ").append(offset + pagelength);
         sh.setQueryString(query.toString());
         return sh;
     }
index 305859534a1a55df7f66a1f36ceccfb0e46985b5..aeb6d8154e26ce68113e6a393052eebc7642fb3d 100644 (file)
@@ -442,9 +442,9 @@ public abstract class AbstractTextField extends AbstractField<String> implements
                 lastKnownTextContent = getNullRepresentation();
                 textChangeEventPending = true;
             } else if (newValue != null
-                    && !newValue.toString().equals(lastKnownTextContent)) {
+                    && !newValue.equals(lastKnownTextContent)) {
                 // Value was changed to something else than null representation
-                lastKnownTextContent = newValue.toString();
+                lastKnownTextContent = newValue;
                 textChangeEventPending = true;
             }
             firePendingTextChangeEvent();
@@ -652,7 +652,7 @@ public abstract class AbstractTextField extends AbstractField<String> implements
      * @since 6.4
      */
     public void selectAll() {
-        String text = getValue() == null ? "" : getValue().toString();
+        String text = getValue() == null ? "" : getValue();
         setSelectionRange(0, text.length());
     }
 
index 747a0eea51b78562700b601d41ba586492f62bc0..2e797cb7a9f9781023474e9b49df2571eca8fb35 100644 (file)
@@ -861,7 +861,7 @@ public class Form extends AbstractField<Object>
         final Field<?> oldField = fields.get(propertyId);
         if (oldField == null) {
             throw new IllegalArgumentException("Field with given propertyid '"
-                    + propertyId.toString() + "' can not be found.");
+                    + propertyId + "' can not be found.");
         }
         final Object value = oldField.getPropertyDataSource() == null
                 ? oldField.getValue()
@@ -890,16 +890,14 @@ public class Form extends AbstractField<Object>
                     if (!found) {
                         throw new IllegalArgumentException(
                                 "Currently selected value '" + val
-                                        + "' of property '"
-                                        + propertyId.toString()
+                                        + "' of property '" + propertyId
                                         + "' was not found");
                     }
                 }
                 isMultiselect = true;
             } else {
-                throw new IllegalArgumentException(
-                        "Current value '" + value + "' of property '"
-                                + propertyId.toString() + "' was not found");
+                throw new IllegalArgumentException("Current value '" + value
+                        + "' of property '" + propertyId + "' was not found");
             }
         }
 
index 9e8dd1086c29ce3e975b69a9a9208cd0e14e6b05..ded75d0755a8086325f99e03adafa3a259fcd884 100644 (file)
@@ -5265,13 +5265,11 @@ public class Grid extends AbstractComponent
             addColumnProperty(propertyId, String.class, "");
         } else {
             if (columns.containsKey(propertyId)) {
-                throw new IllegalStateException(
-                        "A column for property id '" + propertyId.toString()
-                                + "' already exists in this grid");
+                throw new IllegalStateException("A column for property id '"
+                        + propertyId + "' already exists in this grid");
             } else {
-                throw new IllegalStateException(
-                        "Property id '" + propertyId.toString()
-                                + "' does not exist in the container");
+                throw new IllegalStateException("Property id '" + propertyId
+                        + "' does not exist in the container");
             }
         }
 
index 95e22919ae1a6f2978c65e6b52a04424d13ef598..f6c1d87f93149c6e833488b3448174f9ec3c903c 100644 (file)
@@ -231,7 +231,7 @@ public class DateRenderer extends AbstractRenderer<Date> {
     public String toString() {
         final String fieldInfo;
         if (dateFormat != null) {
-            fieldInfo = "dateFormat: " + dateFormat.toString();
+            fieldInfo = "dateFormat: " + dateFormat;
         } else {
             fieldInfo = "locale: " + locale + ", formatString: " + formatString;
         }
index 871657411a0cf57aed78580f9e8b6346d206c79f..7a00fcc26c3ada75bdb121460e2bc3154be0aec0 100644 (file)
@@ -180,9 +180,9 @@ public class NumberRenderer extends AbstractRenderer<Number> {
         } else if (numberFormat != null) {
             stringValue = numberFormat.format(value);
         } else {
-            throw new IllegalStateException(String.format(
-                    "Internal bug: " + "%s is in an illegal state: "
-                            + "[locale: %s, numberFormat: %s, formatString: %s]",
+            throw new IllegalStateException(String.format("Internal bug: "
+                    + "%s is in an illegal state: "
+                    + "[locale: %s, numberFormat: %s, formatString: %s]",
                     getClass().getSimpleName(), locale, numberFormat,
                     formatString));
         }
@@ -193,7 +193,7 @@ public class NumberRenderer extends AbstractRenderer<Number> {
     public String toString() {
         final String fieldInfo;
         if (numberFormat != null) {
-            fieldInfo = "numberFormat: " + numberFormat.toString();
+            fieldInfo = "numberFormat: " + numberFormat;
         } else {
             fieldInfo = "locale: " + locale + ", formatString: " + formatString;
         }
index 9c14296476ae441ea5836dbeab5002238c851fb3..ab12cc9f7ba47c6ab6fe63051820a4ed989d142b 100644 (file)
@@ -27,7 +27,7 @@ public class FreeformQueryUtil {
                         QueryBuilder.getWhereStringForFilters(filters, sh));
             }
             query.append(") AS a WHERE a.rownum BETWEEN ").append(offset)
-                    .append(" AND ").append(Integer.toString(offset + limit));
+                    .append(" AND ").append(offset + limit);
             sh.setQueryString(query.toString());
             return sh;
         } else if (SQLTestsConstants.db == DB.ORACLE) {
index a01e8dadce84cd03dcdef3c88caf5b55fae12c6c..5d4458f28629889fe2c259d8fd9db0f0f0c6376e 100644 (file)
@@ -17,8 +17,6 @@ package com.vaadin.v7.tests.server.component.grid.declarative;
 
 import java.util.List;
 
-import org.junit.Assert;
-
 import com.vaadin.tests.design.DeclarativeTestBase;
 import com.vaadin.v7.ui.Grid;
 import com.vaadin.v7.ui.Grid.Column;
@@ -54,8 +52,8 @@ public class GridDeclarativeTestBase extends DeclarativeTestBase<Grid> {
     }
 
     private void compareHeaders(Grid expected, Grid actual) {
-        assertEquals("Different header row count",
-                expected.getHeaderRowCount(), actual.getHeaderRowCount());
+        assertEquals("Different header row count", expected.getHeaderRowCount(),
+                actual.getHeaderRowCount());
         for (int i = 0; i < expected.getHeaderRowCount(); ++i) {
             HeaderRow expectedRow = expected.getHeaderRow(i);
             HeaderRow actualRow = actual.getHeaderRow(i);
@@ -66,8 +64,8 @@ public class GridDeclarativeTestBase extends DeclarativeTestBase<Grid> {
             }
 
             for (Column c : expected.getColumns()) {
-                String baseError = "Difference when comparing cell for "
-                        + c.toString() + " on header row " + i + ": ";
+                String baseError = "Difference when comparing cell for " + c
+                        + " on header row " + i + ": ";
                 Object propertyId = c.getPropertyId();
                 HeaderCell expectedCell = expectedRow.getCell(propertyId);
                 HeaderCell actualCell = actualRow.getCell(propertyId);
@@ -92,15 +90,15 @@ public class GridDeclarativeTestBase extends DeclarativeTestBase<Grid> {
     }
 
     private void compareFooters(Grid expected, Grid actual) {
-        assertEquals("Different footer row count",
-                expected.getFooterRowCount(), actual.getFooterRowCount());
+        assertEquals("Different footer row count", expected.getFooterRowCount(),
+                actual.getFooterRowCount());
         for (int i = 0; i < expected.getFooterRowCount(); ++i) {
             FooterRow expectedRow = expected.getFooterRow(i);
             FooterRow actualRow = actual.getFooterRow(i);
 
             for (Column c : expected.getColumns()) {
-                String baseError = "Difference when comparing cell for "
-                        + c.toString() + " on footer row " + i + ": ";
+                String baseError = "Difference when comparing cell for " + c
+                        + " on footer row " + i + ": ";
                 Object propertyId = c.getPropertyId();
                 FooterCell expectedCell = expectedRow.getCell(propertyId);
                 FooterCell actualCell = actualRow.getCell(propertyId);
index b60cca189d1aeaae3c2ba71fae02f0d2ff6694ae..f10b246c5c1dfa8e5ded653cb4348aa4a8f8af3c 100644 (file)
@@ -166,7 +166,7 @@ public class AtmospherePushConnection implements PushConnection {
             try {
                 Writer writer = new StringWriter();
                 new UidlWriter().write(getUI(), writer, async);
-                sendMessage("for(;;);[{" + writer.toString() + "}]");
+                sendMessage("for(;;);[{" + writer + "}]");
             } catch (Exception e) {
                 throw new RuntimeException("Push failed", e);
             }
@@ -230,8 +230,8 @@ public class AtmospherePushConnection implements PushConnection {
 
     /**
      * Associates this {@link AtmospherePushConnection} with the given
-     * {@link AtmosphereResource} representing an established push connection. If
-     * already connected, calls {@link #disconnect()} first. If there is a
+     * {@link AtmosphereResource} representing an established push connection.
+     * If already connected, calls {@link #disconnect()} first. If there is a
      * deferred push, carries it out via the new connection.
      *
      * @since 7.2
index 428e436399bb2c34afe0254d288aef3d4d7d42a5..32bc3c8e1d52fedb08c78ce625d8ad843bb6fed7 100644 (file)
@@ -323,9 +323,8 @@ public abstract class AbstractSingleComponentContainer extends AbstractComponent
     protected void readDesignChildren(Elements children,
             DesignContext context) {
         if (children.size() > 1) {
-            throw new DesignException(
-                    "The container of type " + getClass().toString()
-                            + " can have only one child component.");
+            throw new DesignException("The container of type " + getClass()
+                    + " can have only one child component.");
         } else if (children.size() == 1) {
             setContent(context.readDesign(children.first()));
         }
index 00d735f83964c85d760e1e00dec097e955c2951b..6e03ed35e99f91f5e3500775a2ec5a01a202ec20 100644 (file)
@@ -704,7 +704,7 @@ public class ComboBox<T> extends AbstractSingleSelect<T>
 
     private void updateSelectedItemCaption() {
         String selectedCaption = null;
-        T value = getDataCommunicator().getKeyMapper().get(getSelectedKey());
+        T value = keyToItem(getSelectedKey());
         if (value != null) {
             selectedCaption = getItemCaptionGenerator().apply(value);
         }
@@ -713,7 +713,7 @@ public class ComboBox<T> extends AbstractSingleSelect<T>
 
     private void updateSelectedItemIcon() {
         String selectedItemIcon = null;
-        T value = getDataCommunicator().getKeyMapper().get(getSelectedKey());
+        T value = keyToItem(getSelectedKey());
         if (value != null) {
             Resource icon = getItemIconGenerator().apply(value);
             if (icon != null) {
@@ -772,9 +772,8 @@ public class ComboBox<T> extends AbstractSingleSelect<T>
                 ((DeclarativeStyleGenerator) styleGenerator).setStyle(item,
                         child.attr("style"));
             } else {
-                throw new IllegalStateException(String.format(
-                        "Don't know how "
-                                + "to set style using current style generator '%s'",
+                throw new IllegalStateException(String.format("Don't know how "
+                        + "to set style using current style generator '%s'",
                         styleGenerator.getClass().getName()));
             }
         }
index a80e8f172936d0d94eae70f0e0b603eb61eb7c86..993a6d3411fab636fc7e26b5391ed6cee06a9762 100644 (file)
@@ -2540,9 +2540,9 @@ public class Grid<T> extends AbstractListing<T> implements HasComponents,
 
         if (!renderer.getPresentationType()
                 .isAssignableFrom(definition.getType())) {
-            throw new IllegalArgumentException(renderer.toString()
-                    + " cannot be used with a property of type "
-                    + definition.getType().getName());
+            throw new IllegalArgumentException(
+                    renderer + " cannot be used with a property of type "
+                            + definition.getType().getName());
         }
 
         @SuppressWarnings({ "unchecked", "rawtypes" })
@@ -4259,7 +4259,7 @@ public class Grid<T> extends AbstractListing<T> implements HasComponents,
     protected T deserializeDeclarativeRepresentation(String item) {
         if (item == null) {
             return super.deserializeDeclarativeRepresentation(
-                    new String(UUID.randomUUID().toString()));
+                    UUID.randomUUID().toString());
         }
         return super.deserializeDeclarativeRepresentation(new String(item));
     }
index ae02df9c702a97ee4c78506c84ae096cc9a79b20..db659a5229e35b8849dc731d736f966e707b113b 100644 (file)
@@ -544,8 +544,7 @@ public abstract class UI extends AbstractSingleComponentContainer
         if (session == null) {
             return null;
         } else {
-            return session.toString() + " for "
-                    + session.getService().getServiceName();
+            return session + " for " + session.getService().getServiceName();
         }
     }
 
index 61510dfee6dbb3ab77d3c82c79d4de6d83dc69fe..86f82c5abd37dd585c06d65536554b1102447160 100644 (file)
@@ -402,8 +402,8 @@ public class DesignContext implements Serializable {
                         String contentString = attributes.get("content");
                         String[] parts = contentString.split(":");
                         if (parts.length != 2) {
-                            throw new DesignException("The meta tag '"
-                                    + child.toString() + "' cannot be parsed.");
+                            throw new DesignException("The meta tag '" + child
+                                    + "' cannot be parsed.");
                         }
                         String prefixName = parts[0];
                         String packageName = parts[1];
index f1a4fcde23502e79b9f203c6a5075cb20fe30cfe..d3d2b131704f602662003d13d92e4746e911afd6 100644 (file)
@@ -47,8 +47,9 @@ import com.vaadin.ui.declarative.DesignAttributeHandler;
 @SuppressWarnings("serial")
 public class DesignResourceConverter implements Converter<String, Resource> {
 
-    private static final Map<Integer, VaadinIcons> CODE_POINTS =
-            Arrays.stream(VaadinIcons.values()).collect(Collectors.toMap(VaadinIcons::getCodepoint, icon -> icon));
+    private static final Map<Integer, VaadinIcons> CODE_POINTS = Arrays
+            .stream(VaadinIcons.values())
+            .collect(Collectors.toMap(VaadinIcons::getCodepoint, icon -> icon));
 
     @Override
     public Result<Resource> convertToModel(String value, ValueContext context) {
@@ -115,7 +116,9 @@ public class DesignResourceConverter implements Converter<String, Resource> {
                     return CODE_POINTS.get(codepoint);
                 }
 
-                if (FontAwesome.FONT_FAMILY.equals(familyAndCode[0])) { //Left for compatibility
+                if (FontAwesome.FONT_FAMILY.equals(familyAndCode[0])) { // Left
+                                                                        // for
+                                                                        // compatibility
                     return FontAwesome.fromCodepoint(codepoint);
                 }
                 // all vaadin icons should have a codepoint
@@ -144,9 +147,8 @@ public class DesignResourceConverter implements Converter<String, Resource> {
 
             @Override
             public String format(Resource value) {
-                throw new UnsupportedOperationException(
-                        "Use " + ResourceConverterByProtocol.FONTICON.toString()
-                                + " instead");
+                throw new UnsupportedOperationException("Use "
+                        + ResourceConverterByProtocol.FONTICON + " instead");
             }
         },
         FILE {
@@ -168,7 +170,8 @@ public class DesignResourceConverter implements Converter<String, Resource> {
 
         };
 
-        public static final String VAADIN_ICONS_NAME = VaadinIcons.ABACUS.getFontFamily();
+        public static final String VAADIN_ICONS_NAME = VaadinIcons.ABACUS
+                .getFontFamily();
 
         @Override
         public Resource parse(String value) {
index 484f88e882bfdc08012ee70b611ef9437ad1308c..1971540cb279c42b1a1dcae37b55bf52eeb8eb0e 100644 (file)
@@ -230,7 +230,7 @@ public class DateRenderer extends AbstractRenderer<Object, Date> {
     public String toString() {
         final String fieldInfo;
         if (dateFormat != null) {
-            fieldInfo = "dateFormat: " + dateFormat.toString();
+            fieldInfo = "dateFormat: " + dateFormat;
         } else {
             fieldInfo = "locale: " + locale + ", formatString: " + formatString;
         }
index 17730901ffcf67fd1d39e8462a3ec257dc10fedf..8e00c44ebd53070b1235552dd087b6ccfef9f0fe 100644 (file)
@@ -179,9 +179,9 @@ public class NumberRenderer extends AbstractRenderer<Object, Number> {
         } else if (numberFormat != null) {
             stringValue = numberFormat.format(value);
         } else {
-            throw new IllegalStateException(String.format(
-                    "Internal bug: " + "%s is in an illegal state: "
-                            + "[locale: %s, numberFormat: %s, formatString: %s]",
+            throw new IllegalStateException(String.format("Internal bug: "
+                    + "%s is in an illegal state: "
+                    + "[locale: %s, numberFormat: %s, formatString: %s]",
                     getClass().getSimpleName(), locale, numberFormat,
                     formatString));
         }
@@ -192,7 +192,7 @@ public class NumberRenderer extends AbstractRenderer<Object, Number> {
     public String toString() {
         final String fieldInfo;
         if (numberFormat != null) {
-            fieldInfo = "numberFormat: " + numberFormat.toString();
+            fieldInfo = "numberFormat: " + numberFormat;
         } else {
             fieldInfo = "locale: " + locale + ", formatString: " + formatString;
         }
index b91a6fe3afa7c11314b72add81e299d00aa3c38e..da4505432501ef033dbb656b26ffb3deb2b66380 100644 (file)
@@ -47,7 +47,7 @@ public class BackendDataProviderTest extends
                 }
                 List<StrBean> list = stream.skip(query.getOffset())
                         .limit(query.getLimit()).collect(Collectors.toList());
-                list.forEach(s -> System.err.println(s.toString()));
+                list.forEach(s -> System.err.println(s));
                 return list.stream();
             }, query -> (int) data.stream()
                     .filter(t -> query.getFilter().orElse(s -> true).test(t))
@@ -66,4 +66,4 @@ public class BackendDataProviderTest extends
         getDataProvider().setSortOrders(sortOrder);
     }
 
-}
\ No newline at end of file
+}
index c15f713f531e28fe286e6ce32816eb2f171a85b3..95e961df52ea13e9ba3b12c7a74bb5dbfd4f7f63 100644 (file)
@@ -2,7 +2,7 @@ package com.vaadin.data.provider.hierarchical;
 
 import java.io.Serializable;
 
-public class Node implements Serializable{
+public class Node implements Serializable {
 
     private static int counter = 0;
 
@@ -27,7 +27,6 @@ public class Node implements Serializable{
     }
 
     public String toString() {
-        return number + (parent != null ? " [parent: " + parent.toString() + "]"
-                : "");
+        return number + (parent != null ? " [parent: " + parent + "]" : "");
     }
 }
index 97689033d58a9cfa31943f3b3e8c3f343c43855c..4c0f5ab524a398f5e28bb4cc1e386a02a45ee1ef 100644 (file)
@@ -304,8 +304,7 @@ public class ApplicationRunnerServlet extends LegacyVaadinServlet {
      *         context, runner, application classname
      */
     private static URIS getApplicationRunnerURIs(HttpServletRequest request) {
-        final String[] urlParts = request.getRequestURI().toString()
-                .split("\\/");
+        final String[] urlParts = request.getRequestURI().split("\\/");
         // String runner = null;
         URIS uris = new URIS();
         String applicationClassname = null;
index 7599522c38e0fb0c3a334bc3135b416991b96c8d..695bc7f1994a59e058885b58b04d4791d1fc7d38 100644 (file)
@@ -468,7 +468,7 @@ public class DevelopmentServerLauncher {
 
             System.out.println(thread.getName() + " - " + thread.getState());
             for (StackTraceElement stackTraceElement : stackTraceElements) {
-                System.out.println("    at " + stackTraceElement.toString());
+                System.out.println("    at " + stackTraceElement);
             }
             System.out.println();
         }
index ff0bbf7acb65233e7b1ce0867811366883ed9c0e..b9eaf16271bddefeb381b1941af1c98538899bc1 100644 (file)
@@ -126,7 +126,7 @@ public class CustomLayoutDemo extends com.vaadin.server.LegacyApplication
     public void loginClicked() {
         username.setVisible(false);
         loginPwd.setVisible(false);
-        if (username.getValue().toString().length() < 1) {
+        if (username.getValue().length() < 1) {
             username.setValue("Anonymous");
         }
         mainLayout.replaceComponent(loginButton,
index c483b4e6b36eacf370df25a971077f260c82df3a..397913dc9aff348b545cdc17a491e129a18b55ed 100644 (file)
@@ -70,8 +70,7 @@ public class Parameters extends com.vaadin.server.LegacyApplication
             layout.addComponent(
                     new Link(u2.toString(), new ExternalResource(u2)));
         } catch (final Exception e) {
-            System.out.println(
-                    "Couldn't get hostname for this machine: " + e.toString());
+            System.out.println("Couldn't get hostname for this machine: " + e);
             e.printStackTrace();
         }
 
index 9403b5a82e6846cbab2237c1da2e0d39f9ef4e1e..229b3352c95f5a65fe945de3f6965c816124d8d2 100644 (file)
@@ -52,8 +52,8 @@ public class StressComponentsInTable extends CustomComponent {
                 @Override
                 public void buttonClick(ClickEvent event) {
                     Button b = event.getButton();
-                    System.out.println(b.getCaption() + " click: "
-                            + (new Date()).toString());
+                    System.out
+                            .println(b.getCaption() + " click: " + new Date());
                     System.out.println(b.getUI().getSession());
 
                 }
@@ -64,19 +64,19 @@ public class StressComponentsInTable extends CustomComponent {
         return t;
     }
 
-    static String[] testString = { "Jacob", "Michael", "Joshua",
-            "Matthew", "Ethan", "Andrew", "Daniel", "Anthony", "Christopher",
-            "Joseph", "William", "Alexander", "Ryan", "David", "Nicholas",
-            "Tyler", "James", "John", "Jonathan", "Nathan", "Samuel",
-            "Christian", "Noah", "Dylan", "Benjamin", "Logan", "Brandon",
-            "Gabriel", "Zachary", "Jose", "Elijah", "Angel", "Kevin", "Jack",
-            "Caleb", "Justin", "Austin", "Evan", "Robert", "Thomas", "Luke",
-            "Mason", "Aidan", "Jackson", "Isaiah", "Jordan", "Gavin", "Connor",
-            "Aiden", "Isaac", "Jason", "Cameron", "Hunter", "Jayden", "Juan",
-            "Charles", "Aaron", "Lucas", "Luis", "Owen", "Landon", "Diego",
-            "Brian", "Adam", "Adrian", "Kyle", "Eric", "Ian", "Nathaniel",
-            "Carlos", "Alex", "Bryan", "Jesus", "Julian", "Sean", "Carter",
-            "Hayden", "Jeremiah", "Cole", "Brayden", "Wyatt", "Chase", "Steven",
+    static String[] testString = { "Jacob", "Michael", "Joshua", "Matthew",
+            "Ethan", "Andrew", "Daniel", "Anthony", "Christopher", "Joseph",
+            "William", "Alexander", "Ryan", "David", "Nicholas", "Tyler",
+            "James", "John", "Jonathan", "Nathan", "Samuel", "Christian",
+            "Noah", "Dylan", "Benjamin", "Logan", "Brandon", "Gabriel",
+            "Zachary", "Jose", "Elijah", "Angel", "Kevin", "Jack", "Caleb",
+            "Justin", "Austin", "Evan", "Robert", "Thomas", "Luke", "Mason",
+            "Aidan", "Jackson", "Isaiah", "Jordan", "Gavin", "Connor", "Aiden",
+            "Isaac", "Jason", "Cameron", "Hunter", "Jayden", "Juan", "Charles",
+            "Aaron", "Lucas", "Luis", "Owen", "Landon", "Diego", "Brian",
+            "Adam", "Adrian", "Kyle", "Eric", "Ian", "Nathaniel", "Carlos",
+            "Alex", "Bryan", "Jesus", "Julian", "Sean", "Carter", "Hayden",
+            "Jeremiah", "Cole", "Brayden", "Wyatt", "Chase", "Steven",
             "Timothy", "Dominic", "Sebastian", "Xavier", "Jaden", "Jesse",
             "Devin", "Seth", "Antonio", "Richard", "Miguel", "Colin", "Cody",
             "Alejandro", "Caden", "Blake", "Carson" };
index c29e46e9d3edcecafd0ea4913e500922e038a73c..b7b8c9317772287312319227f188c082655bc6fc 100644 (file)
@@ -226,8 +226,7 @@ public class TestBench extends com.vaadin.server.LegacyApplication
                 e1.printStackTrace();
                 VerticalLayout lo = new VerticalLayout();
                 lo.addComponent(new Label(
-                        "Cannot create application / custom component: "
-                                + e1.toString()));
+                        "Cannot create application / custom component: " + e1));
 
                 Link l = new Link("Try opening via app runner",
                         new ExternalResource("../run/" + c.getName()));
index 9a63d7a82317cdb38092fb2541a408aaacb288c5..37a5c85d98353c246e731bc772e28c2c1653ae9f 100644 (file)
@@ -216,7 +216,7 @@ public class TestCaptionWrapper extends CustomComponent implements Listener {
     @Override
     public void componentEvent(Event event) {
         final String feedback = eventListenerString + " source="
-                + event.getSource() + ", toString()=" + event.toString();
+                + event.getSource() + ", toString()=" + event;
         System.out.println("eventListenerFeedback: " + feedback);
         eventListenerFeedback.setValue(feedback);
     }
index 3f5a44f61ada3c4b5aa24117b38934e64f80eb00..570b8b126c432c2373a93c2ab27635559188d202 100644 (file)
@@ -103,7 +103,7 @@ public class TreeFilesystem extends com.vaadin.server.LegacyApplication
         for (int x = 0; x < files.length; x++) {
             try {
                 // add new item (String) to tree
-                final String path = files[x].getCanonicalPath().toString();
+                final String path = files[x].getCanonicalPath();
                 tree.addItem(path);
                 // set parent if this item has one
                 if (parent != null) {
index dccfbaa1e1116f89fa8aace0173cc7213909ff91..f818f4b6ad2e1d8b171167abae3d4d6040caaee7 100644 (file)
@@ -54,13 +54,13 @@ public class UsingCustomNewItemHandlerInSelect extends CustomComponent {
     }
 
     public void populateSelect() {
-        final String[] names = { "John", "Mary", "Joe", "Sarah",
-                "Jeff", "Jane", "Peter", "Marc", "Josie", "Linus" };
+        final String[] names = { "John", "Mary", "Joe", "Sarah", "Jeff", "Jane",
+                "Peter", "Marc", "Josie", "Linus" };
         for (int j = 0; j < 4; j++) {
             Integer id = new Integer(sequence++);
             Item item = select.addItem(id);
-            item.getItemProperty("CAPTION").setValue(id.toString() + ": "
-                    + names[random.nextInt() % names.length]);
+            item.getItemProperty("CAPTION").setValue(
+                    id + ": " + names[random.nextInt() % names.length]);
         }
     }
 
@@ -71,7 +71,7 @@ public class UsingCustomNewItemHandlerInSelect extends CustomComponent {
             Integer id = new Integer(sequence++);
             Item item = select.addItem(id);
             item.getItemProperty("CAPTION")
-                    .setValue(id.toString() + ": " + newItemCaption);
+                    .setValue(id + ": " + newItemCaption);
             select.setValue(id);
         }
 
index f5af00234c8c2029cb265fc4e7f348c687fc3c3f..4b24f08eb0682e220f65ad54fee3c698d08807d9 100644 (file)
@@ -82,8 +82,7 @@ public class VaadinClasses {
             try {
                 File f = new File(location.toURI());
                 if (!f.exists()) {
-                    throw new IOException(
-                            "Directory " + f.toString() + " does not exist");
+                    throw new IOException("Directory " + f + " does not exist");
                 }
                 findPackages(f, basePackage, baseClass, classes,
                         ignoredPackages);
index 7558771969e2a4c953fd287770585daf57ca5534..9718fac860fffc13a0522bac2c0252212642dedb 100644 (file)
@@ -145,7 +145,7 @@ public abstract class AbstractFieldTest<T extends AbstractField<V>, V>
                         Locale.ENGLISH);
                 value = format.format(date);
             } else {
-                value = "'" + o.toString() + "'";
+                value = "'" + o + "'";
             }
         }
 
index 18ecfaf53b397a68749d671a0f70b83599369a79..c2617dafba8324596b7c04d366e080acbab4fc8a 100644 (file)
@@ -174,7 +174,7 @@ public abstract class LegacyAbstractFieldTest<T extends AbstractField>
                         new Locale("en", "US"));
                 value = format.format(d);
             } else {
-                value = "'" + o.toString() + "'";
+                value = "'" + o + "'";
             }
         }
 
index 918459dfde77ab98d9a0e3b936bd5953b41cd3bb..38859497fc622820408927c0e73d1f23af971814 100644 (file)
@@ -14,7 +14,7 @@ public class Vaadin6ImplicitDoubleConverter
         if (null == value) {
             return null;
         }
-        return new Double(value.toString());
+        return new Double(value);
     }
 
     @Override
index c405a2af524fd47434d78847c6e179fa3bed6979..4b27d4fee5d57520f3f9926a226a4fe9c8a5f192 100644 (file)
@@ -25,8 +25,7 @@ public abstract class AbstractMultiSelectTestUI<MULTISELECT extends AbstractMult
         LinkedHashMap<String, ItemCaptionGenerator<Object>> options = new LinkedHashMap<>();
         options.put("Null Caption Generator", item -> null);
         options.put("Default Caption Generator", item -> item.toString());
-        options.put("Custom Caption Generator",
-                item -> item.toString() + " Caption");
+        options.put("Custom Caption Generator", item -> item + " Caption");
 
         createSelectAction("Item Caption Generator", "Item Generator", options,
                 "None", (abstractMultiSelect, captionGenerator, data) -> {
index 3aa6ab45e19f24715837cefe5235e65ade8c14ec..78c82f80e2e9f42d231a0596e2d2721a967f44c3 100644 (file)
@@ -16,7 +16,7 @@ public class ButtonMouseDetails extends TestBase {
 
         @Override
         public void buttonClick(ClickEvent event) {
-            StringBuilder str = new StringBuilder(out.getValue().toString());
+            StringBuilder str = new StringBuilder(out.getValue());
             str.append(clickCounter + ":\t");
 
             // Modifier keys
index 71c3a6147f5aac0d760a628e041965253c78dfde..f69bf26a3dec8523898bcd4183f78da13ae371e7 100644 (file)
@@ -65,7 +65,7 @@ public class CheckBoxGroupTestUI
         options.put("Null Description Generator", item -> null);
         options.put("Default Description Generator", item -> item.toString());
         options.put("Custom Description Generator",
-                item -> item.toString() + " Description");
+                item -> item + " Description");
 
         createSelectAction("Item Description Generator",
                 "Item Description Generator", options, "None",
index be2ce6c67e59587d23845261dd53acaff1662c23..847ec1a280a1b1efb439d0f5b6e1e092bc1226bf 100644 (file)
@@ -23,12 +23,12 @@ public class ComboBoxBackEndRequests extends AbstractTestUI {
         int pageLength = DEFAULT_PAGE_LENGTH;
         int items = DEFAULT_NUMBER_OF_ITEMS;
         if (request.getParameter(PAGE_LENGTH_REQUEST_PARAMETER) != null) {
-            pageLength = Integer.parseInt(request
-                    .getParameter(PAGE_LENGTH_REQUEST_PARAMETER).toString());
+            pageLength = Integer.parseInt(
+                    request.getParameter(PAGE_LENGTH_REQUEST_PARAMETER));
         }
         if (request.getParameter(ITEMS_REQUEST_PARAMETER) != null) {
-            items = Integer.parseInt(
-                    request.getParameter(ITEMS_REQUEST_PARAMETER).toString());
+            items = Integer
+                    .parseInt(request.getParameter(ITEMS_REQUEST_PARAMETER));
         }
 
         ComboBox<String> cb = new ComboBox<>();
index 8679ed7785e29965fdb7abddc9647f29ffd4d66e..415bfe8a04cf952978a7c1ce17ebf16d86b18263 100644 (file)
@@ -24,14 +24,12 @@ public class ComboFocusBlurEvents extends TestBase {
         final ObjectProperty<String> log = new ObjectProperty<>("");
 
         cb.addFocusListener(event -> {
-            log.setValue(log.getValue().toString() + "<br>" + counter
-                    + ": Focus event!");
+            log.setValue(log.getValue() + "<br>" + counter + ": Focus event!");
             counter++;
         });
 
         cb.addBlurListener(event -> {
-            log.setValue(log.getValue().toString() + "<br>" + counter
-                    + ": Blur event!");
+            log.setValue(log.getValue() + "<br>" + counter + ": Blur event!");
             counter++;
         });
 
index 18ac8ca8becfd023d65d237571f174f3ec200976..c919ca78227332b19af1b9130bb37ae86792b952 100644 (file)
@@ -42,8 +42,8 @@ public class ComboPushTiming extends TestBase {
         cb.addFocusListener(new FieldEvents.FocusListener() {
             @Override
             public void focus(FocusEvent event) {
-                log.setValue(log.getValue().toString() + "<br>" + counter
-                        + ": Focus event!");
+                log.setValue(
+                        log.getValue() + "<br>" + counter + ": Focus event!");
                 counter++;
                 changeValue(cb);
             }
@@ -52,8 +52,8 @@ public class ComboPushTiming extends TestBase {
         cb.addBlurListener(new FieldEvents.BlurListener() {
             @Override
             public void blur(BlurEvent event) {
-                log.setValue(log.getValue().toString() + "<br>" + counter
-                        + ": Blur event!");
+                log.setValue(
+                        log.getValue() + "<br>" + counter + ": Blur event!");
                 counter++;
             }
         });
index daae32327a18f04538fc316d40517264fd21ce4f..5e8db6f14cf625aa7391c0e08f3625a3a4cc8c09 100644 (file)
@@ -13,8 +13,8 @@ import com.vaadin.ui.DateField;
 @SuppressWarnings("serial")
 public class DateFields extends ComponentTestCase<DateField> {
 
-    private static final Locale[] LOCALES = { Locale.US,
-            Locale.TAIWAN, new Locale("fi", "FI") };
+    private static final Locale[] LOCALES = { Locale.US, Locale.TAIWAN,
+            new Locale("fi", "FI") };
 
     @Override
     protected Class<DateField> getTestClass() {
@@ -27,14 +27,14 @@ public class DateFields extends ComponentTestCase<DateField> {
         for (Locale locale : LOCALES) {
             DateField pd = createPopupDateField("Undefined width", "-1",
                     locale);
-            pd.setId("Locale-" + locale.toString() + "-undefined-wide");
+            pd.setId("Locale-" + locale + "-undefined-wide");
             addTestComponent(pd);
             pd = createPopupDateField("500px width", "500px", locale);
-            pd.setId("Locale-" + locale.toString() + "-500px-wide");
+            pd.setId("Locale-" + locale + "-500px-wide");
             addTestComponent(pd);
             pd = createPopupDateField("Initially empty", "", locale);
             pd.setValue(null);
-            pd.setId("Locale-" + locale.toString() + "-initially-empty");
+            pd.setId("Locale-" + locale + "-initially-empty");
             addTestComponent(pd);
         }
 
@@ -42,7 +42,7 @@ public class DateFields extends ComponentTestCase<DateField> {
 
     private DateField createPopupDateField(String caption, String width,
             Locale locale) {
-        DateField pd = new DateField(caption + "(" + locale.toString() + ")");
+        DateField pd = new DateField(caption + "(" + locale + ")");
         pd.setWidth(width);
         pd.setValue(LocalDate.of(1970, 05, 23));
         pd.setLocale(locale);
index 02da061d0814137b1a5606584738b9fb4e124329..172c796ecf962b593f909ec2e9431f00cce67c88 100644 (file)
@@ -13,8 +13,8 @@ import com.vaadin.ui.InlineDateField;
 @SuppressWarnings("serial")
 public class InlineDateFields extends ComponentTestCase<InlineDateField> {
 
-    private static final Locale[] LOCALES = { Locale.US,
-            Locale.TAIWAN, new Locale("fi", "FI") };
+    private static final Locale[] LOCALES = { Locale.US, Locale.TAIWAN,
+            new Locale("fi", "FI") };
 
     @Override
     protected Class<InlineDateField> getTestClass() {
@@ -32,22 +32,21 @@ public class InlineDateFields extends ComponentTestCase<InlineDateField> {
 
         InlineDateField pd = createInlineDateField("Undefined width", "-1",
                 locale);
-        pd.setId("Locale-" + locale.toString() + "-undefined-wide");
+        pd.setId("Locale-" + locale + "-undefined-wide");
         addTestComponent(pd);
         pd = createInlineDateField("300px width", "300px", locale);
-        pd.setId("Locale-" + locale.toString() + "-300px-wide");
+        pd.setId("Locale-" + locale + "-300px-wide");
         addTestComponent(pd);
         pd = createInlineDateField("Initially empty", "", locale);
         pd.setValue(null);
-        pd.setId("Locale-" + locale.toString() + "-initially-empty");
+        pd.setId("Locale-" + locale + "-initially-empty");
         addTestComponent(pd);
 
     }
 
     private InlineDateField createInlineDateField(String caption, String width,
             Locale locale) {
-        InlineDateField pd = new InlineDateField(
-                caption + "(" + locale.toString() + ")");
+        InlineDateField pd = new InlineDateField(caption + "(" + locale + ")");
         pd.setWidth(width);
         pd.setValue(LocalDate.of(1970, 05, 23));
         pd.setLocale(locale);
index c9144e52f061c273158450fcc7309f2063f3f963..85ab5ab5770f9199240a776f1add9fda58a00167 100644 (file)
@@ -91,7 +91,7 @@ public class GridBasics extends AbstractTestUIWithLog {
                     }
                     log("Columns reordered, userOriginated: "
                             + event.isUserOriginated());
-                    log("Column order: " + columnCaptions.toString());
+                    log("Column order: " + columnCaptions);
                 });
                 log("Registered a column reorder listener.");
             }
index 48f168803bf954baa58155f89a599342b4dc92f7..86ff1f3ffbaf6ac45f21bd43d042bc9312ffb4fa 100644 (file)
@@ -53,7 +53,7 @@ public class OptionGroups extends AbstractSelectTestCase<OptionGroup> {
 
     private void createDisabledItemsMultiToggle(String category) {
         for (Object id : getComponent().getItemIds()) {
-            createBooleanAction(id.toString() + " - enabled", category, true,
+            createBooleanAction(id + " - enabled", category, true,
                     enabledItemCommand, id);
         }
     }
index d9161a6a46e7224900eeadb65ea024b82a34cc55..dbbe8d6ddc133fb68cc04bf8bb7f9c7816991044 100644 (file)
@@ -84,8 +84,7 @@ public class RadioButtonGroupTestUI
         LinkedHashMap<String, ItemCaptionGenerator<Object>> options = new LinkedHashMap<>();
         options.put("Null Caption Generator", item -> null);
         options.put("Default Caption Generator", item -> item.toString());
-        options.put("Custom Caption Generator",
-                item -> item.toString() + " Caption");
+        options.put("Custom Caption Generator", item -> item + " Caption");
 
         createSelectAction("Item Caption Generator", "Item Caption Generator",
                 options, "None", (radioButtonGroup, captionGenerator, data) -> {
@@ -99,7 +98,7 @@ public class RadioButtonGroupTestUI
         options.put("Null Description Generator", item -> null);
         options.put("Default Description Generator", item -> item.toString());
         options.put("Custom Description Generator",
-                item -> item.toString() + " Description");
+                item -> item + " Description");
 
         createSelectAction("Item Description Generator",
                 "Item Description Generator", options, "None",
index 428b125a8b60ce1df8f0f1fc65a38b0e9dc42d9d..290961e9ecc486746eb48317da9043094878a639 100644 (file)
@@ -31,7 +31,7 @@ public class RichTextAreaWithKeyboardShortcuts extends TestBase {
             msg += " Target:" + target.getClass().getSimpleName() + " '"
                     + f.getCaption() + "'";
 
-            String string = f.getValue().toString();
+            String string = f.getValue();
 
             msg += " Value: " + string;
             Notification notification = new Notification(msg);
index d6d4fc85b032e6c9e6933fd902147fb152bac44d..68ed142a838071296d771c2dafdf58cc0815981e 100644 (file)
@@ -34,7 +34,7 @@ public class ColumnReorderEvent extends TestBase {
     private String aToString(Object[] visibleColumns) {
         StringBuilder sb = new StringBuilder();
         for (Object object : visibleColumns) {
-            sb.append(object.toString());
+            sb.append(object);
             sb.append(" | ");
         }
         return sb.toString();
index dcc83878bf9bde76b7187da33e6c0a9448c1e509..55e97c5a317744148831aeefe51685d3344f79c2 100644 (file)
@@ -45,8 +45,7 @@ public class KeyControl extends TestBase {
             public void valueChange(ValueChangeEvent event) {
                 @SuppressWarnings("unchecked")
                 Set<String> value = (Set<String>) table1.getValue();
-                selected1
-                        .setValue(value.toString() + " TOTAL: " + value.size());
+                selected1.setValue(value + " TOTAL: " + value.size());
             }
         });
 
index 3fd15ecdccecec7c50ec6c757c972890ed30cf79..dd6a088b1a96edecf1594e412ceddb02262a3a43 100644 (file)
@@ -64,7 +64,7 @@ public class ScrollCursor extends TestBase {
 
             @Override
             public void buttonClick(ClickEvent event) {
-                position = textArea.getValue().toString().length();
+                position = textArea.getValue().length();
             }
         });
 
index 6329d6fdd0fb9e36a7c5a364d4c7ada935d23c68..d66dd4641cfcf947ca700f0c44c809c4da90e3a5 100644 (file)
@@ -66,13 +66,11 @@ public class TextFieldFocusAndBlurListeners extends TestBase
     @Override
     public void blur(BlurEvent event) {
         TextField tf = (TextField) event.getComponent();
-        log.log(tf.getCaption() + ": Blur. Value is: "
-                + tf.getValue().toString());
+        log.log(tf.getCaption() + ": Blur. Value is: " + tf.getValue());
 
     }
 
     public void valueChange(TextField source) {
-        log.log(source.getCaption() + ": ValueChange: "
-                + source.getValue().toString());
+        log.log(source.getCaption() + ": ValueChange: " + source.getValue());
     }
 }
index 962bcb95ca75780272baf0881edb9c4f8dcb6709..d72e5f24af66cf084ce92a0f6b302152afe66767 100644 (file)
@@ -40,7 +40,7 @@ public class PushStateAndReplaceState extends AbstractReindeerTestUI {
         addComponent(replace);
 
         addComponent(createButton("test", "Move to ./test",
-                Page.getCurrent().getLocation().toString() + "/test"));
+                Page.getCurrent().getLocation() + "/test"));
         addComponent(createButton("X", "Move to X", "X"));
         addComponent(createButton("root_X", "Move to /X", "/X"));
     }
@@ -67,7 +67,7 @@ public class PushStateAndReplaceState extends AbstractReindeerTestUI {
 
     private void updateLabel() {
         URI location = getPage().getLocation();
-        locationLabel.setValue("Current Location: " + location.toString());
+        locationLabel.setValue("Current Location: " + location);
     }
 
     @Override
index 74f0bb2f2181b1df14c4389117933dd874d6967d..a31eb519b6a57591868d162c52cd250ab58b61e0 100644 (file)
@@ -32,7 +32,7 @@ public class RpcInvocationHandlerToString extends AbstractTestUIWithLog {
 
                     @Override
                     public void buttonClick(ClickEvent event) {
-                        log("An invoation proxy: " + dummyProxy.toString());
+                        log("An invoation proxy: " + dummyProxy);
                     }
                 });
         addButton("Exec hashCode() for an invocation proxy",
index 983a30a8d28fc73799d493d5e2dfb7526ca66866..dfb1ce155f87f202aa8768faae70c5a79d9ae771 100644 (file)
@@ -45,7 +45,7 @@ public class ShortcutInWindow extends AbstractTestUIWithLog {
             ValueChangeMode m = ValueChangeMode.values()[i];
             toggle.setCaption(m.toString());
             name.setValueChangeMode(m);
-            log("New ValueChangeMode: " + m.toString());
+            log("New ValueChangeMode: " + m);
         });
         final Button submit = new Button("Submit",
                 (e) -> log("Submitted value: " + name.getValue()));
index d1e25442576dde0bda4b9900bf7c7d7f8a68c679..9141665a94e8d4320b0d8e498418243e551ea206 100644 (file)
@@ -89,7 +89,7 @@ public class BeanItemContainerFilteringTest extends TestBase {
                 container.removeAllContainerFilters();
                 if (event.getValue()) {
                     container.addContainerFilter("value",
-                            filterString.getValue().toString(), false, false);
+                            filterString.getValue(), false, false);
                 }
             });
             vl.addComponent(cb);
@@ -143,8 +143,7 @@ public class BeanItemContainerFilteringTest extends TestBase {
                     new Button.ClickListener() {
                         @Override
                         public void buttonClick(ClickEvent event) {
-                            int index = Integer
-                                    .parseInt(position.getValue().toString());
+                            int index = Integer.parseInt(position.getValue());
                             TestBean bean = new TestBean(
                                     "addItemAt() " + nextToAdd,
                                     "value " + nextToAdd);
index ceaca59143188c783f2c125b8a187137e489829b..d020d53ad8e61eefeee9844c63cb922ada1726be 100644 (file)
@@ -55,8 +55,8 @@ public class IndexedContainerFilteringTest extends TestBase {
         cb.addValueChangeListener(event -> {
             container.removeAllContainerFilters();
             if (event.getValue()) {
-                container.addContainerFilter("column1",
-                        filterString.getValue().toString(), false, false);
+                container.addContainerFilter("column1", filterString.getValue(),
+                        false, false);
             }
         });
         vl.addComponent(cb);
@@ -113,8 +113,7 @@ public class IndexedContainerFilteringTest extends TestBase {
                 new Button.ClickListener() {
                     @Override
                     public void buttonClick(ClickEvent event) {
-                        int index = Integer
-                                .parseInt(position.getValue().toString());
+                        int index = Integer.parseInt(position.getValue());
                         String id = "addItemAt() " + nextToAdd;
                         Item item = container.addItemAt(index, id);
                         if (item != null) {
index 624461a5368209d7abb1cddd7057dd4079024c39..fc215c39519c91c7d7ebfd25995c8cb2bc58bb45 100644 (file)
@@ -38,9 +38,7 @@ public class DragImage extends AbstractTestUIWithLog {
 
             layout1.addComponents(label, new Label("spacer"));
 
-            styles.add(new StringBuilder(".").append(position)
-                    .append(" { position: ").append(position).append(";}")
-                    .toString());
+            styles.add("." + position + " { position: " + position + ";}");
         });
 
         HorizontalLayout layout2 = new HorizontalLayout();
@@ -52,9 +50,7 @@ public class DragImage extends AbstractTestUIWithLog {
                     .setDragImage(new ThemeResource(TestSampler.ICON_URL));
             layout2.addComponents(label, new Label("spacer"));
 
-            styles.add(new StringBuilder(".").append(position)
-                    .append(" { position: ").append(position).append(";}")
-                    .toString());
+            styles.add("." + position + " { position: " + position + ";}");
         });
 
         // #9261 grid row like element that safari can't show the drag image for
index 7a51c201d622fd9df726b9d24c9801702778d5de..b2d871cf9a31153cb332bb39256490824cc49bf5 100644 (file)
@@ -547,7 +547,7 @@ public class OrderedLayoutBasics extends TestBase {
         // AlignmentHandler.ALIGNMENT_HORIZONTAL_CENTER, valign[i % 3]);
         // }
         //
-        // tf.setValue(tf.getValue().toString() + " (100% wide)");
+        // tf.setValue(tf.getValue() + " (100% wide)");
         // tf.setWidth("100%");
 
         // tf = new TextField("100%x70px Field");
@@ -640,7 +640,7 @@ public class OrderedLayoutBasics extends TestBase {
         // AlignmentHandler.ALIGNMENT_HORIZONTAL_CENTER, valign[i % 3]);
         // }
         //
-        // tf.setValue(tf.getValue().toString() + " (100% wide)");
+        // tf.setValue(tf.getValue() + " (100% wide)");
         // tf.setWidth("100%");
 
         // tf = new TextField("100%x70px Field");
index e9f8182e7fdda9fa6545f94a88e0102cd066c781..f3c17b8a2941f676bc86e61fc25e5fbc5440bd70 100644 (file)
@@ -170,7 +170,7 @@ public class CSSInjectWithColorpicker extends UI {
         select.setEmptySelectionAllowed(false);
         select.addValueChangeListener(event -> {
             // Get the new font family
-            String fontFamily = select.getValue().toString();
+            String fontFamily = select.getValue();
 
             // Get the stylesheet of the page
             Styles styles = Page.getCurrent().getStyles();
index a4b1a025b3b88bc61bc1ccb14053a2f41bc00bba..14e5a0683d106574660d57f6995683198f49c491 100644 (file)
@@ -452,7 +452,7 @@ public class SerializerTest extends AbstractReindeerTestUI {
             @Override
             public void sendWrappedGenerics(
                     Map<Set<SimpleTestBean>, Map<Integer, List<SimpleTestBean>>> generics) {
-                log.log("sendWrappedGenerics: " + generics.toString());
+                log.log("sendWrappedGenerics: " + generics);
             }
 
             @Override
index 436a427e00d2b2d1124deba47864b551a2d6e74e..4d0891a2d58ca142417c4387da1c91fccadd6032 100644 (file)
@@ -6,8 +6,8 @@ import java.util.UUID;
 
 import com.vaadin.server.Page;
 import com.vaadin.server.Page.Styles;
-import com.vaadin.shared.ui.ContentMode;
 import com.vaadin.server.StreamResource;
+import com.vaadin.shared.ui.ContentMode;
 import com.vaadin.tests.components.TestBase;
 import com.vaadin.ui.Button;
 import com.vaadin.ui.Button.ClickEvent;
@@ -68,7 +68,7 @@ public class CSSInjectTest extends TestBase {
                                         return new ByteArrayInputStream(
                                                 css.getBytes());
                                     }
-                                }, UUID.randomUUID().toString() + ".css"));
+                                }, UUID.randomUUID() + ".css"));
 
                         cssToInject.setValue("");
                     }
index de0cbaecd07a6f038c6202e1fa54274596ff13f5..c56af7dafc9e3dfbf5e105a9389c580e69c8a3c2 100644 (file)
@@ -53,8 +53,7 @@ public class DateFieldElementTest extends SingleBrowserTest {
     }
 
     private void assertServerValue(String id, LocalDate testDateTime) {
-        assertEquals(id + " value set to " + testDateTime.toString(),
-                getLogRow(0));
+        assertEquals(id + " value set to " + testDateTime, getLogRow(0));
 
     }
 
index dd0cc8d4f8d2860874580a126ad29ebd95231c2c..5719a9d97fca046cc1d719729356f85bc1c92194 100644 (file)
@@ -56,8 +56,7 @@ public class DateTimeFieldElementTest extends SingleBrowserTest {
     }
 
     private void assertServerValue(String id, LocalDateTime testDateTime) {
-        assertEquals(id + " value set to " + testDateTime.toString(),
-                getLogRow(0));
+        assertEquals(id + " value set to " + testDateTime, getLogRow(0));
 
     }
 
index efcba7a2a7dcb1dc399aaffa968ebb47490e726d..a3267445b7948bca97c48dba156dbba21489df06 100644 (file)
@@ -73,8 +73,7 @@ public class TB3TestLocator {
             try {
                 File f = new File(location.toURI());
                 if (!f.exists()) {
-                    throw new IOException(
-                            "Directory " + f.toString() + " does not exist");
+                    throw new IOException("Directory " + f + " does not exist");
                 }
                 findPackages(f, basePackage, baseClass, classes,
                         ignoredPackages);