prepare SQL query only once, that's what prepared statements are for. Should improve...

diff --git a/apps/files/appinfo/update.php b/apps/files/appinfo/update.php
index bcbbc6035faa2123c4e6ae58f278754be91bccdd..b9a5386e1f76e74ee001b4ee1b98049d0a1a85a4 100644 (file)
--- a/apps/files/appinfo/update.php
+++ b/apps/files/appinfo/update.php
@@ -5,10 +5,10 @@ $installedVersion=OCP\Config::getAppValue('files', 'installed_version');
 if (version_compare($installedVersion, '1.1.6', '<')) {
        $query = OC_DB::prepare( "SELECT `propertyname`, `propertypath`, `userid` FROM `*PREFIX*properties`" );
        $result = $query->execute();
+       $updateQuery = OC_DB::prepare('UPDATE `*PREFIX*properties` SET `propertyname` = ? WHERE `userid` = ? AND `propertypath` = ?');
        while( $row = $result->fetchRow()){
                if ( $row["propertyname"][0] != '{' ) {
-                       $query = OC_DB::prepare( 'UPDATE `*PREFIX*properties` SET `propertyname` = ? WHERE `userid` = ? AND `propertypath` = ?' );
-                       $query->execute( array( '{DAV:}' + $row["propertyname"], $row["userid"], $row["propertypath"] ));
+                       $updateQuery->execute(array('{DAV:}' + $row["propertyname"], $row["userid"], $row["propertypath"]));
                }
        }
 }