]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-5333 Improve widget consistency
authorStas Vilchik <vilchiks@gmail.com>
Fri, 23 May 2014 08:44:59 +0000 (10:44 +0200)
committerStas Vilchik <vilchiks@gmail.com>
Fri, 23 May 2014 08:45:05 +0000 (10:45 +0200)
plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/issues/issues.html.erb
sonar-server/src/main/less/dashboard.less
sonar-server/src/main/less/style.less
sonar-server/src/main/less/variables.less

index da99e2c143d1f82191b96a9f7fb598353ea871c9..55a193ae7988ed01909ab96d9838e9f67782ca51 100644 (file)
       <tr>
         <td>
           <i class="icon-severity-blocker"></i>
-          <%= link_to message('blocker'), {:controller => 'drilldown', :action => 'issues', :id => @project.key, :severity => 'BLOCKER'}, :class => 'widget-link drilldown_BLOCKER' -%>
+          <%= message('blocker') -%>
         </td>
         <td class="thin right">
-          <%= format_measure(blocker_issues) -%>
+          <%= link_to format_measure(blocker_issues), {:controller => 'drilldown', :action => 'issues', :id => @project.key, :severity => 'BLOCKER'}, :class => 'widget-link drilldown_BLOCKER' -%>
         </td>
         <td class="thin">
           <%= dashboard_configuration.selected_period? ? format_variation(blocker_issues) : trend_icon(blocker_issues, :empty => true) -%>
       <tr>
         <td>
           <i class="icon-severity-critical"></i>
-          <%= link_to message('critical'), {:controller => 'drilldown', :action => 'issues', :id => @project.key, :severity => 'CRITICAL'}, :class => 'widget-link drilldown_CRITICAL' -%>
+          <%= message('critical') -%>
         </td>
         <td class="thin right">
-          <%= format_measure(critical_issues) -%>
+          <%= link_to format_measure(critical_issues), {:controller => 'drilldown', :action => 'issues', :id => @project.key, :severity => 'CRITICAL'}, :class => 'widget-link drilldown_CRITICAL' -%>
         </td>
         <td class="thin">
           <%= dashboard_configuration.selected_period? ? format_variation(critical_issues) : trend_icon(critical_issues, :empty => true) -%>
       <tr>
         <td>
           <i class="icon-severity-major"></i>
-          <%= link_to message('major'), {:controller => 'drilldown', :action => 'issues', :id => @project.key, :severity => 'MAJOR'}, :class => 'widget-link drilldown_MAJOR' -%>
+          <%= message('major') -%>
         </td>
         <td class="thin right">
-          <%= format_measure(major_issues) -%>
+          <%= link_to format_measure(major_issues), {:controller => 'drilldown', :action => 'issues', :id => @project.key, :severity => 'MAJOR'}, :class => 'widget-link drilldown_MAJOR' -%>
         </td>
         <td class="thin">
           <%= dashboard_configuration.selected_period? ? format_variation(major_issues) : trend_icon(major_issues, :empty => true) -%>
       <tr>
         <td>
           <i class="icon-severity-minor"></i>
-          <%= link_to message('minor'), {:controller => 'drilldown', :action => 'issues', :id => @project.key, :severity => 'MINOR'}, :class => 'widget-link drilldown_MINOR' -%>
+          <%= message('minor') -%>
         </td>
         <td class="thin right">
-          <%= format_measure(minor_issues) -%>
+          <%= link_to format_measure(minor_issues), {:controller => 'drilldown', :action => 'issues', :id => @project.key, :severity => 'MINOR'}, :class => 'widget-link drilldown_MINOR' -%>
         </td>
         <td class="thin">
           <%= dashboard_configuration.selected_period? ? format_variation(minor_issues) : trend_icon(minor_issues, :empty => true) -%>
       <tr>
         <td>
           <i class="icon-severity-info"></i>
-          <%= link_to message('info'), {:controller => 'drilldown', :action => 'issues', :id => @project.key, :severity => 'INFO'}, :class => 'widget-link drilldown_INFO' -%>
+          <%= message('info') -%>
         </td>
         <td class="thin right">
-          <%= format_measure(info_issues) -%>
+          <%= link_to format_measure(info_issues), {:controller => 'drilldown', :action => 'issues', :id => @project.key, :severity => 'INFO'}, :class => 'widget-link drilldown_INFO' -%>
         </td>
         <td class="thin">
           <%= dashboard_configuration.selected_period? ? format_variation(info_issues) : trend_icon(info_issues, :empty => true) -%>
index 602ab689ecffb7be6a569a7f8271a468e20b9211..4f8602ac5bd13cb13abb6f8c399d99c65553ac0b 100644 (file)
 
 .widget-label {
   display: block;
-  font-size: @smallFontSize;
+  font-size: @baseFontSize;
   line-height: 1.2;
+  font-weight: 300;
 }
 
 .widget-number {
   margin-top: 10px;
 
   .widget-link, .widget-number { .widget-big; }
-  .widget-label { font-size: @baseFontSize; }
+  .widget-label { font-size: @bigFontSize; }
 }
 
 .widget-measure-container {
   display: inline-block;
   line-height: 1.5;
   margin-right: 10px;
-  font-size: 18px;
+  font-size: @bigFontSize;
   font-weight: 300;
-//  text-transform: uppercase;
   white-space: nowrap;
 }
 
index d831295cd76705a6cae43c0c0d370bbe5b9da999..c304886ab5b97543550f529a9735320783947860 100644 (file)
@@ -1504,12 +1504,16 @@ span.empty_widget {
   padding: 0 10px 7px 0;
 
   h3 {
-    color: @secondFontColor;
-    font-size: @smallFontSize;
+    line-height: 1.2;
+    font-size: @bigFontSize;
     font-weight: 300;
   }
 
-  a { .widget-link; }
+  a {
+    .widget-link;
+
+    .rating { color: #fff; }
+  }
 }
 
 .big {
index 729a845f9b2c82d72385528f06d4ab3924d19894..663e984d2f3fe5d8097996318c8e1dea8b36437e 100644 (file)
@@ -2,10 +2,11 @@
  * Fonts
  */
 
+@smallFontSize: 12px;
 @baseFontSize: 13px;
+@bigFontSize: 16px;
 @baseFontColor: #444;
 @secondFontColor: #777;
-@smallFontSize: 12px;
 @headerFontSize: 16px;