[Cleanup] Handle system dependent defines through autoheader & common-config.h

git-svn-id: svn://svn.code.sf.net/p/tigervnc/code/trunk@2890 3789f03b-4d11-0410-bbf8-ca57d06f2519

diff --git a/common/configure.ac b/common/configure.ac
index 198d6640ec899b0ac4f1a4a7fd46b260cc1a1595..f0b8a8abe6b6dd766ded5689472c2a8eae9e328f 100644 (file)
--- a/common/configure.ac
+++ b/common/configure.ac
@@ -10,6 +10,9 @@ AC_PROG_CXX
 AC_PROG_LIBTOOL
 AC_LANG([C++])
 
+AC_CONFIG_HEADERS([common-config.h])
+CPPFLAGS="-DHAVE_COMMON_CONFIG_H $CPPFLAGS"
+
 case "`(uname -sr) 2>/dev/null`" in
 "SunOS 5"*)
   SOLARIS=yes
@@ -42,13 +45,13 @@ fi
 dnl Checks for IRIX-specific Compression Library.
 AC_SEARCH_LIBS([clQuerySchemeFromName])
 AC_CHECK_LIB(cl, clQuerySchemeFromName,
-  [AC_DEFINE(HAVE_CL)
+  [AC_DEFINE([HAVE_CL], 1, [Define if you have IRIX compression library])
   IRIX_COMPRESS=yes])
 AM_CONDITIONAL([IRIX_COMPRESS], [ test "x$IRIX_COMPRESS" = xyes ])
 
 dnl Checks for IRIX-specific Digital Media libraries.
 AC_CHECK_LIB(dmedia, dmICCreate,
-  [AC_DEFINE(HAVE_DMEDIA)
+  [AC_DEFINE(HAVE_DMEDIA, 1, [Define if you have IRIX Digital Media library])
   IRIX_MEDIA=yes])
 AM_CONDITIONAL([IRIX_MEDIA], [ test "x$IRIX_MEDIA" = xyes ])
 
@@ -96,28 +99,11 @@ AC_SUBST(JPEG_DIR)
 AC_SUBST(JPEG_INCLUDE)
 AC_SUBST(JPEG_LIB)
 
-AC_CHECK_FUNC(vsnprintf,VSNPRINTF_DEFINE='-DHAVE_VSNPRINTF',VSNPRINTF_DEFINE=)
-AC_SUBST(VSNPRINTF_DEFINE)
-
-AC_CHECK_FUNC(strcasecmp,STRCASECMP_DEFINE='-DHAVE_STRCASECMP',
-  STRCASECMP_DEFINE=)
-AC_SUBST(STRCASECMP_DEFINE)
-
-AC_CHECK_FUNC(strncasecmp,STRNCASECMP_DEFINE='-DHAVE_STRNCASECMP',
-  STRNCASECMP_DEFINE=)
-AC_SUBST(STRNCASECMP_DEFINE)
-
-AC_MSG_CHECKING(for socklen_t)
-AC_TRY_COMPILE(
-[#include <sys/types.h>
- #include <sys/socket.h>],
-[socklen_t x;
-accept(0, 0, &x);],
-AC_MSG_RESULT(yes)
-SOCKLEN_T_DEFINE='-DVNC_SOCKLEN_T=socklen_t',
-AC_MSG_RESULT(using int)
-SOCKLEN_T_DEFINE='-DVNC_SOCKLEN_T=int')
-AC_SUBST(SOCKLEN_T_DEFINE)
+AC_CHECK_FUNCS_ONCE([vsnprintf strcasecmp strncasecmp])
+
+AC_CHECK_TYPES([socklen_t],
+       [AC_DEFINE([VNC_SOCKLEN_T], [socklen_t], [Use correct size])],
+       [AC_DEFINE([VNC_SOCKLEN_T], [int])])
 
 AC_OUTPUT([Makefile
           rdr/Makefile

diff --git a/common/network/Makefile.am b/common/network/Makefile.am
index 61d276bb6e96a50e2c9d92a50a625781c84eb8ee..c4bad9349faac914f522da3cd2e2998cc0fcb637 100644 (file)
--- a/common/network/Makefile.am
+++ b/common/network/Makefile.am
@@ -4,5 +4,5 @@ HDRS = Socket.h TcpSocket.h
 
 libnetwork_la_SOURCES = $(HDRS) TcpSocket.cxx
 
-libnetwork_la_CPPFLAGS = -I$(top_srcdir) @SOCKLEN_T_DEFINE@
+libnetwork_la_CPPFLAGS = -I$(top_srcdir)
 

diff --git a/common/network/TcpSocket.cxx b/common/network/TcpSocket.cxx
index 5dd24287e6d55c8d704a07353ecf91f9d2923f87..777627b4ffcaf7c616d8fa7c0f68e896c4f050b0 100644 (file)
--- a/common/network/TcpSocket.cxx
+++ b/common/network/TcpSocket.cxx
@@ -16,6 +16,10 @@
  * USA.
  */
 
+#ifdef HAVE_COMMON_CONFIG_H
+#include <common-config.h>
+#endif
+
 #ifdef WIN32
 //#include <io.h>
 #include <winsock2.h>
@@ -42,10 +46,6 @@
 #include <rfb/util.h>
 #include <rfb/LogWriter.h>
 
-#ifndef VNC_SOCKLEN_T
-#define VNC_SOCKLEN_T int
-#endif
-
 #ifndef INADDR_NONE
 #define INADDR_NONE ((unsigned long)-1)
 #endif

diff --git a/common/rfb/JpegEncoder.cxx b/common/rfb/JpegEncoder.cxx
index 71291927fc903f32377d23d59656c44b312a6d06..2c47a604f2762b22a7163b30d1056bfb82833411 100644 (file)
--- a/common/rfb/JpegEncoder.cxx
+++ b/common/rfb/JpegEncoder.cxx
@@ -16,6 +16,10 @@
  * USA.
  */
 
+#ifdef HAVE_COMMON_CONFIG_H
+#include <common-config.h>
+#endif
+
 #include <rfb/JpegEncoder.h>
 #include <rdr/OutStream.h>
 #include <rdr/Exception.h>

diff --git a/common/rfb/Logger.cxx b/common/rfb/Logger.cxx
index 6b9cfa315c6e7806785bb1e156022facd5068df0..8c90906c3428d1144dd2f00363414086a623dd9b 100644 (file)
--- a/common/rfb/Logger.cxx
+++ b/common/rfb/Logger.cxx
@@ -18,6 +18,10 @@
 
 // -=- Logger.cxx - support for the Logger and LogWriter classes
 
+#ifdef HAVE_COMMON_CONFIG_H
+#include <common-config.h>
+#endif
+
 #include <stdarg.h>
 #include <stdio.h>
 #include <string.h>

diff --git a/common/rfb/Makefile.am b/common/rfb/Makefile.am
index 30c06d7dd1a6fbc170881de66ea2d564adc6ba7b..f2106d18e0aba3274b0039113db3a569c5824db3 100644 (file)
--- a/common/rfb/Makefile.am
+++ b/common/rfb/Makefile.am
@@ -53,8 +53,7 @@ if IRIX_MEDIA
 librfb_la_SOURCES += IrixDMJpegCompressor.cxx IrixDMIC_RawToJpeg.cxx
 endif
 
-librfb_la_CPPFLAGS = -I$(top_srcdir) @JPEG_INCLUDE@ @VSNPRINTF_DEFINE@ \
-       @STRCASECMP_DEFINE@ @STRNCASECMP_DEFINE@
+librfb_la_CPPFLAGS = -I$(top_srcdir) @JPEG_INCLUDE@
 
 librfb_la_LIBADD = @JPEG_LIB@
 

diff --git a/common/rfb/util.cxx b/common/rfb/util.cxx
index 5745432437df9e96d26491ad006e302cadcee245..7950a1d8f75fd9fefdbaf49ff8b16bd1669d0a89 100644 (file)
--- a/common/rfb/util.cxx
+++ b/common/rfb/util.cxx
@@ -30,6 +30,10 @@
  * is provided ``as is'' without express or implied warranty.
  */
 
+#ifndef HAVE_COMMON_CONFIG_H
+#include <common-config.h>
+#endif
+
 #include <rfb/util.h>
 
 // Provide strcasecmp() and/or strncasecmp() if absent on this system.

diff --git a/common/rfb/util.h b/common/rfb/util.h
index fa205f085d64321813b49c0c169933cc27672ede..933df5272f45ccd397d02a116f0d99276ee04558 100644 (file)
--- a/common/rfb/util.h
+++ b/common/rfb/util.h
@@ -23,6 +23,10 @@
 #ifndef __RFB_UTIL_H__
 #define __RFB_UTIL_H__
 
+#ifdef HAVE_COMMON_CONFIG_H
+#include <common-config.h>
+#endif
+
 #include <limits.h>
 #include <string.h>