Complete unit tests of SettingsChangeNotifier

diff --git a/sonar-server/src/main/java/org/sonar/server/platform/SettingsChangeNotifier.java b/sonar-server/src/main/java/org/sonar/server/platform/SettingsChangeNotifier.java
index 3cbeaa2168be4af53ef2339242e747825aaff737..8aef53371a8307c0da6643babe86a8030ec69897 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/platform/SettingsChangeNotifier.java
+++ b/sonar-server/src/main/java/org/sonar/server/platform/SettingsChangeNotifier.java
@@ -19,6 +19,7 @@
  */
 package org.sonar.server.platform;
 
+import com.google.common.annotations.VisibleForTesting;
 import org.sonar.api.ServerComponent;
 import org.sonar.api.config.GlobalPropertyChangeHandler;
 
@@ -26,7 +27,8 @@ import javax.annotation.Nullable;
 
 public class SettingsChangeNotifier implements ServerComponent {
 
-  private GlobalPropertyChangeHandler[] changeHandlers;
+  @VisibleForTesting
+  GlobalPropertyChangeHandler[] changeHandlers;
 
   public SettingsChangeNotifier(GlobalPropertyChangeHandler[] changeHandlers) {
     this.changeHandlers = changeHandlers;

diff --git a/sonar-server/src/test/java/org/sonar/server/platform/SettingsChangeNotifierTest.java b/sonar-server/src/test/java/org/sonar/server/platform/SettingsChangeNotifierTest.java
index d064745c04a95492f030a910e582b746ec73276d..05755d6661d223bf9d49cc96e3844b322973e83b 100644 (file)
--- a/sonar-server/src/test/java/org/sonar/server/platform/SettingsChangeNotifierTest.java
+++ b/sonar-server/src/test/java/org/sonar/server/platform/SettingsChangeNotifierTest.java
@@ -24,6 +24,7 @@ import org.hamcrest.Description;
 import org.junit.Test;
 import org.sonar.api.config.GlobalPropertyChangeHandler;
 
+import static org.fest.assertions.Assertions.assertThat;
 import static org.mockito.Matchers.argThat;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
@@ -46,4 +47,14 @@ public class SettingsChangeNotifierTest {
       }
     }));
   }
+
+  @Test
+  public void no_handlers() {
+    SettingsChangeNotifier notifier = new SettingsChangeNotifier();
+
+    assertThat(notifier.changeHandlers).isEmpty();
+
+    // does not fail
+    notifier.onGlobalPropertyChange("foo", "bar");
+  }
 }