# Prefills the form with 'Non member' role permissions
@role = Role.new(params[:role] || {:permissions => Role.non_member.permissions})
if request.post? && @role.save
+ # workflow copy
+ if !params[:copy_workflow_from].blank? && (copy_from = Role.find_by_id(params[:copy_workflow_from]))
+ @role.workflows.copy(copy_from)
+ end
flash[:notice] = l(:notice_successful_create)
redirect_to :action => 'list'
end
@permissions = @role.setable_permissions
+ @roles = Role.find :all, :order => 'builtin, position'
end
def edit
if request.post? and @tracker.save
# workflow copy
if !params[:copy_workflow_from].blank? && (copy_from = Tracker.find_by_id(params[:copy_workflow_from]))
- Workflow.transaction do
- copy_from.workflows.find(:all, :include => [:role, :old_status, :new_status]).each do |w|
- Workflow.create(:tracker_id => @tracker.id, :role => w.role, :old_status => w.old_status, :new_status => w.new_status)
- end
- end
+ @tracker.workflows.copy(copy_from)
end
flash[:notice] = l(:notice_successful_create)
redirect_to :action => 'list'
end
- @trackers = Tracker.find :all
+ @trackers = Tracker.find :all, :order => 'position'
end
def edit
BUILTIN_ANONYMOUS = 2
before_destroy :check_deletable
- has_many :workflows, :dependent => :delete_all
+ has_many :workflows, :dependent => :delete_all do
+ def copy(role)
+ raise "Can not copy workflow from a #{role.class}" unless role.is_a?(Role)
+ raise "Can not copy workflow from/to an unsaved role" if proxy_owner.new_record? || role.new_record?
+ clear
+ connection.insert "INSERT INTO workflows (tracker_id, old_status_id, new_status_id, role_id)" +
+ " SELECT tracker_id, old_status_id, new_status_id, #{proxy_owner.id}" +
+ " FROM workflows" +
+ " WHERE role_id = #{role.id}"
+ end
+ end
+
has_many :members
acts_as_list
class Tracker < ActiveRecord::Base
before_destroy :check_integrity
has_many :issues
- has_many :workflows, :dependent => :delete_all
+ has_many :workflows, :dependent => :delete_all do
+ def copy(tracker)
+ raise "Can not copy workflow from a #{tracker.class}" unless tracker.is_a?(Tracker)
+ raise "Can not copy workflow from/to an unsaved tracker" if proxy_owner.new_record? || tracker.new_record?
+ clear
+ connection.insert "INSERT INTO workflows (tracker_id, old_status_id, new_status_id, role_id)" +
+ " SELECT #{proxy_owner.id}, old_status_id, new_status_id, role_id" +
+ " FROM workflows" +
+ " WHERE tracker_id = #{tracker.id}"
+ end
+ end
+
has_and_belongs_to_many :projects
has_and_belongs_to_many :custom_fields, :class_name => 'IssueCustomField', :join_table => "#{table_name_prefix}custom_fields_trackers#{table_name_suffix}", :association_foreign_key => 'custom_field_id'
acts_as_list
<div class="box">
<p><%= f.text_field :name, :required => true %></p>
<p><%= f.check_box :assignable %></p>
+<% if @role.new_record? && @roles.any? %>
+<p><label><%= l(:label_copy_workflow_from) %></label>
+<%= select_tag(:copy_workflow_from, content_tag("option") + options_from_collection_for_select(@roles, :id, :name)) %></p>
+<% end %>
</div>
<% end %>
<p><%= f.text_field :name, :required => true %></p>
<p><%= f.check_box :is_in_chlog %></p>
<p><%= f.check_box :is_in_roadmap %></p>
-<% if @tracker.new_record? %>
-<p><label><%= l(:label_copy_workflow_from) %></label> <%= select_tag(:copy_workflow_from, content_tag("option") + options_from_collection_for_select(@trackers, :id, :name)) %></p>
+<% if @tracker.new_record? && @trackers.any? %>
+<p><label><%= l(:label_copy_workflow_from) %></label>
+<%= select_tag(:copy_workflow_from, content_tag("option") + options_from_collection_for_select(@trackers, :id, :name)) %></p>
<% end %>
<!--[eoform:tracker]-->
</div>
--- /dev/null
+# redMine - project management software
+# Copyright (C) 2006-2007 Jean-Philippe Lang
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+
+require File.dirname(__FILE__) + '/../test_helper'
+require 'roles_controller'
+
+# Re-raise errors caught by the controller.
+class RolesController; def rescue_action(e) raise e end; end
+
+class RolesControllerTest < Test::Unit::TestCase
+ fixtures :roles, :users, :members, :workflows
+
+ def setup
+ @controller = RolesController.new
+ @request = ActionController::TestRequest.new
+ @response = ActionController::TestResponse.new
+ User.current = nil
+ @request.session[:user_id] = 1 # admin
+ end
+
+ def test_get_new
+ get :new
+ assert_response :success
+ assert_template 'new'
+ end
+
+ def test_post_new_with_validaton_failure
+ post :new, :role => {:name => '',
+ :permissions => ['add_issues', 'edit_issues', 'log_time', ''],
+ :assignable => '0'}
+
+ assert_response :success
+ assert_template 'new'
+ assert_tag :tag => 'div', :attributes => { :id => 'errorExplanation' }
+ end
+
+ def test_post_new_without_workflow_copy
+ post :new, :role => {:name => 'RoleWithoutWorkflowCopy',
+ :permissions => ['add_issues', 'edit_issues', 'log_time', ''],
+ :assignable => '0'}
+
+ assert_redirected_to 'roles/list'
+ role = Role.find_by_name('RoleWithoutWorkflowCopy')
+ assert_not_nil role
+ assert_equal [:add_issues, :edit_issues, :log_time], role.permissions
+ assert !role.assignable?
+ end
+
+ def test_post_new_with_workflow_copy
+ post :new, :role => {:name => 'RoleWithWorkflowCopy',
+ :permissions => ['add_issues', 'edit_issues', 'log_time', ''],
+ :assignable => '0'},
+ :copy_workflow_from => '1'
+
+ assert_redirected_to 'roles/list'
+ role = Role.find_by_name('RoleWithWorkflowCopy')
+ assert_not_nil role
+ assert_equal Role.find(1).workflows.size, role.workflows.size
+ end
+
+ def test_get_edit
+ get :edit, :id => 1
+ assert_response :success
+ assert_template 'edit'
+ assert_equal Role.find(1), assigns(:role)
+ end
+
+ def test_post_edit
+ post :edit, :id => 1,
+ :role => {:name => 'Manager',
+ :permissions => ['edit_project', ''],
+ :assignable => '0'}
+
+ assert_redirected_to 'roles/list'
+ role = Role.find(1)
+ assert_equal [:edit_project], role.permissions
+ end
+end
--- /dev/null
+# redMine - project management software
+# Copyright (C) 2006-2008 Jean-Philippe Lang
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+
+require File.dirname(__FILE__) + '/../test_helper'
+
+class RoleTest < Test::Unit::TestCase
+ fixtures :roles, :workflows
+
+ def test_copy_workflows
+ source = Role.find(1)
+ assert_equal 90, source.workflows.size
+
+ target = Role.new(:name => 'Target')
+ assert target.save
+ assert target.workflows.copy(source)
+ target.reload
+ assert_equal 90, target.workflows.size
+ end
+end
--- /dev/null
+# redMine - project management software
+# Copyright (C) 2006-2008 Jean-Philippe Lang
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+
+require File.dirname(__FILE__) + '/../test_helper'
+
+class TrackerTest < Test::Unit::TestCase
+ fixtures :trackers, :workflows
+
+ def test_copy_workflows
+ source = Tracker.find(1)
+ assert_equal 90, source.workflows.size
+
+ target = Tracker.new(:name => 'Target')
+ assert target.save
+ assert target.workflows.copy(source)
+ target.reload
+ assert_equal 90, target.workflows.size
+ end
+end
projects / redmine.git / commitdiff