FindBugs - BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696040 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/src/java/org/apache/poi/ss/formula/functions/Complex.java b/src/java/org/apache/poi/ss/formula/functions/Complex.java
index 1e0bd5bfdcde22f337edb1cc7a4ac89aa5104bbd..4674b8bafb443fd5e5326d69ae018f53d1b3d255 100644 (file)
--- a/src/java/org/apache/poi/ss/formula/functions/Complex.java
+++ b/src/java/org/apache/poi/ss/formula/functions/Complex.java
@@ -104,7 +104,7 @@ public class Complex extends Var2or3ArgFunction implements FreeRefFunction {
         StringBuffer strb = new StringBuffer("");\r
         if (realNum != 0) {\r
             if (isDoubleAnInt(realNum)) {\r
-                strb.append(new Double(realNum).intValue());\r
+                strb.append((int)realNum);\r
             } else {\r
                 strb.append(realNum);\r
             }\r

diff --git a/src/java/org/apache/poi/ss/formula/functions/Rept.java b/src/java/org/apache/poi/ss/formula/functions/Rept.java
index 0dbb189cddc1e830654527e4784f5ae87178312e..0c8a5f876e9ed7dd64db82c44c9e430321c6f203 100644 (file)
--- a/src/java/org/apache/poi/ss/formula/functions/Rept.java
+++ b/src/java/org/apache/poi/ss/formula/functions/Rept.java
@@ -59,7 +59,7 @@ public class Rept extends Fixed2ArgFunction  {
             return ErrorEval.VALUE_INVALID;\r
         }\r
 \r
-        int numberOfTimeInt = new Double(numberOfTime).intValue();\r
+        int numberOfTimeInt = (int)numberOfTime;\r
         StringBuffer strb = new StringBuffer(strText1.length() * numberOfTimeInt);\r
         for(int i = 0; i < numberOfTimeInt; i++) {\r
             strb.append(strText1);\r