new ProxiedRepositoryGroup( proxiedRepositories, managedRepository, wagonProxy ) );
}
- // TODO: ability to configure default proxy separately
+ // TODO: ability to configure default proxy separately!
if ( groups.size() == 1 )
{
new CronTrigger( INDEXER_JOB + "Trigger", DISCOVERER_GROUP, configuration.getIndexerCronExpression() );
scheduler.scheduleJob( jobDetail, trigger );
- // TODO: run as a job so it doesn't block startup/configuration saving
+ // TODO: run as a job so it doesn't block startup/configuration saving!
try
{
indexerTask.executeNowIfNeeded();
{
getLogger().info( "Not scheduling indexer - index path is not configured" );
}
-
- // TODO: wire in the converter
}
public void stop()
* Test the default artifact discoverer.
*
* @author <a href="mailto:brett@apache.org">Brett Porter</a>
- * @version $Id$
- * @todo test location of poms, checksums
+ * @version $Id:DefaultArtifactDiscovererTest.java 437105 2006-08-26 17:22:22 +1000 (Sat, 26 Aug 2006) brett $
*/
public class DefaultArtifactDiscovererTest
extends AbstractArtifactDiscovererTest
{
-
protected String getLayout()
{
return "default";
assertTrue( "Check failure", proxiedArtifactRepository1.isCachedFailure( path ) );
assertTrue( "Check failure", proxiedArtifactRepository2.isCachedFailure( path ) );
- // TODO: do we really want failures to present as a not found?
+ // TODO: do not want failures to present as a not found!
// TODO: How much information on each failure should we pass back to the user vs. logging in the proxy?
}
}
assertEquals( "Check file matches", expectedFile, file );
assertTrue( "Check file created", file.exists() );
assertEquals( "Check file contents", expectedContents, FileUtils.fileRead( file ) );
-
- // TODO: is this the correct behaviour, or should it be considered removed too?
}
public void testGetAlwaysWithCachedFailure()
}
catch ( IOException e )
{
- // TODO: should just warn and continue?
+ // TODO: should just warn and continue!
throw new ReportProcessorException( "Unable to read artifact to extract model", e );
}
catch ( XmlPullParserException e )
{
- // TODO: should just warn and continue?
+ // TODO: should just warn and continue!
throw new ReportProcessorException( "Unable to read artifact to extract model", e );
}
finally
boolean containsArtifact( Artifact artifact );
/**
- * @todo I believe we can remove this [BP] - artifact should contain all the necessary version info
+ * @todo I believe we can remove this [BP] - artifact should contain all the necessary version info!
*/
boolean containsArtifact( Artifact artifact, Snapshot snapshot );
import java.util.Iterator;
-/**
- * @todo??? should use MetadataXpp3Reader instead ?
- */
public class BadMetadataReportProcessorTest
extends AbstractRepositoryReportsTestCase
{
/**
* Browse the repository.
*
- * @todo the tree part probably belongs in a browsing component, and the indexer could optimize how it retrieves the terms rather than querying everything
+ * @todo the tree part probably belongs in a browsing component, and the indexer could optimize how it retrieves the terms rather than querying everything!
* @plexus.component role="com.opensymphony.xwork.Action" role-hint="browseAction"
*/
public class BrowseAction
{
// TODO: give action message if indexing is in progress
- // TODO: this will be inefficient over a very large number of artifacts, should be cached
+ // TODO: this will be inefficient over a very large number of artifacts, should be cached!
List records = index.search( new LuceneQuery( new MatchAllDocsQuery() ) );
artifactStream = new FileInputStream( file );
- // TODO: could be better
+ // TODO: could be better!
contentType = "application/octet-stream";
filename = file.getName();
if ( !file.exists() )
{
file.mkdirs();
- // TODO: error handling when this fails, or is not a directory
+ // TODO: error handling when this fails, or is not a directory!
}
// Just double checking that our validation routines line up with what is expected in the configuration
configurationStore.storeConfiguration( configuration );
- // TODO: if the repository has changed, we need to check if indexing is needed
+ // TODO: if the repository has changed, we need to check if indexing is needed!
addActionMessage( "Successfully saved configuration" );
if ( !file.exists() )
{
file.mkdirs();
- // TODO: error handling when this fails, or is not a directory
+ // TODO: error handling when this fails, or is not a directory!
}
configuration.addRepository( repository );
* An interceptor that makes the application configuration available
*
* @author <a href="mailto:brett@apache.org">Brett Porter</a>
- * @todo might be a generally useful thing in plexus-xwork-integration
* @plexus.component role="com.opensymphony.xwork.interceptor.Interceptor" role-hint="configurationInterceptor"
*/
public class ConfigurationInterceptor
<!DOCTYPE validators PUBLIC "-//OpenSymphony Group//XWork Validator 1.0.2//EN"
"http://www.opensymphony.com/xwork/xwork-validator-1.0.2.dtd">
+<!-- TODO! see MRM-150 for progress on these -->
<validators>
<!-- TODO: constrain more -->
<field name="id">
<!DOCTYPE validators PUBLIC "-//OpenSymphony Group//XWork Validator 1.0.2//EN"
"http://www.opensymphony.com/xwork/xwork-validator-1.0.2.dtd">
+<!-- TODO! see MRM-150 for progress on these -->
<validators>
<!-- TODO: constrain more -->
<field name="id">
<!DOCTYPE validators PUBLIC "-//OpenSymphony Group//XWork Validator 1.0.2//EN"
"http://www.opensymphony.com/xwork/xwork-validator-1.0.2.dtd">
+<!-- TODO! see MRM-150 for progress on these -->
<validators>
<field name="id">
<field-validator type="requiredstring">
<!DOCTYPE validators PUBLIC "-//OpenSymphony Group//XWork Validator 1.0.2//EN"
"http://www.opensymphony.com/xwork/xwork-validator-1.0.2.dtd">
+<!-- TODO! see MRM-150 for progress on these -->
<validators>
<!-- TODO: constrain more -->
<field name="method">
"http://www.opensymphony.com/xwork/xwork-1.1.dtd">
<xwork>
- <!-- TODO: better error handling for exceptions needed -->
+ <!-- TODO: better error handling for exceptions needed! -->
<!-- Include webwork defaults (from WebWork JAR). -->
<include file="webwork-default.xml"/>
<default-interceptor-ref name="configuredStack"/>
<global-results>
- <!-- TODO: might want an extra message on the configure page when this first happens -->
+ <!-- TODO: want an extra message on the configure page when this first happens! -->
<!-- TODO: can we send them back to the original location afterwards? -->
<result name="config-needed" type="redirect-action">
<param name="namespace">/admin</param>
</result>
<result name="config-repository-needed" type="redirect-action">
<param name="namespace">/admin</param>
- <!-- TODO should use param name=method, but WW 2.2.2 doesn't recognise it -->
- <param name="actionName">addRepository!input</param>
+ <param name="actionName">addRepository</param>
+ <param name="method">input</param>
</result>
<result name="error">/WEB-INF/jsp/generalError.jsp</result>
</global-results>
projects / archiva.git / commitdiff