Closed issue are not overdue, fixes r2140 (#2337).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2361 e93f8b46-1217-0410-a6f0-8f06a7374b81

diff --git a/app/models/issue.rb b/app/models/issue.rb
index cbd2628004a81954f99219770fe7566485eec4fe..618c5597d0c5fb27dc09e34387c52eaf4d143d4a 100644 (file)
--- a/app/models/issue.rb
+++ b/app/models/issue.rb
@@ -215,7 +215,7 @@ class Issue < ActiveRecord::Base
   
   # Returns true if the issue is overdue
   def overdue?
-    !due_date.nil? && (due_date < Date.today)
+    !due_date.nil? && (due_date < Date.today) && !status.is_closed?
   end
   
   # Users the issue can be assigned to

diff --git a/test/unit/issue_test.rb b/test/unit/issue_test.rb
index b82303264b7ff2c27d80b10ccc64cd6ad47ef246..89ec3c6da99f4d08d38063437d058c0aeebe5eb1 100644 (file)
--- a/test/unit/issue_test.rb
+++ b/test/unit/issue_test.rb
@@ -226,5 +226,6 @@ class IssueTest < Test::Unit::TestCase
     assert !Issue.new(:due_date => Date.today).overdue?
     assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
     assert !Issue.new(:due_date => nil).overdue?
+    assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue?
   end
 end