]> source.dussan.org Git - vaadin-framework.git/commitdiff
TabSheet focus/blur patch for 7.3 (#14304)
authorBogdan Udrescu <bogdan@vaadin.com>
Fri, 15 Aug 2014 04:59:14 +0000 (07:59 +0300)
committerArtur Signell <artur@vaadin.com>
Tue, 19 Aug 2014 10:59:02 +0000 (10:59 +0000)
Remove the listeners from VTabSheet and use them as inner.

Change-Id: I65bc84fe6120abcaa01d22fcc373802f4f773bdc

client/src/com/vaadin/client/ui/VTabsheet.java

index aff184864760ef03cfee4ca9f042d50e84325e4e..e5afbea4b4f6355acffe0b442c6333d21dcff697 100644 (file)
@@ -76,10 +76,7 @@ import com.vaadin.shared.ui.tabsheet.TabState;
 import com.vaadin.shared.ui.tabsheet.TabsheetServerRpc;
 import com.vaadin.shared.ui.tabsheet.TabsheetState;
 
-public class VTabsheet extends VTabsheetBase implements Focusable,
-        SubPartAware,
-        // TODO: These listeners are due to be removed in 7.3
-        FocusHandler, BlurHandler, KeyDownHandler {
+public class VTabsheet extends VTabsheetBase implements Focusable, SubPartAware {
 
     private static class VCloseEvent {
         private Tab tab;
@@ -1532,21 +1529,6 @@ public class VTabsheet extends VTabsheetBase implements Focusable,
 
     }
 
-    @Override
-    public void onBlur(BlurEvent event) {
-        selectionHandler.onBlur(event);
-    }
-
-    @Override
-    public void onFocus(FocusEvent event) {
-        selectionHandler.onFocus(event);
-    }
-
-    @Override
-    public void onKeyDown(KeyDownEvent event) {
-        selectionHandler.onKeyDown(event);
-    }
-
     /*
      * The tabs selection handler instance.
      */
@@ -1570,11 +1552,9 @@ public class VTabsheet extends VTabsheetBase implements Focusable,
          */
         public void registerTab(Tab tab) {
 
-            // TODO: change VTabsheet.this to this in 7.3
-            tab.addBlurHandler(VTabsheet.this);
-            tab.addFocusHandler(VTabsheet.this);
-            tab.addKeyDownHandler(VTabsheet.this);
-
+            tab.addBlurHandler(this);
+            tab.addFocusHandler(this);
+            tab.addKeyDownHandler(this);
             tab.addClickHandler(this);
             tab.addMouseDownHandler(this);
         }