SONAR-16885 [892372] Group of navigation links missing semantics

diff --git a/server/sonar-web/src/main/js/apps/component-measures/sidebar/Sidebar.tsx b/server/sonar-web/src/main/js/apps/component-measures/sidebar/Sidebar.tsx
index ce346568958375f8ffcccd1d38f2c41ece534108..611320a1e9240e8c99eb2d653adf66208cc14d68 100644 (file)
--- a/server/sonar-web/src/main/js/apps/component-measures/sidebar/Sidebar.tsx
+++ b/server/sonar-web/src/main/js/apps/component-measures/sidebar/Sidebar.tsx
@@ -58,7 +58,7 @@ export default class Sidebar extends React.PureComponent<Props, State> {
   render() {
     const { showFullMeasures } = this.props;
     return (
-      <div>
+      <nav aria-label={translate('secondary')}>
         <A11ySkipTarget
           anchor="measures_filters"
           label={translate('component_measures.skip_to_filters')}
@@ -80,7 +80,7 @@ export default class Sidebar extends React.PureComponent<Props, State> {
             showFullMeasures={showFullMeasures}
           />
         ))}
-      </div>
+      </nav>
     );
   }
 }

diff --git a/server/sonar-web/src/main/js/apps/component-measures/sidebar/__tests__/__snapshots__/Sidebar-test.tsx.snap b/server/sonar-web/src/main/js/apps/component-measures/sidebar/__tests__/__snapshots__/Sidebar-test.tsx.snap
index 75e622da8f581dd33a02f1ac23870af890f75df3..fc32787d6678c14437f773b0cf3a815d1221f8c9 100644 (file)
--- a/server/sonar-web/src/main/js/apps/component-measures/sidebar/__tests__/__snapshots__/Sidebar-test.tsx.snap
+++ b/server/sonar-web/src/main/js/apps/component-measures/sidebar/__tests__/__snapshots__/Sidebar-test.tsx.snap
@@ -1,7 +1,9 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`should display two facets 1`] = `
-<div>
+<nav
+  aria-label="secondary"
+>
   <A11ySkipTarget
     anchor="measures_filters"
     label="component_measures.skip_to_filters"
@@ -87,5 +89,5 @@ exports[`should display two facets 1`] = `
     selected="duplicated_lines_density"
     showFullMeasures={true}
   />
-</div>
+</nav>
 `;

diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
index 3a31c043dac7291e6aba001998c0a097491d6049..000590eb25e599dcf93d54e42b72fca4ce0373b6 100644 (file)
--- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties
+++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
@@ -190,6 +190,7 @@ start_date=Start Date
 x_show={0} shown
 x_selected={0} selected
 x_of_y_shown={0} of {1} shown
+secondary=Secondary
 size=Size
 skip=Skip
 skip_to_content=Skip to main content