Fix for #2592 - Tabsheet icons sometimes disappear in IE

svn changeset:6840/svn branch:trunk

diff --git a/src/com/itmill/toolkit/terminal/gwt/client/ICaption.java b/src/com/itmill/toolkit/terminal/gwt/client/ICaption.java
index d5d86c20ddc805a697bf42e36bed618036bb8fc7..d3e12769ad1b84a42299615dc1f04f7b5a185d1f 100644 (file)
--- a/src/com/itmill/toolkit/terminal/gwt/client/ICaption.java
+++ b/src/com/itmill/toolkit/terminal/gwt/client/ICaption.java
@@ -95,8 +95,8 @@ public class ICaption extends HTML {
             }
             placedAfterComponent = false;
 
-            icon.setUri(uidl.getStringAttribute(ATTRIBUTE_ICON));
             iconOnloadHandled = false;
+            icon.setUri(uidl.getStringAttribute(ATTRIBUTE_ICON));
 
         } else if (icon != null) {
             // Remove existing

diff --git a/src/com/itmill/toolkit/terminal/gwt/client/ui/Icon.java b/src/com/itmill/toolkit/terminal/gwt/client/ui/Icon.java
index 5411ccb199efcac8f3a6160abfc635bfff96a45a..9b616af7857c920338af79f7a392732b098dc938 100644 (file)
--- a/src/com/itmill/toolkit/terminal/gwt/client/ui/Icon.java
+++ b/src/com/itmill/toolkit/terminal/gwt/client/ui/Icon.java
@@ -28,11 +28,16 @@ public class Icon extends UIObject {
 
     public void setUri(String uidlUri) {
         if (!uidlUri.equals(myUri)) {
+            /*
+             * Start sinking onload events, widgets responsibility to react. We
+             * must do this BEFORE we set src as IE fires the event immediately
+             * if the image is found in cache (#2592).
+             */
+            sinkEvents(Event.ONLOAD);
+
             String uri = client.translateToolkitUri(uidlUri);
             DOM.setElementProperty(getElement(), "src", uri);
             myUri = uidlUri;
-            // start sinkin onload events, widgets responsibility to react
-            sinkEvents(Event.ONLOAD);
         }
     }