Fix failing tests, add support for empty spans in Opera. Supplements #13132, #10406.

diff --git a/src/css.js b/src/css.js
index 72b13151b67500a530bee8c3968ada616fd8f7e6..197cc57223337121ff875a308486d5c99d714334 100644 (file)
--- a/src/css.js
+++ b/src/css.js
@@ -630,7 +630,10 @@ jQuery(function() {
 
 if ( jQuery.expr && jQuery.expr.filters ) {
        jQuery.expr.filters.hidden = function( elem ) {
-               return elem.offsetWidth === 0 || elem.offsetHeight === 0 || (!jQuery.support.reliableHiddenOffsets && ((elem.style && elem.style.display) || jQuery.css( elem, "display" )) === "none");
+               // Support: Opera <= 12.12
+               // Opera reports offsetWidths and offsetHeights less than zero on some elements
+               return elem.offsetWidth <= 0 || elem.offsetHeight <= 0 ||
+                       (!jQuery.support.reliableHiddenOffsets && ((elem.style && elem.style.display) || jQuery.css( elem, "display" )) === "none");
        };
 
        jQuery.expr.filters.visible = function( elem ) {

diff --git a/test/index.html b/test/index.html
index 45204e27efb4519f2ce9a60534cf23db197475a5..9f8edfe2028cbce570d8f3b60fa7a80eecb44d17 100644 (file)
--- a/test/index.html
+++ b/test/index.html
@@ -87,7 +87,7 @@
        <!-- Test HTML -->
        <!-- this iframe is outside the #qunit-fixture so it won't reload constantly wasting time, but it means the tests must be "safe" and clean up after themselves -->
        <iframe id="loadediframe" name="loadediframe" style="display:none;" src="data/iframe.html"></iframe>
-       <dl id="dl" style="position:absolute;top:-32767px;left:-32767px;width:1px">
+       <dl id="dl" style="position:absolute;top:-32767px;left:-32767px;width:1px;height:1px">
        <div id="qunit-fixture">
                <p id="firstp">See <a id="simon1" href="http://simon.incutio.com/archive/2003/03/25/#getElementsBySelector" rel="bookmark">this blog entry</a> for more information.</p>
                <p id="ap">

diff --git a/test/unit/css.js b/test/unit/css.js
index 101eac03262b157fae58b9ee4215026e5537cd3f..1a3daab8466346219c62d301aaceeb3b0987bd4e 100644 (file)
--- a/test/unit/css.js
+++ b/test/unit/css.js
@@ -897,7 +897,7 @@ test( "css opacity consistency across browsers (#12685)", function() {
 });
 
 test( ":visible/:hidden selectors", function() {
-       expect( 13 );
+       expect( 16 );
 
        ok( jQuery("#nothiddendiv").is(":visible"), "Modifying CSS display: Assert element is visible" );
        jQuery("#nothiddendiv").css({ display: "none" });
@@ -924,6 +924,10 @@ test( ":visible/:hidden selectors", function() {
        equal(jQuery("#table td:visible").length, 1, "hidden cell is not perceived as visible (#4512). Works on table elements");
        $table.css("display", "none").html("<tr><td>cell</td><td>cell</td></tr>");
        equal(jQuery("#table td:visible").length, 0, "hidden cell children not perceived as visible (#4512)");
+
+       t( "Is Visible", "#qunit-fixture div:visible:lt(2)", ["foo", "nothiddendiv"] );
+       t( "Is Not Hidden", "#qunit-fixture:hidden", [] );
+       t( "Is Hidden", "#form input:hidden", ["hidden1","hidden2"] );
 });
 
 asyncTest( "Clearing a Cloned Element's Style Shouldn't Clear the Original Element's Style (#8908)", 24, function() {

diff --git a/test/unit/selector.js b/test/unit/selector.js
index 21113207c688e73c3c7c9dea3fe59f59db359678..07e563da3af7edc709173a4c82a5e264c9ec05c2 100644 (file)
--- a/test/unit/selector.js
+++ b/test/unit/selector.js
@@ -63,29 +63,6 @@ test("attributes - jQuery only", function() {
        );
 });
 
-if ( jQuery.css ) {
-       test("pseudo - visibility", function() {
-               expect( 9 );
-
-               t( "Is Visible", "#qunit-fixture div:visible:lt(2)", ["foo", "nothiddendiv"] );
-               t( "Is Not Hidden", "#qunit-fixture:hidden", [] );
-               t( "Is Hidden", "#form input:hidden", ["hidden1","hidden2"] );
-
-               var $div = jQuery("<div/>").appendTo("body");
-               $div.css({ fontSize: 0, lineHeight: 0 });// IE also needs to set font-size and line-height to 0
-               $div.css( "width", 1 ).css( "height", 0 );
-               t( "Is Visible", "#nothiddendivchild:visible", ["nothiddendivchild"] );
-               t( "Is Not Visible", "#nothiddendivchild:hidden", [] );
-               $div.css( "width", 0 ).css( "height", 1 );
-               t( "Is Visible", "#nothiddendivchild:visible", ["nothiddendivchild"] );
-               t( "Is Not Visible", "#nothiddendivchild:hidden", [] );
-               $div.css( "width", 1 ).css( "height", 1 );
-               t( "Is Visible", "#nothiddendivchild:visible", ["nothiddendivchild"] );
-               t( "Is Not Visible", "#nothiddendivchild:hidden", [] );
-               $div.remove();
-       });
-}
-
 test("disconnected nodes", function() {
        expect( 4 );
        var $opt = jQuery("<option></option>").attr("value", "whipit").appendTo("#qunit-fixture").detach();