Do not show empty admin sections

Fixes #4393

It is far from efficient code. But then again it is easy to understand
and I doubt admins will browse it 24/7

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

diff --git a/settings/Controller/AdminSettingsController.php b/settings/Controller/AdminSettingsController.php
index 4bc986e708e701ca4281f128a411c74f59bc1a03..6c915be6f941ba0691db0b5dcc4fd642506d8de2 100644 (file)
--- a/settings/Controller/AdminSettingsController.php
+++ b/settings/Controller/AdminSettingsController.php
@@ -135,6 +135,10 @@ class AdminSettingsController extends Controller {
                /** @var \OC\Settings\Section[] $prioritizedSections */
                foreach($sections as $prioritizedSections) {
                        foreach ($prioritizedSections as $section) {
+                               if (empty($this->settingsManager->getAdminSettings($section->getID()))) {
+                                       continue;
+                               }
+
                                $icon = '';
                                if ($section instanceof IIconSection) {
                                        $icon = $section->getIcon();