Fix quality flaws

diff --git a/server/sonar-server/src/main/java/org/sonar/server/source/ws/HashAction.java b/server/sonar-server/src/main/java/org/sonar/server/source/ws/HashAction.java
index 7e67fa58f21da9eaccbcbc2ec6552941ac9fc764..02a1a7286208a112cd5f813b7d34c5658c304116 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/source/ws/HashAction.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/source/ws/HashAction.java
@@ -81,7 +81,7 @@ public class HashAction implements RequestHandler {
     }
   }
 
-  private class HashFunction implements Function<Reader, Void> {
+  private static class HashFunction implements Function<Reader, Void> {
 
     private final OutputStreamWriter writer;
     private final String componentKey;
@@ -98,7 +98,7 @@ public class HashAction implements RequestHandler {
         hasData = true;
         CharStreams.copy(input, writer);
       } catch (IOException e) {
-        throw new IllegalStateException(String.format("Can't read line hashes of file '%s'", componentKey));
+        throw new IllegalStateException(String.format("Can't read line hashes of file '%s'", componentKey), e);
       }
       return null;
     }

diff --git a/server/sonar-server/src/test/java/org/sonar/server/es/EsTester.java b/server/sonar-server/src/test/java/org/sonar/server/es/EsTester.java
index 1efc1df9d8a09f840d330ac12316fdf7ba583c59..989a3e677d5e3104e83afd6e26b065ab3ef982cb 100644 (file)
--- a/server/sonar-server/src/test/java/org/sonar/server/es/EsTester.java
+++ b/server/sonar-server/src/test/java/org/sonar/server/es/EsTester.java
@@ -52,6 +52,7 @@ import java.io.File;
 import java.io.FileInputStream;
 import java.util.Collections;
 import java.util.List;
+import java.util.Map;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
@@ -157,6 +158,14 @@ public class EsTester extends ExternalResource {
     bulk.get();
   }
 
+  public void putDocuments(String index, String type, Map<String, Object>... docs) throws Exception {
+    BulkRequestBuilder bulk = client.prepareBulk().setRefresh(true);
+    for (Map<String, Object> doc : docs) {
+      bulk.add(new IndexRequest(index, type).source(doc));
+    }
+    bulk.get();
+  }
+
   public long countDocuments(String indexName, String typeName) {
     return client().prepareCount(indexName).setTypes(typeName).get().getCount();
   }