]> source.dussan.org Git - gitea.git/commitdiff
Fix error logged when repos qs is empty (#9591)
authorguillep2k <18600385+guillep2k@users.noreply.github.com>
Fri, 3 Jan 2020 21:39:12 +0000 (18:39 -0300)
committerLauris BH <lauris@nix.lv>
Fri, 3 Jan 2020 21:39:12 +0000 (23:39 +0200)
* Fix error logged when repos qs is empty

* Update routers/user/home.go

Co-Authored-By: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <matti@mdranta.net>
Co-authored-by: Lauris BH <lauris@nix.lv>
routers/user/home.go

index ae5975a711c6b811e0babb0ef4da318af12ad28c..f5e74b240664ebd7951ba2668b0495dfc6b3e3d0 100644 (file)
@@ -389,21 +389,23 @@ func Issues(ctx *context.Context) {
 
        reposQuery := ctx.Query("repos")
        var repoIDs []int64
-       if issueReposQueryPattern.MatchString(reposQuery) {
-               // remove "[" and "]" from string
-               reposQuery = reposQuery[1 : len(reposQuery)-1]
-               //for each ID (delimiter ",") add to int to repoIDs
-               for _, rID := range strings.Split(reposQuery, ",") {
-                       // Ensure nonempty string entries
-                       if rID != "" && rID != "0" {
-                               rIDint64, err := strconv.ParseInt(rID, 10, 64)
-                               if err == nil {
-                                       repoIDs = append(repoIDs, rIDint64)
+       if len(reposQuery) != 0 {
+               if issueReposQueryPattern.MatchString(reposQuery) {
+                       // remove "[" and "]" from string
+                       reposQuery = reposQuery[1 : len(reposQuery)-1]
+                       //for each ID (delimiter ",") add to int to repoIDs
+                       for _, rID := range strings.Split(reposQuery, ",") {
+                               // Ensure nonempty string entries
+                               if rID != "" && rID != "0" {
+                                       rIDint64, err := strconv.ParseInt(rID, 10, 64)
+                                       if err == nil {
+                                               repoIDs = append(repoIDs, rIDint64)
+                                       }
                                }
                        }
+               } else {
+                       log.Error("issueReposQueryPattern not match with query")
                }
-       } else {
-               log.Error("issueReposQueryPattern not match with query")
        }
 
        isShowClosed := ctx.Query("state") == "closed"