Fix quality flaws

diff --git a/server/sonar-server/src/main/java/org/sonar/server/db/migrations/AddColumnsBuilder.java b/server/sonar-server/src/main/java/org/sonar/server/db/migrations/AddColumnsBuilder.java
index 8d884296c8f23d587b073bed7e4c426653a5644e..34aca9d0e41c5a8b99be2a92fcc08377039d7ceb 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/db/migrations/AddColumnsBuilder.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/db/migrations/AddColumnsBuilder.java
@@ -91,11 +91,7 @@ public class AddColumnsBuilder {
       case STRING:
         return "VARCHAR";
       case BIG_INTEGER:
-        if (dialect.getId().equals(Oracle.ID)) {
-          return "NUMBER (38)";
-        } else {
-          return "BIGINT";
-        }
+        return !dialect.getId().equals(Oracle.ID) ? "BIGINT" : "NUMBER (38)";
       default:
         throw new IllegalArgumentException("Unsupported type : " + columnDef.getType());
     }

diff --git a/server/sonar-server/src/main/java/org/sonar/server/db/migrations/DdlChange.java b/server/sonar-server/src/main/java/org/sonar/server/db/migrations/DdlChange.java
index 6dafe50ec1bb492f7ebbdb361d52db2a530f4ee2..39944bae8e744382da80878728b93059c39ad049 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/db/migrations/DdlChange.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/db/migrations/DdlChange.java
@@ -47,7 +47,7 @@ public abstract class DdlChange implements DatabaseMigration {
     }
   }
 
-  public class Context {
+  public static class Context {
     private final Connection writeConnection;
 
     public Context(Connection writeConnection) {