]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-6423 The rule modal opens twice when show/hide/show an issue in the component...
authorStas Vilchik <vilchiks@gmail.com>
Wed, 15 Apr 2015 15:57:45 +0000 (17:57 +0200)
committerStas Vilchik <vilchiks@gmail.com>
Wed, 15 Apr 2015 15:57:45 +0000 (17:57 +0200)
server/sonar-web/src/main/js/source-viewer/viewer.js

index 82699e1779162c799659849d0837f51f894a7752..8b92da692a1ce7e61a809aa392d81894610a5067 100644 (file)
@@ -457,11 +457,17 @@ define([
         },
 
         onLineIssuesClick: function (e) {
-          var line = $(e.currentTarget).data('line-number');
-          if ($(e.currentTarget).parent().find('.issue-list').is('.hidden')) {
-            this.showIssuesForLine(line);
+          var line = $(e.currentTarget).data('line-number'),
+              issuesList = $(e.currentTarget).parent().find('.issue-list'),
+              areIssuesRendered = issuesList.find('.issue-inner').length > 0;
+          if (issuesList.is('.hidden')) {
+            if (areIssuesRendered) {
+              issuesList.removeClass('hidden');
+            } else {
+              this.showIssuesForLine(line);
+            }
           } else {
-            $(e.currentTarget).parent().find('.issue-list').addClass('hidden');
+            issuesList.addClass('hidden');
           }
         },