Simplify loops to copy (#19569)

- Simplify two loops into `copy` statements.

diff --git a/modules/setting/log.go b/modules/setting/log.go
index e666e2a027460cdabe117c8f78f147ea1f09211a..008a419b09d45af7ccee55caf8566e1cac1c4736 100644 (file)
--- a/modules/setting/log.go
+++ b/modules/setting/log.go
@@ -32,9 +32,8 @@ func GetLogDescriptions() map[string]*LogDescription {
        descs := make(map[string]*LogDescription, len(logDescriptions))
        for k, v := range logDescriptions {
                subLogDescriptions := make([]SubLogDescription, len(v.SubLogDescriptions))
-               for i, s := range v.SubLogDescriptions {
-                       subLogDescriptions[i] = s
-               }
+               copy(subLogDescriptions, v.SubLogDescriptions)
+
                descs[k] = &LogDescription{
                        Name:               v.Name,
                        SubLogDescriptions: subLogDescriptions,

diff --git a/routers/api/v1/repo/language.go b/routers/api/v1/repo/language.go
index 427a8fd6b54488b499e769e0c52e8c262026b2e4..f47b0a0e78831c2399437328e612a1b00326c64e 100644 (file)
--- a/routers/api/v1/repo/language.go
+++ b/routers/api/v1/repo/language.go
@@ -76,9 +76,7 @@ func GetLanguages(ctx *context.APIContext) {
        }
 
        resp := make(languageResponse, len(langs))
-       for i, v := range langs {
-               resp[i] = v
-       }
+       copy(resp, langs)
 
        ctx.JSON(http.StatusOK, resp)
 }