[user_ldap] Small perf improvements suggestion from review

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

diff --git a/apps/user_ldap/lib/Db/GroupMembershipMapper.php b/apps/user_ldap/lib/Db/GroupMembershipMapper.php
index 0868f60d2c50c3f6e89a70e4af7ec405593e7cb0..8f6af16b267e6402d075b111eac8c0744d84522f 100644 (file)
--- a/apps/user_ldap/lib/Db/GroupMembershipMapper.php
+++ b/apps/user_ldap/lib/Db/GroupMembershipMapper.php
@@ -47,7 +47,7 @@ class GroupMembershipMapper extends QBMapper {
                        ->from($this->getTableName())
                        ->executeQuery();
 
-               $groups = array_map(fn ($row) => $row['groupid'], $result->fetchAll());
+               $groups = array_column($result->fetchAll(), 'groupid');
                $result->closeCursor();
                return $groups;
        }

diff --git a/apps/user_ldap/lib/Service/UpdateGroupsService.php b/apps/user_ldap/lib/Service/UpdateGroupsService.php
index 5e463734079ff991ced531169873e42486a8ce1c..901b1e913ebd8940a579ec00d53ed83a0a586978 100644 (file)
--- a/apps/user_ldap/lib/Service/UpdateGroupsService.php
+++ b/apps/user_ldap/lib/Service/UpdateGroupsService.php
@@ -90,7 +90,7 @@ class UpdateGroupsService {
                        $this->logger->debug('service "updateGroups" – Dealing with {group}.', ['group' => $group]);
                        $groupMemberships = $this->groupMembershipMapper->findGroupMemberships($group);
                        $knownUsers = array_map(
-                               fn (GroupMembership $groupMembership): string => $groupMembership->getUserid(),
+                               static fn (GroupMembership $groupMembership): string => $groupMembership->getUserid(),
                                $groupMemberships
                        );
                        $groupMemberships = array_combine($knownUsers, $groupMemberships);